Main Koha release repository https://koha-community.org
Find a file
Galen Charlton 556eb67718 Bug 108661: (follow-up) enshrine letting CardnumberLength specify just a maximum
This patch finishes the work started in one of the previous
follow-ups and allows CardnumberLength to be set to a value
like ',5'.  In conjunction with not including cardnumber in
BorrowerMandatoryField, this allows a cardnumber to not be
required but, if present, to not exceed the specified length.

This patch also updates t/db_dependent/Members.t so that
it runs in a transaction, tests the new return value
of checkcardnumber, and manages the CardnumberLength syspref.

To test:

[1] Verify that prove -v t/db_dependent/Members.t and
    prove -v t/Members/cardnumber.t pass.
[2] Set CardnumberLength to ",5" and take cardnubmer out of
    the BorrowerMandatoryField list.
[3] Verify that you can save a patron record without a cardnumber,
    but if you supply one, that it can be at most 5 characters long.
[4] Add cardnumber back to BorrowerMandatoryField.  This time, the
    minimum length is 1 even though CardnumberLength is ",5".

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2014-03-12 04:07:03 +00:00
acqui Bug 11170: make the pending order list only display orders to receive 2014-03-11 15:09:56 +00:00
admin Bug 11675: check allocated total correctly when editing a fund that has a parent fund 2014-03-11 17:09:31 +00:00
authorities Bug 11652: ensure that merging authority records corrects biblios 2014-02-13 03:03:21 +00:00
basket Bug 10605: fix encoding issue on basket email (INTRANET) 2013-12-10 04:37:12 +00:00
C4 Bug 108661: (follow-up) enshrine letting CardnumberLength specify just a maximum 2014-03-12 04:07:03 +00:00
catalogue Bug 11096: support the retrieval of large MARCXML records 2014-02-28 19:50:09 +00:00
cataloguing Bug 11096: support the retrieval of large MARCXML records 2014-02-28 19:50:09 +00:00
circ Bug 11751: remove dead code related to handling members of institution patrons 2014-03-11 15:05:14 +00:00
course_reserves Bug 11866: (follow-up) repair security issue introduced by main patch 2014-03-10 14:57:17 +00:00
debian Bug 11705 - change versioning of build-git-snapshot 2014-03-12 01:49:56 +00:00
docs Bug 7143: Updating about page and history 2014-01-16 15:28:13 +00:00
errors
etc Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
install_misc Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
installer Bug 10861: DBrev 3.15.00.023 2014-03-12 02:26:37 +00:00
Koha Bug 7372: (follow-up) remove last traces of roadtype table and admin pages 2014-02-21 16:11:28 +00:00
koha-tmpl Bug 108661: (follow-up) enshrine letting CardnumberLength specify just a maximum 2014-03-12 04:07:03 +00:00
labels Bug 11096: support the retrieval of large MARCXML records 2014-02-28 19:50:09 +00:00
members Bug 10861: (follow-up) various refactoring 2014-03-12 02:17:34 +00:00
misc Bug 10777: (follow-up) improve CSS3 for Zebra-striping report email output 2014-03-11 14:57:26 +00:00
offline_circ Bug 10240: (follow-up) don't display patrons as lost or gone-no-address incorrectly 2013-10-11 01:57:05 +00:00
opac Bug 11516: make OPAC search term highlighting work in results browser 2014-03-10 21:30:38 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patron_lists Bug 10565: (follow-up) add new user permission for patron list management 2013-10-14 22:43:03 +00:00
patroncards Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
plugins Bug 7804 - Add Koha Plugin System - QA Followup 2 2013-03-20 14:50:19 -04:00
reports Bug 10718: fix items with no checkouts report 2013-09-08 20:04:43 +00:00
reserve Bug 9823: Refactor return from GetReservesFromBiblionumber 2014-01-30 16:19:55 +00:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections Bug 9605: rotating collections permissions are wrong 2013-03-30 22:11:05 -04:00
selenium
serials Bug 11096: support the retrieval of large MARCXML records 2014-02-28 19:50:09 +00:00
services Bug 7178: Acquisition item creation improvement 2012-03-26 11:07:23 +02:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 10611: Use mysql_auto_reconnect instead of ping 2014-03-10 23:15:35 +00:00
suggestion Bug 10277 - Add C4::Context->IsSuperLibrarian() 2013-12-30 15:47:23 +00:00
svc Bug 11704: Make */svc/report print the correct headers 2014-02-13 02:59:42 +00:00
t Bug 108661: (follow-up) enshrine letting CardnumberLength specify just a maximum 2014-03-12 04:07:03 +00:00
tags Bug 10730: Use DataTables on the tag review page 2013-09-25 16:47:59 +00:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities
tools Bug 10861: Add a check on cardnumber length 2014-03-12 02:16:18 +00:00
virtualshelves Bug 10853: All existing routing to get a CSV should return a MARC csv 2013-10-11 02:16:33 +00:00
xt Bug 11304: fix display of detail page holdings tab in translated Bootstrap theme 2013-11-27 16:52:02 +00:00
.htaccess
.mailmap 7439 Mailmap for master 2012-01-27 12:27:58 +01:00
about.pl Bug 11772: Show warning on About page:System information if no active currency is defined 2014-02-18 20:54:23 +00:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl Bug 11661: sanitize file names supplied to edithelp.pl 2014-02-05 01:36:10 +00:00
fix-perl-path.PL
help.pl Bug 11238: contruct links to the appropriate manual version dynamically 2013-11-23 19:30:16 +00:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
install-CPAN.pl
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.opensuse Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl Bug 10861: DBrev 3.15.00.023 2014-03-12 02:26:37 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 10080 - Change system pref IndependantBranches to IndependentBranches 2013-05-22 07:58:23 -07:00
Makefile.PL Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 10580: adjust Makefile.PL to reflect that Zebra no longer optional in Koha setup 2014-02-21 17:38:15 +00:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/