Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/includes
History
Lucas Gass 28771ad8b7 Bug 27868: Add expiration date to holds awaiting pickup 
To test:
1. Have some holds awaiting pickup, also have some holds that have been waiting longer than the ReservesMaxPickUpDelay is set to.
2. Go to /cgi-bin/koha/circ/waitingreserves.pl
3. There is no expiration date
4. Apply patch and restart_all
5. Now there should be a Expiration date column, make sure you can see it in both Holds waiting and Holds waiting over X days
6. Make sure all the columns Waiting Since, Date hold placed, and expiration date still sort correctly
6. Go to Table settings, and make sure all the columns hide correctly for both of the  holds_awaiting_pickup tables ( holdst & holdso )

Note: This patch also corrects 2 other small problems

1. Corrects a problem where the table settings did not account for the checkbox column at the beginnning of each table
2. Removes the title-string class and uses data-order to sort Waiting Since, Date hold placed, and expiration date ( see Bug 27934 )

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2022-01-28 11:09:07 -10:00
..
background_jobs Bug 29797: Fix display of itemnumbers on the background job detail view 2022-01-21 21:34:51 -10:00
catalogue Bug 27486: Rename system preference delimiter to CSVDelimiter 2021-01-29 09:03:45 +01:00
csv_headers Bug 16486: Display the timestamp when an accountline is updated 2021-05-06 15:52:41 +02:00
mana Bug 26703: (follow-up) Reverse title for mana report search results 2021-04-21 11:16:35 +02:00
modals Bug 29030: Make authorized value and description fields required 2021-09-29 12:47:33 +02:00
str Bug 26949: Upgrade TinyMCE in the staff interface from 5.0.16 to 5.9.2 2021-10-05 10:58:13 +02:00
virtualshelves/merge
about-team.inc Bug 28904: Fix typo and display 2021-11-02 16:50:01 +01:00
accounts.inc Bug 27946: (QA follow-up) Remove 'scan' terminology, requests may not be scans 2022-01-28 11:09:07 -10:00
acquisitions-add-to-basket.inc Bug 28079: Set focus to search box field when adding an order to basket 2021-10-21 10:21:50 +02:00
acquisitions-menu.inc Bug 27498: (follow-up) Update to display logic 2021-06-21 14:01:51 +02:00
acquisitions-search.inc Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter 2021-06-21 14:01:51 +02:00
acquisitions-toolbar.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
additional-fields-display.inc
additional-fields-entry.inc
admin-items-search-field-form.inc
admin-menu.inc Bug 14957: Feature hidden in menues if no other 'cagaloguing' permissions 2021-10-26 16:46:02 +02:00
adv-search.inc Bug 25954: Replace paragraph tags with labels in header search forms 2021-01-04 14:06:27 +01:00
auth-finder-search.inc Bug 26533: Fix 'is exactly' search for authorities 2021-04-21 10:51:29 +02:00
authorities-search-results.inc Bug 12533: Improve authority search result display 2020-11-04 12:59:33 +01:00
authorities-search.inc Bug 28475: Fix searching all headings 2021-05-28 08:29:38 +02:00
authorities-toolbar.inc Bug 28542: Move new authority from Z39.50/SRU to a button 2021-06-21 10:10:01 +02:00
authorities.inc
authorities_js.inc Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record 2020-10-26 00:16:14 +01:00
av-build-dropbox.inc Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account 2020-04-20 12:28:04 +01:00
biblio-title-head.inc
biblio-title.inc Bug 23852: Merge biblio-title.inc and biblio-default-view.inc 2020-10-08 15:01:29 +02:00
biblio-view-menu.inc Bug 10352: Use a new object_type parameter instead of the module's name 2020-01-10 08:36:37 +00:00
blocked-fines.inc Bug 29309: Make 'Pay all fines' be 'Pay all charges' 2021-10-25 14:08:06 +02:00
blocking_errors.inc Bug 10921: Prevent an order from a closed basket to be edited 2020-09-18 11:49:29 +02:00
borrower_debarments.inc Bug 29394: Remove flatpickr instantiations from most of the tt files 2021-11-22 11:48:45 +01:00
branch-selector.inc Bug 23184: Don't select branches for export by default 2019-11-21 11:32:31 +00:00
budget_planning.inc Bug 24636: (follow-up) - move 'by' into include file 2020-05-04 08:53:04 +01:00
budgets-active-currency.inc Bug 25744: replace <b> with <strong> in the staff interface 2020-09-18 11:08:35 +02:00
budgets-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
budgets-admin-toolbar.inc
calendar.inc Bug 29552: Disable today for dates in the future 2022-01-13 16:37:33 -10:00
cat-menu.inc
cat-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
cat-toolbar.inc Bug 9565: Deleting a biblio should alert/fail if there are existent subscriptions 2021-12-10 21:15:30 -10:00
catalog-strings.inc Bug 9565: (follow-up) Deleting a biblio should alert/fail if there are existent subscriptions 2021-12-10 21:15:30 -10:00
cataloging-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
catalogue-search-box.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
cateditor-ui.inc Bug 26964: Newly created macros should be selected in the Advanced editor 2021-03-08 15:15:52 +01:00
cateditor-widgets-marc21.inc Bug 27739: Advanced editor should use DefaultCountryField008 preference 2021-04-16 12:28:17 +02:00
category-out-of-age-limit.inc
chart.inc
checkin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
checkouts-table-footer.inc Bug 29459: Replace some missed datetimepickers in circulation templates with Flatpickr 2021-11-15 12:38:39 +01:00
checkouts-table.inc Bug 28271: Preselect the current item lost value 2021-06-21 10:50:09 +02:00
circ-menu.inc Bug 27811: Hide the Accounting tab if needed 2021-04-30 17:07:31 +02:00
circ-nav.inc Bug 24201: (QA follow-up) IndependentBranches 2020-08-07 16:54:40 +02:00
circ-patron-search-results.inc Bug 10902: (follow-up) Account for singleBranchMode 2021-08-16 11:55:56 +02:00
circ-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
cities-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
clubs-table.inc Bug 29521: Fix style of patron clubs table when in clubs management 2021-12-01 21:38:12 -10:00
columns_settings.inc Bug 29218: Rename .hidden class for DT visibility 2021-10-28 12:20:12 +02:00
contracts-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
country-list.inc
currencies-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
datatables.inc Bug 24662: Remove global variables MSG_* from datatables.inc 2020-03-11 13:49:15 +00:00
date-format.inc
delimiter_text.inc Bug 27486: Rename system preference delimiter to CSVDelimiter 2021-01-29 09:03:45 +01:00
desks-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
doc-head-close-receipt.inc
doc-head-close.inc Bug 28091: Only show for logged in users 2021-05-12 17:39:36 +02:00
doc-head-open.inc Bug 24732: Set DumpTemplateVars Dumper options for Indent and Sort 2020-03-02 10:08:31 +00:00
empty_line.inc
facets.inc Revert "Bug 26860: facets.inc refactor availability facet" 2021-08-16 12:24:58 +02:00
filter-orders.inc Bug 27287: Make note fields from orders history searchable 2021-10-21 12:24:04 +02:00
form-blocks.inc
format_price.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
greybox.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
guided-reports-view.inc Bug 28454: Add Koha version number to database schema link in reports 2021-09-29 12:47:33 +02:00
header.inc Bug 27699: Add register information to responsive staff interface header menu 2021-03-09 15:05:26 +01:00
holds_table.inc Bug 29737: Remove some unecessary parameters 2022-01-09 21:04:17 -10:00
home-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
html_helpers.inc Bug 29788: Fix batch delete item 2022-01-11 12:38:35 -10:00
i18n.inc Bug 26816: Chomp whitespace around i18n strings 2020-11-02 11:03:09 +01:00
ill-availability-table.inc Bug 23173: (follow-up) Fix QA script errors 2020-04-06 11:05:14 +01:00
ill-list-table-strings.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
ill-list-table.inc
ill-toolbar.inc
installer-doc-head-close.inc Bug 28982: Use Flatpickr on onboarding pages 2021-11-03 15:40:53 +01:00
installer-intranet-bottom.inc Bug 29837: Remove JS error during installer 2022-01-21 21:34:51 -10:00
installer-strings.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
intranet-bottom.inc Bug 24201: (follow-up) add desk choice with library choice 2020-08-07 16:54:40 +02:00
intranetstylesheet.inc
js-date-format.inc Bug 24980: (follow-up) return '' when date is null 2020-05-01 08:14:34 +01:00
js-patron-format.inc Bug 29575: (RM follow-up) remove HTML comments 2021-12-16 12:13:51 -10:00
js_includes.inc Bug 10902: (follow-up) Account for singleBranchMode 2021-08-16 11:55:56 +02:00
keyboard_shortcuts.inc
labels-toolbar.inc Bug 7468: Print barcodes by range 2020-01-21 11:28:19 +00:00
langmenu-staff-top.inc Bug 20168: Update of the OPAC bootstrap template to bootstrap v4 2020-09-09 14:13:03 +02:00
last-borrower.inc
letters-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
member-alt-address-style.inc Bug 28392: make streettype and B_streettype work with BorrowerUnwantedField 2021-09-09 10:59:38 +02:00
member-alt-contact-style.inc Bug 29213: Fix typo ol in member-alt-contact-style.inc 2021-10-15 11:34:26 +02:00
member-display-address-style.inc Bug 21794: (QA follow-up) Separate city and country with a comma 2021-09-09 10:59:38 +02:00
member-display-alt-address-style.inc Bug 21794: (QA follow-up) Separate city and country with a comma 2021-09-09 10:59:38 +02:00
member-main-address-style.inc Bug 28392: make streettype and B_streettype work with BorrowerUnwantedField 2021-09-09 10:59:38 +02:00
members-toolbar.inc Bug 28759: limit accessibility for "Manage API keys" 2021-09-30 09:19:02 +02:00
merge-record.inc
messaging-preference-form.inc Bug 28153: Add 'Hold reminder' messaging preference 2021-10-18 11:28:41 +02:00
noadd-warnings.inc
onboarding_messages.inc
page-numbers.inc Bug 14715: (follow-up) Keep results per page setting when selecting facets and sorting results 2020-03-26 12:03:42 +00:00
password_check.inc Bug 23816: Fix patron edition 2020-09-10 09:57:53 +02:00
patron-age.inc Bug 27717: Display date of birth even if the patron is under 1 2021-03-05 13:38:58 +01:00
patron-article-requests.inc Bug 29093: (QA follow-up) Adding two hover texts 2021-10-15 11:34:26 +02:00
patron-return-claims.inc Bug 27296: Return claims should be filtered by default to show unresolved claims 2021-11-03 15:40:52 +01:00
patron-search-box.inc Bug 25954: Replace paragraph tags with labels in header search forms 2021-01-04 14:06:27 +01:00
patron-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
patron-title.inc Bug 25747: Don't display a comma when patron has no firstname 2020-06-24 14:31:37 +02:00
patron-toolbar.inc
patron_messages.inc Bug 29889: Incorrect library check in patron message deletion logic 2022-01-19 12:13:49 -10:00
patroncards-errors.inc Bug 18320: Remove calls to CGI->param from the templates in patron cards 2022-01-19 12:13:49 -10:00
patroncards-toolbar.inc
patronfields.inc Bug 28438: Capitalization: Various corrections 2021-09-28 15:12:45 +02:00
patrons-admin-search.inc Bug 25954: Prevent two elements with id="description" in the DOM 2021-01-04 15:14:26 +01:00
permissions.inc Bug 14957: (QA follow-up) Rename 'merge' => 'overlay' 2021-10-26 16:46:02 +02:00
popup-bottom.inc
pos-menu.inc Bug 27583: Proposed terminology changes 2021-07-26 12:46:32 +02:00
prefs-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
prefs-menu.inc Bug 28438: Capitalization: Various corrections 2021-09-28 15:12:45 +02:00
relatives-issues-table.inc Bug 28047: Standardize: Call number, callnumber, Call no. etc. 2021-04-06 15:56:31 +02:00
renew_results.inc Bug 23051: (QA follow-up) Missing curly and tabs and fix test 2020-03-06 10:03:41 +00:00
renew_strings.inc Bug 25717: Improve automatic renewal error messages 2020-07-20 17:45:31 +02:00
reports-menu.inc Bug 20415: add Koha.ArePluginsEnabled Template Toolkit method 2020-03-26 11:41:54 +00:00
reports-toolbar.inc Bug 29680: Change markup to correct button radius 2022-01-05 13:49:09 -10:00
resort_form.inc Bug 25014: Fix capitalization for "Call Number" in staff and OPAC sort options 2020-04-03 14:26:34 +01:00
rotating-collections-toolbar.inc
search_indexes.inc Bug 20463: (follow-up) Remove option from search templates 2021-10-25 14:08:06 +02:00
select2.inc Bug 25727: (follow-up) Some style updates, JS i18n 2020-08-24 11:19:03 +02:00
serials-menu.inc Bug 28719: Change somes links in the serials page to avoid them leading to nothing 2021-08-16 09:56:37 +02:00
serials-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
serials-toolbar.inc
slip-print.inc Bug 27282: fix all occurrences 2021-04-21 10:51:29 +02:00
stockrotation-toolbar.inc
subscriptions-search.inc
subtypes_unimarc.inc
suggestions-add-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
timepicker.inc Bug 25133: (follow-up) Move changes to timepicker.inc 2020-05-04 13:45:31 +01:00
tools-item-action.inc Bug 26336: Add hint before and remove select after staging with no items 2020-12-04 15:40:58 +01:00
tools-menu.inc Bug 24387: Rename "News" with "Additional contents" 2021-08-16 11:55:55 +02:00
tools-nomatch-action.inc Bug 23236: Remove 'its items may still be processed' in action if no match is found 2020-03-18 08:41:35 +00:00
tools-overlay-action.inc
transaction_types.inc Bug 27796: (QA follow-up) Missing filters 2021-04-16 12:28:17 +02:00
transfer_reasons.inc Bug 22569: (QA follow-up) Make 'reason' translatable 2021-03-11 11:51:40 +01:00
validator-strings.inc Bug 25002: JS Includes should be wrapped with template comments 2020-04-29 17:15:20 +01:00
vendor-menu.inc
virtualshelves-toolbar.inc
waiting_holds.inc Bug 27868: Add expiration date to holds awaiting pickup 2022-01-28 11:09:07 -10:00
wysiwyg-systempreferences.inc Bug 26949: Upgrade TinyMCE in the staff interface from 5.0.16 to 5.9.2 2021-10-05 10:58:13 +02:00
xslt-handler.inc
z3950-admin-search.inc Bug 28356: Consolidate catalogue search box code 2021-09-21 20:22:57 +02:00
z3950_search.inc Bug 26291: Move translatable strings out of z3950_search.inc into z3950_search.js 2020-09-29 14:28:19 +02:00