Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
37542 commits 35 branches 612 tags 1.8 GiB
Perl 45.3%
JavaScript 39.4%
HTML 7.2%
XSLT 3.9%
Vue 1.4%
Other 2.3%
Find a file
Nick Clemens 64035301fc
Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron 
The drop_hold routine was using the wrong parameter for item info in the patron's
array of holds. We store it as 'barcode' not 'item_id'. This is true for both waiting and unavailable
holds

To test:
1 - Apply unit tests patch
2 - prove -v t/db_dependent/SIP/ILS.t
3 - It fails
4 - Apply second patch
5 - prove -v t/db_dependent/SIP/ILS.t
6 - It passes!

You can also see bug 24175 - you cna hack sip_cli_emulator to allow cancelling a hold
and check the messages, test coverage is improved by this patch and should be sufficient
for testing

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-03-20 15:39:24 +00:00
acqui Bug 21746: Remove NO_LIBRARY_SET 2020-03-02 10:20:42 +00:00
admin Bug 24701: Add column config to course_items_table 2020-03-19 09:08:33 +00:00
api/v1 Bug 24818: (RM follow-up) Update account_line date definition 2020-03-19 13:07:06 +00:00
authorities Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
basket Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
C4 Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron 2020-03-20 15:39:24 +00:00
catalogue Bug 5103: Refactor the code to avoid repetition 2020-03-16 10:56:45 +00:00
cataloguing Bug 5103: Refactor the code to avoid repetition 2020-03-16 10:56:45 +00:00
circ Bug 24298: Record transfer triggers for returns 2020-03-18 18:57:45 +00:00
clubs Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-03-23 09:51:36 +00:00
debian Bug 23975: (QA follow-up) Add another plugin source 2020-03-03 09:22:39 +00:00
docs Koha 19.12 - Dobbie is a free elf... 2019-12-02 17:13:15 +00:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 23975: (QA follow-up) Add another plugin source 2020-03-03 09:22:39 +00:00
ill Bug 23112: Add circulation to ILL requests 2020-03-10 10:58:58 +00:00
installer Bug 13775: Set main headings to mandatory in authority frameworks (UNIMARC) 2020-03-20 15:37:35 +00:00
Koha Bug 22025: Remove warnings when importing patrons 2020-03-20 15:38:25 +00:00
koha-tmpl Bug 8595: (follow-up) Changing other occurrences of 'host item' to 'host record' 2020-03-20 15:35:25 +00:00
labels Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
members Bug 23808: (follow-up) Object methods can be used directly, no need for unblessed 2020-03-20 15:25:41 +00:00
misc Bug 23411: Do not fall back to 'email' for SMS messages 2020-03-20 15:19:27 +00:00
offline_circ Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
opac Bug 24384: Add Access-Control-Allow-Origin support to OPAC reports svc 2020-03-19 09:23:13 +00:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
plugins Bug 23975: (follow-up) Don't rely on save_to being present 2020-03-03 09:19:04 +00:00
pos Bug 24492: (RM follow-up) Redirect to correct page after cashup 2020-03-05 14:16:58 +00:00
reports Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
reserve Bug 24802: Updating holds can cause suspensions to apply to wrong hold 2020-03-06 09:56:40 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 17674: Handling of special cases 2020-03-19 09:31:02 +00:00
services
skel
suggestion Bug 23594: Restore previous view after delete or update itemtype 2020-01-30 10:56:57 +00:00
svc Bug 24456: change default sort orders/make wording clearer 2020-03-18 08:44:12 +00:00
t Bug 24553: Unit tests 2020-03-20 15:39:14 +00:00
tags Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
tmp/modified_authorities
tools Bug 24846: Update items.onloan with the new due date 2020-03-19 08:56:38 +00:00
virtualshelves Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
xt Bug 24583: adjust xt/sample_notices.t 2020-03-09 15:19:01 +00:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
.mailmap
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
cpanfile Bug 24573: Add missing dependencies to cpanfile 2020-03-06 09:58:54 +00:00
fix-perl-path.PL
gulpfile.js Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display 2019-02-04 14:13:35 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 22987: DBRev 19.12.00.047 2020-03-19 09:29:24 +00:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-04 14:50:40 +00:00
Makefile.PL Bug 19735: Move Perl deps definitions into a cpanfile 2020-02-12 16:33:02 +00:00
MANIFEST.SKIP
package.json Bug 23025: security vulnerability detected in fstream < 1.0.12 defined in yarn.lock 2019-11-27 11:30:17 +00:00
README
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 17851: Add elasticsearch config to koha-conf.xml 2019-10-07 14:09:10 +01:00
yarn.lock Bug 23025: Update yarn.lock 2019-11-27 11:30:17 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo