Main Koha release repository https://koha-community.org
Find a file
Nick Clemens 6523db7321
Bug 31367: Add subtotals if budget has children
On bug 29287 we added child funds if a fund had no parent id

It turns out funds can have a parent, and still have children (sub-sub-funds)

This patch simply checks for children, rather than checking for lack of parent.

Totals are already calculated correctly in GetBudgetHierarchy

To test:
1 - Add a fund "Fund" to a budget - assign 1000 dollars
2 - Add a sub-fund "SubFund" - assign 100 dollars
3 - Add a sub-sub-fund "SubSubFund" - assign 10 dollars
4 - Add to a basket $5 order from SubSubFund
5 - Add to a basket $50 order from SubFund
6 - Add to a basket $500 order form Fun
7 - View acqui home - note 'SubFund' does not include total from 'SubSubFund'
8 - Apply patch
9 - Confirm all sub-sub-funds totaled in sub-funds and that fund total correctly adds sub and sub-sub funds

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-09-23 09:00:06 -03:00
acqui Bug 30359: GetBudgetHierarchy is slow on order receive page 2022-09-21 19:02:17 -03:00
admin Bug 30982: Use the REST API for background job list view 2022-09-23 08:57:47 -03:00
api Bug 30982: (QA follow-up) Spelling 2022-09-23 08:57:50 -03:00
authorities Bug 29333: Fix encoding of imported UNIMARC authorities 2022-07-08 15:43:33 -03:00
basket Bug 31309: Remove GetItemsInfo from basket/sendbasket 2022-08-16 09:22:14 -03:00
bin
C4 Bug 7021: (QA follow-up): Minor code cleanup 2022-09-22 09:33:17 -03:00
catalogue Bug 31535: Fix warning - uninitialized value in string ne (MARCdetail.pl) 2022-09-12 16:16:28 -03:00
cataloguing Bug 30025: Replace AllowManualAuthorityEditing with RequireChoosingExistingAuthority 2022-09-16 16:48:34 -03:00
circ Bug 28167: Remove uninitialized variable warnings from circ/set-library.pl 2022-09-22 08:09:34 -03:00
clubs Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
course_reserves Bug 30409: barcodedecode() should always trim barcode 2022-06-14 07:54:58 -03:00
debian Bug 27421: Commit and revert 2022-09-19 15:14:56 -03:00
docs Bug 30808: Add the 22.05 release team. 2022-05-25 23:56:12 -10:00
errors Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI 2022-04-20 09:03:39 -10:00
etc Bug 31236: Add ability to send custom item fields via SIP using Template Toolkit 2022-09-12 17:44:36 -03:00
ill Bug 28909: Allow illview to use backend template 2022-08-09 13:21:39 -03:00
installer Bug 7021: DBRev 22.06.00.051 2022-09-22 09:43:41 -03:00
Koha Bug 30982: (QA follow-up) No userenv, no jobs 2022-09-23 08:57:51 -03:00
koha-tmpl Bug 31367: Add subtotals if budget has children 2022-09-23 09:00:06 -03:00
labels Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
lib/CGI/Session/Serialize
members Bug 31562: Treat flags as other borrower fields 2022-09-22 09:24:41 -03:00
misc Bug 7021: Remove superflous 'open' 2022-09-22 09:31:28 -03:00
offline_circ Bug 30016: Remove GetOpenIssue subroutine 2022-08-31 08:50:37 -03:00
opac Bug 31531: Remove unnecessary use directives on opac-memberentry.pl 2022-09-16 16:52:45 -03:00
patron_lists
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins Bug 29787: Add plugin version to plugin search results 2022-04-08 15:49:15 +02:00
pos Bug 30619: Add email receipt to POS 2022-09-07 15:59:34 -07:00
recalls Bug 30924: Add missing branchtransfers.reason value for recall cancellation 2022-06-13 10:30:51 -03:00
reports Bug 28327: Unify CSV delimiter special behavior for tabulation 2022-08-19 15:53:12 -03:00
reserve Bug 24295: Remove GetTransfers from request.pl 2022-08-26 15:42:22 -03:00
reviews
rotating_collections
serials Bug 29608: Made so doesn't require full permission 2022-09-07 13:49:53 -07:00
services
skel
suggestion Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
svc Bug 27981: (follow-up) Correct variable 2022-09-12 15:17:36 -03:00
t Bug 30982: (QA follow-up) No userenv, no jobs 2022-09-23 08:57:51 -03:00
tags Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
tmp/modified_authorities
tools Bug 31590: Remove Text::CSV::Unicode 2022-09-21 16:07:21 -03:00
virtualshelves Bug 31320: Remove GetItemsInfo from virtualshelves/sendshelf.pl 2022-08-16 09:23:25 -03:00
xt Bug 31590: Remove Text::CSV::Unicode 2022-09-21 16:07:21 -03:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap 22.05.00: Update mailmap 2022-05-25 23:56:12 -10:00
.perlcriticrc
.proverc.dist
.scss-lint.yml
about.pl Bug 29744: (QA follow-up) Call psgi_env in OO style 2022-09-22 08:11:58 -03:00
app.psgi
changelanguage.pl
cpanfile Bug 31590: Remove Text::CSV::Unicode 2022-09-21 16:07:21 -03:00
fix-perl-path.PL
gulpfile.js Bug 30373: Enable translation of UNIMARC frameworks 2022-04-21 13:41:35 -10:00
help.pl
INSTALL
Koha.pm Bug 7021: DBRev 22.06.00.051 2022-09-22 09:43:41 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 30650: Add filter_by_scheduled_today 2022-07-29 15:00:47 -03:00
Makefile.PL Bug 19532: Database and installer stuff 2022-03-14 22:45:50 -10:00
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo