Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
38440 commits 35 branches 612 tags 1.8 GiB
Perl 45.3%
JavaScript 39.4%
HTML 7.2%
XSLT 3.9%
Vue 1.4%
Other 2.3%
Find a file
Tomas Cohen Arazi 6aeeae3e70
Bug 25421: Remove use of Koha::Libraries->pickup_locations 
The current implementation uses Koha::Libraries->pickup_locations which
is problematic and due to be removed by bug 24368. This patch makes the
trivial change of just searching for libraries that are marked with
pickup_location => 1.

Calls to Koha::Item->pickup_locations and Koha::Biblio->pickup_locations
are as well adapted to the new arrayref return value.

To test:
1. Pick a record with only one item
2. Place a biblio-level hold on it
3. Edit the items: remove the item
4. Go to the Holds tab
=> FAIL: It explodes
5. Apply this patch and restart:
   $ sudo koha-plack --restart kohadev
6. Go back and go to the holds tab again
=> SUCCESS: No failure!
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-05-12 11:00:14 +01:00
acqui Bug 24163: UTF-8 encode the output 2020-05-05 11:08:44 +01:00
admin Bug 24162: Add quantity column to the columns settings config 2020-05-05 11:08:58 +01:00
api/v1 Bug 17268: Update patchs per RFC 2020-05-04 08:26:33 +01:00
authorities Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
basket Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
C4 Bug 25184: Add syspref 2020-05-11 08:55:13 +01:00
catalogue Bug 23591: Hide archived suggestions 2020-04-14 16:36:41 +01:00
cataloguing Bug 25248: (bug 23463 follow-up) Adjust second occurrence 2020-05-11 14:18:48 +01:00
circ Bug 25133: Handle 12hr format for dt_from_string 2020-05-04 08:51:22 +01:00
clubs Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
course_reserves Bug 25341: Remove whitespace from barcode in add_items.pl 2020-05-04 09:44:42 +01:00
debian Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files 2020-05-05 10:59:03 +01:00
docs Koha 19.12 - Dobbie is a free elf... 2019-12-02 17:13:15 +00:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files 2020-05-05 10:59:03 +01:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 23787: (follow-up) Format due date as due date 2020-05-12 10:58:06 +01:00
Koha Bug 25421: Remove use of Koha::Libraries->pickup_locations 2020-05-12 11:00:14 +01:00
koha-tmpl Bug 25301: Removed URI parameter "categorycode" from the toolbar 2020-05-12 10:56:13 +01:00
labels Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
members Bug 20443: (follow-up) Remove C4::Members::AttributeTypes 2020-05-07 17:05:32 +02:00
misc Bug 25157: Silent patron deletion cmd line script 2020-05-11 09:57:07 +01:00
offline_circ Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
opac Bug 13388: Add library pages to the OPAC 2020-05-04 09:11:03 +01:00
patron_lists
patroncards Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
plugins Bug 20415: Remove UseKohaPlugins system preference 2020-03-26 11:42:02 +00:00
pos Bug 25139: Corrections to date picker handling 2020-04-15 08:33:07 +01:00
reports Bug 24940: Serials statistics wizard: order vendor list alphabetically 2020-04-08 11:46:21 +01:00
reserve Bug 16547: Remove more multi_holds inconsistencies 2020-05-11 14:00:32 +01:00
reviews
rotating_collections
serials Bug 25081: Fix wrong comment 2020-04-08 11:53:37 +01:00
services
skel
suggestion Bug 24819: (follow-up) Rename suggestor to suggester 2020-04-20 13:36:42 +01:00
svc Bug 4461: Fix status and borrowernumber fields in problem_reports and more 2020-04-06 11:18:59 +01:00
t Bug 25421: Make ->pickup_locations only return an arrayref 2020-05-12 10:59:58 +01:00
tags Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
tmp/modified_authorities
tools Bug 8132: Delete the items in a transaction and rollback if something wrong 2020-05-11 09:56:17 +01:00
virtualshelves Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
xt Bug 24897: (RM follow-up) Drop tests for es-ES notices 2020-04-28 06:55:56 +01:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore
.htaccess
.mailmap
.scss-lint.yml
about.pl Bug 25172: Identify and display possible problems on the about page 2020-04-22 13:44:12 +01:00
changelanguage.pl
cpanfile Bug 24573: Add missing dependencies to cpanfile 2020-03-06 09:58:54 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
INSTALL
Koha.pm Bug 25184: DBRev 19.12.00.087 2020-05-11 08:57:47 +01:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl
LICENSE
mainpage.pl Bug 4461: Fix status and borrowernumber fields in problem_reports and more 2020-04-06 11:18:59 +01:00
Makefile.PL Bug 25149: Fix Zebra language code for Greek 2020-04-29 17:14:30 +01:00
MANIFEST.SKIP
package.json Bug 23025: security vulnerability detected in fstream < 1.0.12 defined in yarn.lock 2019-11-27 11:30:17 +00:00
README
README.md
README.robots
rewrite-config.PL Bug 17851: Add elasticsearch config to koha-conf.xml 2019-10-07 14:09:10 +01:00
yarn.lock Bug 23025: Update yarn.lock 2019-11-27 11:30:17 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo