Main Koha release repository https://koha-community.org
Find a file
Jacek Ablewicz 7289214e30 Bug 12811 - Patron 'Details' and 'Check out' pages not working for staff users without renewal override permissions
In case when the staff user doesn't have (circulate) ->
(override_renewals) permission granted, this code part

   var AllowRenewalLimitOverride = [%
CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %];

in circ/circulation.tt and members/moremember.tt leads to javascript
error, because TT statement evaluates to empty string.

To reproduce:

- set AllowRenewalLimitOverride syspref to "Don't allow" (this step is
  possibly redundant / not quite relevant),
- for testing purposes, log in as some (sample) staff user whitch does
  not have permission granted for "(override_renewals) Override blocked
  renewals",
- have a look at some patron accounts (preferably, ones with 1+
  check-out), observe that page layout is incorrect in "Check Out" and
  "Details" tab.

To test:

- apply patch,
- retest and ensure that this issue is no longer reproductible,
- make sure that there are no regressions of any kinds regarding renewal
  override permission for staff users (i.e, that it still works like
  intended).

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes QA script and tests.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2014-09-16 15:18:54 -03:00
acqui Bug 6536: Include SRU searching in Breeding.pm 2014-09-01 10:09:07 -03:00
admin Bug 7817: (followup) add test on MARC bibliographic framework test 2014-09-08 12:29:38 -03:00
authorities Bug 12177 - Remove HTML from authorities.pl 2014-08-19 09:27:08 -03:00
basket Bug 9013 - Cart in staff interface displays location pulled from Description (OPAC) 2014-08-11 15:53:31 -03:00
C4 Bug 12898 - Z39.50 title search doesn't work with multiple words 2014-09-14 02:02:51 -03:00
catalogue Bug 12330: [QA Follow-up] Consistency between opac-search and staff client 2014-09-05 12:06:04 -03:00
cataloguing Bug 6536: Include SRU searching in Breeding.pm 2014-09-01 10:09:07 -03:00
circ Bug 12523 - Add patron email in Holds awaiting pickup circulation rapport 2014-08-07 16:18:23 -03:00
course_reserves Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
debian Bug 12870 - require a higher version of Test::Simple 2014-09-15 10:52:43 -03:00
docs Bug 7143 Updating history 2014-08-19 09:38:23 -03:00
errors Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
etc Bug 12453 - Do not use by default Host-Item-Number in UNIMARC 2014-08-24 12:32:30 -03:00
install_misc Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
installer Bug 12557: DBRev 3.17.00.023 2014-09-09 10:11:44 -03:00
Koha Bug 6536: (RM followup) make DBIx::Class::Schema::Loader happy 2014-09-01 10:25:25 -03:00
koha-tmpl Bug 12811 - Patron 'Details' and 'Check out' pages not working for staff users without renewal override permissions 2014-09-16 15:18:54 -03:00
labels Bug 11614: Untranslatable label_element_title in label management 2014-08-19 09:42:42 -03:00
members Bug 12693 - colspan calculation done by members/statistics.pl should be moved to template 2014-08-11 15:47:14 -03:00
misc Bug 12061 - tmpl_process3.pl - Include/exclude file by name 2014-09-01 11:00:15 -03:00
offline_circ Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
opac Bug 12849 - fix URLs in sent lists 2014-09-09 10:32:05 -03:00
OpenILS
patron_lists Bug 10565: (follow-up) add new user permission for patron list management 2013-10-14 22:43:03 +00:00
patroncards Bug 5502 - Patron card category search field should be menu 2014-08-10 09:30:47 -03:00
plugins Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
reports Bug 12587 - Improve output of filter information on patrons with the most checkouts report 2014-09-09 10:39:18 -03:00
reserve Bug 12287: At the moment, found is 'W', 'T' or NULL 2014-08-16 09:06:51 -03:00
reviews Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
rotating_collections Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
selenium
serials Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
services Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
suggestion Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
svc Bug 12729 - Overdue items won't show as overdue in red in circulation 2014-09-16 15:17:53 -03:00
t Bug 12918: fix failing test case 2014-09-15 10:53:00 -03:00
tags Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
test Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
tmp/modified_authorities
tools Bug 12859 - Patron import tool doesn't import extened attributes values any longer 2014-09-16 15:09:35 -03:00
virtualshelves Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
xt Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess
.mailmap Bug 12479: (QA followup) minor fixes, and tcohen added 2014-06-30 10:04:10 -03:00
about.pl Bug 12790 - Perl modules: Display required version numbers on about page 2014-09-05 10:16:17 -03:00
changelanguage.pl
edithelp.pl Bug 11661: sanitize file names supplied to edithelp.pl 2014-02-05 01:36:10 +00:00
fix-perl-path.PL
help.pl
INSTALL
install-CPAN.pl
INSTALL.debian
INSTALL.fedora7
INSTALL.opensuse
INSTALL.ubuntu
koha_perl_deps.pl
kohaversion.pl Bug 12557: DBRev 3.17.00.023 2014-09-09 10:11:44 -03:00
LICENSE
mainpage.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
Makefile.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00
MANIFEST.SKIP
README
README.robots
rewrite-config.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/