Koha/C4
Galen Charlton 784316826c bug 1710 and 1739: availability for item-level holds
Fixed rules for determining whether an item is
available for an item-level hold request.  Create a
new function in C4::Reserves, IsAvailableForItemRequest(),
that checks whether an item is potentially available for
an item-level hold request.

An item is considered available if:

* it is not lost AND,
* it is not marked not for loan AND,
* it is not withdrawn AND,
* it is not damaged (unless the AllowHoldsOnDamagedItems syspref is ON), AND
* it is not on loan (unless the AllowOnShelfHolds syspref is ON)

Preventing a hold request on withdrawn items is bug 1739, as is
the new preference on whether to allow holds on damaged items.

Removing the condition that an item cannot be requested if
it has already been requested by another patron is the topic of bug 1710.

Note that this patch does not change the behavior where if
independent branches is on and the canreservefromotherbranches
syspref is off, a staff operator is prevented from placing
an item-level hold request on an item from a different branch.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 14:14:49 -05:00
..
AuthoritiesMarc added C4/AuthoritesMarc/*.pm missed in previous patch 2008-01-04 19:08:30 -06:00
Barcodes PrinterConfig.pm - BEGIN block VERSION and vars related to export. 2008-01-07 20:02:21 -06:00
ClassSortRoutine ignore "/" when sorting Dewey call numbers 2007-10-23 18:24:29 -05:00
External C4/External/BakerTaylor.pm - Back end for B&T content. 2008-04-22 18:02:33 -05:00
Heading bug 2247: don't crash linking bib heading with invalid subfield 2008-06-16 10:24:27 -05:00
Members Bug 2176 (2/5): adding patron interface to update messaging preferences 2008-06-20 13:04:50 -05:00
OAI OAI-PMH second try 2008-02-27 09:02:20 -06:00
Search FRBR: added OPAC search result grouping option 2008-02-11 16:35:17 -06:00
SIP SIP - Lots of regexp hacking of input streams and verbose debugging feedback. 2008-06-20 06:12:42 -05:00
tests Patch from Galen Charlton, removing $Id$ $Log$ and $Revision$ from files 2007-10-18 20:22:01 -05:00
VirtualShelves kohabug 1873 Fixes shelves.pl so that the date is displayed in the 'date added' column of the virtual shelf contents 2008-06-20 12:48:01 -05:00
Accounts.pm Fix for bug 2183, "Account tab needs spacing between description and stadard text" Please note that this is a band-aid for a larger issue, described in Bug 2188 2008-05-31 21:59:52 -05:00
Acquisition.pm just doing a <= / >= instead of a < / > in history search. 2008-06-20 08:48:31 -05:00
Amazon.pm adding famfamfam iconset, improving isbn for amazon content, etc. 2008-04-07 21:20:22 -05:00
Auth.pm Bug 2176 (2/5): adding patron interface to update messaging preferences 2008-06-20 13:04:50 -05:00
Auth_with_ldap.pm Bugfix LDAP config to play nice with Zebra. 2008-06-16 15:37:13 -05:00
AuthoritiesMarc.pm unlocking table when adding/updating authorities is finished. 2008-04-24 11:51:48 -05:00
BackgroundJob.pm C4 - BEGIN blocks and 1; __END__ for modules 2008-01-07 20:02:18 -06:00
Biblio.pm kohabug 2207 - improve indicator input in MARC editor 2008-06-12 11:17:35 -05:00
Bookfund.pm bug-1494, fixed bookfund modify code 2007-11-01 17:27:55 -05:00
Bookseller.pm acqui/addorder.pl - use reliable GetBookSellerFromId instead of relying on name search. 2008-03-08 11:19:27 -06:00
Boolean.pm Boolean.pm - BEGIN block VERSION and vars related to export. 2008-01-07 20:02:24 -06:00
Branch.pm bug 1953: fixing potential SQL injection problems in C4::Branch::GetBranches 2008-05-12 15:07:17 -05:00
Breeding.pm IMPORTANT - refactor MARC character set handling 2008-02-03 07:23:56 -06:00
Calendar.pm Single FIXME comment inserted. 2008-05-29 07:04:39 -05:00
Charset.pm work around issue in MARC::Charset 2008-04-01 06:46:04 -05:00
Circulation.pm Bug 2176 (3/5): adding methods to manage message_queue, new advance_notices.pl, new C4::SMS module 2008-06-20 13:04:52 -05:00
ClassSortRoutine.pm call number work part 2 -- added framework for call number filing routines 2007-10-21 22:11:37 -05:00
ClassSource.pm call number work part 3 -- now using new routines to generate call number sort keys 2007-10-21 22:11:40 -05:00
Context.pm kohabug 2238 This patch allows patrons to add books to public open/free lists whether they are logged in or not. 2008-06-20 12:48:11 -05:00
Date.pm removing all useless %env / $env 2007-04-18 17:00:14 +00:00
Dates.pm Dates.pm - trivial perldoc corrections 2008-04-08 17:00:07 -05:00
Debug.pm C4::Debug - should resolve conflict w/ CGI upload. Debug no longer uses CGI. 2008-03-16 08:32:20 -05:00
Heading.pm Porting SimpleSearch return changes to all code calling it. 2008-04-17 05:52:45 -05:00
ImportBatch.pm staging import - enhance record overlay behavior 2008-04-30 21:58:46 -05:00
Input.pm Input.pm - perldoc correction 2007-12-27 17:21:07 -06:00
Installer.pm C4::Installer - new method to get available MARC frameworks 2008-05-11 06:48:55 -05:00
Items.pm Bug 2094: fixing two bugs in lost items report 2008-05-11 06:48:51 -05:00
Koha.pm bug 2000 - remove base64 functions from C4::Koha 2008-06-20 08:19:11 -05:00
Labels.pm Repair Labels code to accomodate patroncards. Purged EXPR. 2008-05-30 10:01:08 -05:00
Languages.pm Fixing some typos, including, I believe, Bug 2174 ("spelling error in web installer") 2008-05-30 10:01:07 -05:00
Letters.pm Bug 2176 (4/5): adding RSS feed for patron overdue alerts 2008-06-20 13:04:53 -05:00
Log.pm refactor C4::Log::logaction 2008-03-19 06:34:10 -05:00
Maintainance.pm rel_3_0 moved to HEAD (introducing new files) 2007-03-09 15:34:17 +00:00
Matcher.pm Porting SimpleSearch return changes to all code calling it. 2008-04-17 05:52:45 -05:00
Members.pm Fix upgrade-child: could not update child unless guarantor was defined. Also, limit upgrade path to C -> A . 2008-06-12 16:36:50 -05:00
NewsChannels.pm NewsChannels.pm - BEGIN block VERSION and vars related to export. 2008-01-07 20:02:36 -06:00
Output.pm Fix for 2187: http_accept_language feature not working 2008-06-20 14:09:12 -05:00
Overdues.pm Bug 2176 (3/5): adding methods to manage message_queue, new advance_notices.pl, new C4::SMS module 2008-06-20 13:04:52 -05:00
Print.pm Print.pm - BEGIN block VERSION and vars related to export. 2008-01-07 20:02:39 -06:00
Record.pm fixed MODS biblio export on a "standard" install 2008-04-01 06:46:08 -05:00
Reports.pm bug 2004: changes to guided reports on items 2008-04-08 17:00:12 -05:00
Reserves.pm bug 1710 and 1739: availability for item-level holds 2008-06-20 14:14:49 -05:00
Review.pm minor cleanup, remove $sth->finish's. No documentation impact. 2008-05-30 10:01:06 -05:00
Scheduler.pm kohabug 1993 - task scheduler improvements 2008-06-09 06:38:03 -05:00
Scrubber.pm Unescape Comment, now that we trust Scrubber to block bad markup. 2008-05-29 06:30:51 -05:00
Search.pm bug 2098: do not apply stemming if search term has digits 2008-06-10 08:22:18 -05:00
Serials.pm Add Debug for warns and remove unnecessary middleman variables from returns. 2008-06-05 22:43:19 -05:00
SMS.pm Bug 2176 (3/5): adding methods to manage message_queue, new advance_notices.pl, new C4::SMS module 2008-06-20 13:04:52 -05:00
Stats.pm Work in progress, working on the til reconciliation report 2008-01-07 20:49:16 -06:00
Suggestions.pm bugfix : ship utf-8 encoding in mail header 2008-05-12 10:07:55 -05:00
Tags.pm Bugfix is_approved() to handle the 3-state nature of approval. 2008-06-05 22:41:40 -05:00
UploadedFile.pm C4 - BEGIN blocks and 1; __END__ for modules 2008-01-07 20:02:18 -06:00
Utils.pm Big LDAP changes, module test for Context.pm, still more yet to come. 2007-12-04 17:27:06 -06:00
VirtualShelves.pm kohabug 1873 Fixes shelves.pl so that the date is displayed in the 'date added' column of the virtual shelf contents 2008-06-20 12:48:01 -05:00
XISBN.pm Fixing isbn regex to not match unless isbn is valid 2008-05-19 13:12:18 -05:00
XSLT.pm Normalizing s/On loan/Checked out/ 2008-04-25 15:28:14 -05:00
Z3950.pm Z3950.pm - BEGIN block VERSION and vars related to export. 2008-01-07 20:02:50 -06:00