Main Koha release repository https://koha-community.org
Find a file
Joonas Kylmälä 9b4b43656e
Bug 30947: Simplify CanBookBeIssued date handling
1) This removes support for passing string dates to CanBookBeIssued. The
function didn't publicly even document support for string dates, only
DateTime objects.

2) We get a $duedate always at least from CalcDateDue so having

 $issuingimpossible{INVALID_DATE} = output_pref($duedate);

was unneccesary and thus removed.

3) The check "duedate cannot be before now" was needlessly complex: if
the due date really cannot be before now we should check seconds too
and warn the librarian! Thus the truncation to minutes can be dropped
safely.

To test:
 1) prove t/db_dependent/Circulation.t
 2) prove t/db_dependent/Illrequests.t
 3) Enable OnSiteCheckouts and disable SpecifyDueDate syspref. Create
 on-site checkout for any patron and verify the due date is your
 current date at 23:59, you can check the exact minute with sql:
  > select * from issues

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-06-23 11:38:44 -03:00
acqui Bug 29607: Store the discount amount correctly when importing and order from a file 2022-06-06 14:28:51 -03:00
admin Bug 30798: Change column order on account-fines table column settings 2022-06-13 10:56:09 -03:00
api Bug 30780: Librarians with only "place_holds" permissions can not update holds data via REST API 2022-06-13 11:48:10 -03:00
authorities Bug 29260: 210a is reported to Autor (meeting/conference) when upgrading an authority through Z3950 2022-06-06 13:48:13 -03:00
basket Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes 2022-06-06 14:26:51 -03:00
bin
C4 Bug 30947: Simplify CanBookBeIssued date handling 2022-06-23 11:38:44 -03:00
catalogue Bug 30997: Fix "CGI::param called in list context" warning in detail.pl 2022-06-21 14:40:59 -03:00
cataloguing Bug 29963: Do not prefill empty date fields with today's date 2022-06-17 10:35:35 -03:00
circ Bug 30947: Simplify CanBookBeIssued date handling 2022-06-23 11:38:44 -03:00
clubs
course_reserves Bug 30409: barcodedecode() should always trim barcode 2022-06-14 07:54:58 -03:00
debian Bug 30511: Don't lock up entire database while running koha-dump 2022-05-10 23:09:09 -10:00
docs Bug 30808: Add the 22.05 release team. 2022-05-25 23:56:12 -10:00
errors
etc Bug 29936: Add holds_get_captured option to sip config 2022-05-05 11:17:37 -10:00
ill
installer Bug 30924: DBRev 22.06.00.003 2022-06-16 11:36:43 -03:00
Koha Bug 30947: Simplify CanBookBeIssued date handling 2022-06-23 11:38:44 -03:00
koha-tmpl Bug 28355: (QA follow-up) Move Note to new line 2022-06-21 15:24:27 -03:00
labels Bug 30813: Update TransformMarcToKoha to accept a hashref 2022-06-08 11:40:29 -03:00
lib/CGI/Session/Serialize
members Bug 30420: Rename Koha::Patron->get_overdues with ->overdues 2022-06-14 08:46:05 -03:00
misc Bug 30914: (24153 follow-up) Fix cleanup_database.pl --transfers --old-reserves 2022-06-13 10:32:10 -03:00
offline_circ Bug 30525: Items batch modification broken 2022-04-21 13:41:36 -10:00
opac Bug 30844: Ensure that allow_nonref is enabled when using older versions of JSON 2022-06-09 09:37:43 -03:00
patron_lists
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins
pos
recalls Bug 30924: Add missing branchtransfers.reason value for recall cancellation 2022-06-13 10:30:51 -03:00
reports Bug 30551: Make cash register report take branchcode from cash register 2022-05-06 10:33:10 -10:00
reserve Bug 30960: Fix JS error message when no pick-up location is selected when placing a hold 2022-06-20 10:44:04 -03:00
reviews
rotating_collections
serials Bug 30813: Update TransformMarcToKoha to accept a hashref 2022-06-08 11:40:29 -03:00
services
skel
suggestion Bug 30127: By default show pending suggestions tab 2022-05-10 23:09:09 -10:00
svc Bug 30971: (follow-up) Fix one more occurence 2022-06-16 09:40:57 -03:00
t Bug 30947: Simplify CanBookBeIssued date handling 2022-06-23 11:38:44 -03:00
tags Bug 29469: (bug 17600 follow-up) Fix tag approval/rejection from staff 2021-11-16 15:49:22 +01:00
tmp/modified_authorities
tools Bug 30972: Don't replace biblio's local cover images when uploading an image's image 2022-06-20 10:39:34 -03:00
virtualshelves
xt Bug 27619: (QA follow-up) Remove xt/sample_notices.t 2022-05-11 11:28:48 +01:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json
.gitignore
.htaccess
.mailmap 22.05.00: Update mailmap 2022-05-25 23:56:12 -10:00
.perlcriticrc
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.scss-lint.yml
about.pl Bug 28998: (follow-up) Add warning on about for missing key 2022-05-04 05:18:31 -10:00
app.psgi
changelanguage.pl
cpanfile Bug 25669: (follow-up) Minor fixes 2022-06-23 11:30:44 -03:00
fix-perl-path.PL
gulpfile.js Bug 30373: Enable translation of UNIMARC frameworks 2022-04-21 13:41:35 -10:00
help.pl
INSTALL
Koha.pm Bug 30924: DBRev 22.06.00.003 2022-06-16 11:36:43 -03:00
koha_perl_deps.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl
LICENSE
mainpage.pl Bug 29020: Add link on the mainpage for users without admin access 2021-10-19 09:29:09 +02:00
Makefile.PL
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo