Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
21315 commits 35 branches 616 tags 1.8 GiB
Perl 45.6%
JavaScript 39.3%
HTML 7.2%
XSLT 3.7%
Vue 1.4%
Other 2.3%
Find a file
Kyle M Hall a18ce86e83 Bug 12243: ensure that records with invalid ISBNs do not cause searches to fail 
Some types of invalid ISBNs, when run through C4::Koha::NormalizeISBN
can produce ISBN objects that contain invalid ISBNs. This can be
reproduced with an ISBN that has an invalid prefix, group code or
publisher code. An example ISBN would be "0788893777 (2 DVD 45th ed)".

When attempting to look up a record with such an ISBN, you will get an
error along the lines of: Can't call method "as_string" on an undefined
value

Instead of checking for the BAD_ISBN state, we should be checking for
the GOOD_ISBN state via the method is_valid.

Test Plan:
1) Edit a record, add the following ISBN to your record:
   0788893777 (2 DVD 45th ed)
2) When Koha redirects to the record, you should see the error message
   described
3) Apply this patch
4) Reload the page, you should now see your record

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2014-05-19 15:42:56 +00:00
acqui Bug 11433: (code cleanup) remove unused 'attachbasket' op value in basket.pl 2014-05-07 15:19:21 +00:00
admin Bug 6739: make it possible to block expired patrons from OPAC actions 2014-05-05 01:49:05 +00:00
authorities Bug 10862: Add search history to the intranet interface 2014-05-05 03:06:33 +00:00
basket Bug 12065: use encode_qp consistently when sending basket/shelf 2014-05-09 15:14:40 +00:00
C4 Bug 12243: ensure that records with invalid ISBNs do not cause searches to fail 2014-05-19 15:42:56 +00:00
catalogue Bug 10857: (follow-up) make it possible to remove facets that contain diacritics 2014-05-05 21:44:03 +00:00
cataloguing Bug 11254: make reservoir search normalize ISBNs 2014-04-19 21:44:30 +00:00
circ Bug 8231: display warning at check in if borrower is restricted 2014-05-05 00:41:32 +00:00
course_reserves Bug 11866: (follow-up) repair security issue introduced by main patch 2014-03-10 14:57:17 +00:00
debian Bug 12234 - build script version update 2014-05-13 14:10:51 +00:00
docs Bug 7143: Updating history with new developers 2014-04-14 14:37:48 +00:00
errors
etc Bug 8375: (follow-up) fix font code and alignment 2014-05-05 21:55:16 +00:00
install_misc Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
installer Bug 12240 - update of Italian SQL files (non-MARC setup) 2014-05-19 15:26:16 +00:00
Koha Bug 9723: display time due for hourly loans in the public catalog 2014-05-08 16:38:43 +00:00
koha-tmpl Bug 12206: fix HTML in other holdings list in staff search results page 2014-05-13 14:07:12 +00:00
labels Bug 8375: Use TrueType fonts in PDF::Reuse 2014-05-05 21:53:18 +00:00
members Bug 12198: (follow-up) fix warning when opening guarantor search form 2014-05-08 16:16:52 +00:00
misc release notes for Koha 3.16.0-beta 2014-05-05 23:26:31 +00:00
offline_circ Bug 10240: (follow-up) don't display patrons as lost or gone-no-address incorrectly 2013-10-11 01:57:05 +00:00
opac Bug 12065: use encode_qp consistently when sending basket/shelf 2014-05-09 15:14:40 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patron_lists Bug 10565: (follow-up) add new user permission for patron list management 2013-10-14 22:43:03 +00:00
patroncards Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
plugins Bug 7804 - Add Koha Plugin System - QA Followup 2 2013-03-20 14:50:19 -04:00
reports Bug 12214: display SQL errors in reports to users 2014-05-09 14:40:01 +00:00
reserve Bug 9823: Refactor return from GetReservesFromBiblionumber 2014-01-30 16:19:55 +00:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections Bug 9605: rotating collections permissions are wrong 2013-03-30 22:11:05 -04:00
selenium
serials Bug 11263: Use all languages instead of just the translated ones 2014-05-05 05:01:36 +00:00
services Bug 7178: Acquisition item creation improvement 2012-03-26 11:07:23 +02:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 10611: Use mysql_auto_reconnect instead of ping 2014-03-10 23:15:35 +00:00
suggestion Bug 4068: (follow-up) use URI::Escape 2014-05-08 16:36:10 +00:00
svc Bug 12114: (QA Followup) Use JSON instead of JSON::XS 2014-04-25 15:32:06 +00:00
t Bug 12243: add regression test 2014-05-19 15:42:56 +00:00
tags Bug 10730: Use DataTables on the tag review page 2013-09-25 16:47:59 +00:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities
tools Bug 11975: (follow-up) simplify construction of params for GetBorrowersToExpunge() 2014-05-09 14:32:30 +00:00
virtualshelves Bug 12065: use encode_qp consistently when sending basket/shelf 2014-05-09 15:14:40 +00:00
xt Bug 12076: better detect an untranslatable template construct 2014-04-12 17:57:35 +00:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap 7439 Mailmap for master 2012-01-27 12:27:58 +01:00
about.pl Bug 11596: report warnings on the about patch if indexing options in koha-conf.xml are missing 2014-04-20 17:07:04 +00:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl Bug 11661: sanitize file names supplied to edithelp.pl 2014-02-05 01:36:10 +00:00
fix-perl-path.PL
help.pl Bug 11238: contruct links to the appropriate manual version dynamically 2013-11-23 19:30:16 +00:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.opensuse Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl DBRev 3.15.00.051: mark Koha 3.16 beta 2014-05-05 23:27:44 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 7567 - Use, display, filter News by library 2014-04-07 18:14:19 +00:00
Makefile.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00

README 

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/