Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
52614 commits 35 branches 616 tags 1.8 GiB
Perl 45.6%
JavaScript 39.3%
HTML 7.2%
XSLT 3.7%
Vue 1.4%
Other 2.3%
Find a file
Tomas Cohen Arazi aa1049fdd3
Bug 36056: Clarify subpermissions AND behavior 
Working on bug 31791, I found myself wondering if our current recursive
code in C4::Auth::haspermission() would allow checking AND on
subpermissions.

As it is not documented in the POD or tested, I decided to write some
unit tests for it.

It turned out it was well supported, so I decided to submit the tests,
and a small tweak in the POD to reflect that.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Auth/haspermission.t
=> SUCCESS: Tests pass! The code supports AND on subpermissions!
3. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-03-07 17:35:40 +01:00
acqui Bug 35892: Populate order price using GetMarcPrice if no price specified 2024-03-07 16:36:44 +01:00
admin Bug 34478: Replace delete links with form - smart-rules 2024-03-01 11:00:15 +01:00
api Bug 35469: Add 'manage_bookings' permission to biblios/checkouts 2024-03-07 17:35:40 +01:00
authorities Bug 34478: Regression - fix change auth type 2024-03-01 10:59:15 +01:00
basket Bug 34478: Add 'op' to sendbasketform 2024-03-01 10:58:53 +01:00
bin
bookings Bug 35574: Bookings tab from biblio details should only require manage_bookings permission 2023-12-18 15:21:04 +01:00
C4 Bug 36056: Clarify subpermissions AND behavior 2024-03-07 17:35:40 +01:00
catalogue Bug 36000: Fix CGI::param warning in catalogue search 2024-03-07 15:02:43 +01:00
cataloguing Bug 34478: Fix delallitems for additem 2024-03-01 11:00:19 +01:00
circ Bug 36175: Corrections to reduced due for booked items 2024-03-07 16:36:32 +01:00
clubs Bug 34478: Manual fix - add op clubs/templates-add-modify 2024-03-01 10:57:55 +01:00
course_reserves Bug 34478: Manual fix - Course reserves 2024-03-01 10:56:56 +01:00
debian Bug 36009: Document koha-worker --queue elastic_index 2024-03-07 15:02:48 +01:00
docs Bug 35504: Split list of ERM Topic experts 2024-01-11 15:44:51 +01:00
erm
errors Bug 36148: Improve error handling and restore programming errors 2024-03-01 11:01:06 +01:00
etc Bug 35086: (follow-up) Use 5000 as example in conf file 2024-01-16 12:06:02 +01:00
ill Bug 36245: Remove cud- from op 2024-03-07 16:36:36 +01:00
installer Bug 36102: Fix removal of cookie from the installer session on upgrades 2024-03-01 11:00:36 +01:00
Koha Bug 31427: Remove a few refs to CanBookBeRenewed 2024-03-07 16:36:44 +01:00
koha-tmpl Bug 35924: (QA follow-up): Comment magic number (patron.privacy < 2) 2024-03-07 17:35:38 +01:00
labels Bug 34478: Update label ops 'edit' to 'edit_form' 2024-03-01 10:56:33 +01:00
lib/CGI/Session/Serialize
members Bug 36170: Wrong error variable in memberentry 2024-03-07 16:36:46 +01:00
misc Bug 31427: Remove a few refs to CanBookBeRenewed 2024-03-07 16:36:44 +01:00
offline_circ Bug 34478: Changes for offline_circ 2024-03-01 10:58:34 +01:00
opac Bug 35952: Remove unnecessary line for OpacSuppressionMessage 2024-03-07 15:02:50 +01:00
patron_lists Bug 34478: Changes for patron_lists/add-modify 2024-03-01 10:57:41 +01:00
patroncards Bug 34478: (follow-up) patroncards: FIXMEs for op and missing script 2024-03-01 11:00:00 +01:00
plugins Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
pos Bug 34478: Manual fix - add op - pos/pay 2024-03-01 10:57:34 +01:00
preservation
recalls Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
reports Bug 34478: Manual fix - change 'phase' to 'op' add cud- - mana-share-report 2024-03-01 10:59:08 +01:00
reserve Bug 34478: Manual fix - change links to JS form submission - change action to op - request.pl/.tt 2024-03-01 10:59:09 +01:00
reviews Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
rotating_collections Bug 34478: Manual fix - add op - rotating_collections/addItems 2024-03-01 10:57:33 +01:00
serials Bug 35329: Handle duplicate without 500 2024-03-01 11:01:26 +01:00
services
skel
suggestion Bug 34478: Changes for suggestion/suggestion 2024-03-01 10:59:26 +01:00
svc Bug 36084: svc - mana 2024-03-01 11:01:01 +01:00
t Bug 36056: Clarify subpermissions AND behavior 2024-03-07 17:35:40 +01:00
tags Bug 34478: Add 'op' to tags/review 2024-03-01 10:58:25 +01:00
tools Bug 34478: Correct op name in CSV profile deletion confirmation step 2024-03-01 11:00:07 +01:00
virtualshelves Bug 34478: Correct op name for list edit confirmation 2024-03-01 11:00:09 +01:00
xt Bug 34478: Add test to catch missing op in POST forms 2024-03-01 10:58:14 +01:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap 23.11.00: Update mailmap 2023-11-30 14:58:47 -03:00
.perlcriticrc
.perltidyrc
.proverc.dist
.stylelintrc.json
about.pl Bug 36134: Read complete Elasticsearch configuration in about.pl 2024-03-07 17:35:36 +01:00
app.psgi
build-resources.PL
changelanguage.pl
cpanfile
cypress.config.ts
fix-perl-path.PL
gulpfile.js Bug 35428: Remove temporary files for gulp po tasks 2023-12-12 15:04:54 +01:00
help.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
INSTALL
Koha.pm Bug 30230: DBRev 23.12.00.006 2024-01-29 12:25:11 +01:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 34478: Remove generate_csrf from pl 2024-03-01 10:55:56 +01:00
Makefile.PL Bug 35759: (bug 30708 follow-up) Generated dist file not installed for preservation module 2024-01-16 12:06:17 +01:00
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js
yarn.lock

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo