Main Koha release repository https://koha-community.org
Find a file
Alex Arnaud ac840a8460 Bug 19945: ILSDI - Return the reason a reserve is impossible
Currently, the ILDSI services HoldTitle and HoldItem always return a
"NotHoldable" code is the reserve is impossible. We need to know why

Test plan:

 - Apply this patch
 - Place a hold on a non reservable title using ILS-DI web service
   (http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=)
 - you should get the reason instead of NotHoldable,
 - Place a hold on a non reservable item using ILS-DI web service
   (http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1)
 - you should get the reason instead of NotHoldable,

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-01-28 13:06:27 +00:00
acqui Bug 21853: (follow-up) to solve printpdf error 2018-11-21 11:08:23 +00:00
admin Bug 17047: add a dedicated page for Mana setup 2019-01-23 14:39:26 +00:00
api/v1 Bug 21786: (QA follow-up) library_id can be null 2019-01-08 15:50:51 +00:00
authorities Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
basket Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
C4 Bug 19945: ILSDI - Return the reason a reserve is impossible 2019-01-28 13:06:27 +00:00
catalogue Bug 21170: Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail 2019-01-18 20:35:49 +00:00
cataloguing Bug 21986: Do not escape quotation marks when cataloguing 2018-12-14 13:33:28 +00:00
circ Bug 21877: Use AuthorisedValues.GetDescriptionByKohaField for notforloan in checkout 2019-01-28 11:23:14 +00:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 21501: Remove dead code from course reserves module 2018-11-02 10:37:45 +00:00
debian Bug 18909: Enable the maximum zebra records size to be specified per instance 2019-01-25 16:14:48 +00:00
docs Bug 7143: Fix typo in adding new dev 2019-01-18 20:12:08 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 17047: SQL reports management with Mana-KB 2019-01-23 14:39:26 +00:00
ill Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
installer Bug 21241: DBRev 18.12.00.009 2019-01-28 13:06:18 +00:00
Koha Bug 21478: Make Koha::Hold->suspend reject found holds 2019-01-28 11:35:51 +00:00
koha-tmpl Bug 21241: (follow-up) Syspref to control fallback to SMS when no email is defined 2019-01-28 11:42:31 +00:00
labels Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
members Bug 22066: Record library_id for manual credits 2019-01-28 13:06:26 +00:00
misc Bug 22049: Make MarkIssueReturned rely on returndate only 2019-01-25 20:46:47 +00:00
offline_circ Bug 22049: (QA follow-up) update MarkIssueReturned call in process_koc.pl 2019-01-25 20:46:48 +00:00
opac Bug 22048: Use set_password opac/opac-password-recovery.pl 2019-01-25 20:15:31 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 17047: add a dedicated page for Mana setup 2019-01-23 14:39:26 +00:00
reserve Bug 21608: Disable dropdown for found holds - add button to revert 2018-12-11 19:13:30 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 17047: add a dedicated page for Mana setup 2019-01-23 14:39:26 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-08 20:58:23 +00:00
svc Bug 17047: add a dedicated page for Mana setup 2019-01-23 14:39:26 +00:00
t Bug 19945: ILSDI - Return the reason a reserve is impossible 2019-01-28 13:06:27 +00:00
tags Bug 22036: Indented code where '^I' was written rather than an indent. 2019-01-17 02:23:28 +00:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
tools Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
virtualshelves Bug 21874: (QA follow-up) Fix intranet sendshelf 2018-11-26 12:38:56 +00:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Koha.pm Bug 21241: DBRev 18.12.00.009 2019-01-28 13:06:18 +00:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 17698: Do not send pending_checkout_notes from all circ scripts 2018-07-23 15:23:44 +00:00
Makefile.PL Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
MANIFEST.SKIP
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo