Main Koha release repository https://koha-community.org
Find a file
Owen Leonard afec0fb499
Bug 25294: Don't show deletion button if user can't delete suggestions
This patch adds logic to the OPAC suggestions template so that when the
OPACViewOthersSuggestions system preference is enabled and the logged-in
user is viewing other users' suggestions, the "Delete selected" button
is only displayed when there are suggestions the user can delete.

To test you should have suggestions in your system from at least two
users.

- Set the OPACViewOthersSuggestions preference to "Show"
- Log in to the OPAC as a user who hasn't submitted any suggestions
- Go to the suggestions page (with "?suggested_by_anyone=1" appended to
  the URL if necessary, see Bug 22515).
- In the table of suggetions, there should be no titles with a checkbox
  in the first column.
- At the bottom of the table there should be no "Delete selected"
  button.

- Log in to the OPAC as a user with suggestions.
- Return to the suggestions page and view all suggestions.
- There should be titles with corresponding checkboxes and the "Delete
  selected" button should appear at the bottom.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-04-29 17:16:14 +01:00
acqui Bug 25223: Make join of aqbasket and aqorders explicit 2020-04-22 09:29:13 +01:00
admin Bug 23137: Move cache flushing to the method 2020-04-29 17:02:15 +01:00
api/v1 Bug 24908: Add text-formatted MARC support in /biblios/{biblio_id} 2020-04-29 17:13:36 +01:00
authorities Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
basket
C4 Bug 22630: Allow to change homebranch in course reserves 2020-04-29 17:07:52 +01:00
catalogue Bug 23591: Hide archived suggestions 2020-04-14 16:36:41 +01:00
cataloguing Bug 25248: (bug 23463 follow-up) Item is returned if deletion successful, not 1 2020-04-27 10:56:52 +01:00
circ Bug 24298: (RM follow-up) Re-introduce TransferTrigger drop through 2020-04-27 14:24:31 +01:00
clubs Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
course_reserves Bug 22630: Allow to change homebranch in course reserves 2020-04-29 17:07:52 +01:00
debian Bug 25149: Fix Zebra language code for Greek 2020-04-29 17:14:30 +01:00
docs
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 25149: Fix Zebra language code for Greek 2020-04-29 17:14:30 +01:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 22630: DBRev 19.12.00.081 2020-04-29 17:12:13 +01:00
Koha Bug 24908: Add text-formatted MARC support in /biblios/{biblio_id} 2020-04-29 17:13:36 +01:00
koha-tmpl Bug 25294: Don't show deletion button if user can't delete suggestions 2020-04-29 17:16:14 +01:00
labels Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
members Bug 5161: Keep patron's attributes on warning/duplicate 2020-04-27 11:28:46 +01:00
misc Bug 23137: Move cache flushing to the method 2020-04-29 17:02:15 +01:00
offline_circ Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
opac Bug 25110: Allow patrons to add star ratings to titles on their summary/checkout page 2020-04-29 17:04:32 +01:00
patron_lists
patroncards Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
plugins Bug 20415: Remove UseKohaPlugins system preference 2020-03-26 11:42:02 +00:00
pos Bug 25139: Corrections to date picker handling 2020-04-15 08:33:07 +01:00
reports Bug 24940: Serials statistics wizard: order vendor list alphabetically 2020-04-08 11:46:21 +01:00
reserve Bug 16547: Do not display "multi holds" view if only one is selected 2020-04-06 10:41:02 +01:00
reviews
rotating_collections
serials Bug 25081: Fix wrong comment 2020-04-08 11:53:37 +01:00
services
skel
suggestion Bug 24819: (follow-up) Rename suggestor to suggester 2020-04-20 13:36:42 +01:00
svc Bug 4461: Fix status and borrowernumber fields in problem_reports and more 2020-04-06 11:18:59 +01:00
t Bug 24908: Unit tests 2020-04-29 17:13:30 +01:00
tags
tmp/modified_authorities
tools Bug 14369: Only show 'Create labels' link on staged records import when status is imported 2020-04-21 12:28:56 +01:00
virtualshelves Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
xt Bug 24897: (RM follow-up) Drop tests for es-ES notices 2020-04-28 06:55:56 +01:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json
.gitignore
.htaccess
.mailmap
.scss-lint.yml
about.pl Bug 25172: Identify and display possible problems on the about page 2020-04-22 13:44:12 +01:00
changelanguage.pl
cpanfile Bug 24573: Add missing dependencies to cpanfile 2020-03-06 09:58:54 +00:00
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 22630: DBRev 19.12.00.081 2020-04-29 17:12:13 +01:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl
LICENSE
mainpage.pl Bug 4461: Fix status and borrowernumber fields in problem_reports and more 2020-04-06 11:18:59 +01:00
Makefile.PL Bug 25149: Fix Zebra language code for Greek 2020-04-29 17:14:30 +01:00
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo