Koha/Koha
David Cook 87c14e07d6
Bug 24538: Handle Net::Netmask parser errors
This patch switches from the new() to new2() constructor,
which will return an undef value when it fails to parse a value.

This patch warns on parser failures, but otherwise silently drops
the invalid value, and returns objects for any valid input it can parse.
This way one mistake won't disable the whole feature.

To test:
1. Run the unit test t/Koha/Middlware/RealIP.t

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-02-20 08:40:52 +00:00
..
Account Bug 23442: (RM follow-up) Fix for missing 'uc' in offset_type call 2020-01-23 16:13:23 +00:00
Acquisition Bug 24462: Adapt mapping to voted RFC (Invoices) 2020-02-10 09:22:03 +00:00
ArticleRequest
Authority
Biblio Bug 23425: (QA follow-up) Keep it generic 2019-09-23 10:41:58 +01:00
BiblioUtils
Cache
Cash Bug 23321: Allow setting of branch default 2019-09-23 11:39:22 +01:00
Charges Bug 18936: More fixes 2020-02-04 09:56:26 +00:00
Checkouts Bug 14697: Introduce Koha::Checkouts::ReturnClaim(s) 2019-10-31 12:03:33 +00:00
Club Bug 14711: Change prototype for AddReserve - pass a hashref 2020-02-11 14:32:47 +00:00
Config
Edifact Bug 20254: Set correct member in working_directory 2019-08-20 15:03:59 +01:00
Exceptions Bug 14697: Introduce Koha::Checkouts::ReturnClaim(s) 2019-10-31 12:03:33 +00:00
Exporter
ExternalContent
Filter/MARC Bug 23793: Add an EmbedItems RecordProcessor filter for MARC::Record objects 2019-10-23 17:33:07 +01:00
Illrequest Bug 23712: Silence warns from Koha/Illrequest/Logger.pm 2019-10-21 09:43:17 +01:00
Indexer
Item
Library Bug 22284: New methods in Koha::Library::Groups and Koha::Library 2020-01-03 12:58:03 +00:00
List
MetadataRecord
Middleware Bug 24538: Handle Net::Netmask parser errors 2020-02-20 08:40:52 +00:00
Misc
Notice
Number
OAI/Server
Object
Objects Bug 23599: Avoid exploding in search_with_library_limits when no library is passed 2019-09-12 16:00:41 +01:00
Old Bug 24321: Clean /checkouts 2020-01-08 14:42:39 +00:00
Patron Bug 19809: Remove some new occurrences 2020-01-23 10:27:36 +00:00
Patrons Bug 24330: When importing patrons from CSV, automatically strip BOM from file if it exists 2020-01-30 15:52:20 +00:00
pdfformat Bug 5016: Fix some translation issues with English PDF order templates 2020-02-19 11:26:41 +00:00
Plugins Bug 24361: (bug 24217 follow-up) Fix several warnings in C4 modules 2020-01-07 13:59:51 +00:00
QueryParser/Driver Bug 24367: Resolve warn Negative repeat count does nothing 2020-02-19 11:22:19 +00:00
RecordProcessor
REST Bug 14711: Change prototype for AddReserve - pass a hashref 2020-02-11 14:32:47 +00:00
Schema/Result Bug 11297: Modify Z3950server schema file 2020-02-19 16:07:59 +00:00
SearchEngine Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Serial
Sitemapper
SMS
Subscription
SuggestionEngine
Tags
Template/Plugin Bug 24350: (follow-up) Clear Koha::Libraries->pickup_locations() and move logic to Koha::Template::Plugin::Branches->pickup_locations(). 2020-01-13 10:03:35 +00:00
Util Bug 23324: (QA follow-up) Typo and remove unneeded use statement 2019-08-16 12:27:01 +01:00
Z3950Responder Bug 13937: (follow-up) Fix searching with UTF-8 characters. 2019-10-23 15:01:44 +01:00
Account.pm Bug 24592: Reword LOST_RETURN to LOST_FOUND 2020-02-13 15:58:49 +00:00
ActionLog.pm
ActionLogs.pm
AdditionalField.pm
AdditionalFields.pm
AdditionalFieldValue.pm
AdditionalFieldValues.pm
ApiKey.pm
ApiKeys.pm
ArticleRequest.pm
ArticleRequests.pm
AudioAlert.pm
AudioAlerts.pm
AuthorisedValue.pm Bug 23272: Make Koha::AuthorisedValue use Koha::Object::Limit::Library 2019-09-13 08:04:05 +01:00
AuthorisedValueCategories.pm
AuthorisedValueCategory.pm
AuthorisedValues.pm
Authorities.pm
Authority.pm
AuthUtils.pm
Biblio.pm Bug 24554: Only embed relations from Koha::Biblio in to_api 2020-02-06 12:37:25 +00:00
BiblioFramework.pm
BiblioFrameworks.pm
Biblioitem.pm Bug 24366: Merge biblioitem in Koha::Biblio->to_api 2020-01-14 14:12:46 +00:00
Biblioitems.pm
Biblios.pm
BiblioUtils.pm
Cache.pm Bug 13193: Make Memcached usage fork safe 2020-02-07 09:58:47 +00:00
Caches.pm
Calendar.pm Bug 23974: Add POD for hours_between 2020-01-10 08:23:31 +00:00
Checkout.pm Bug 14697: Add Koha::Checkout->claim_returned 2019-10-31 12:03:56 +00:00
Checkouts.pm
CirculationRule.pm Bug 18936: (follow-up) Add cloning of circulation rules back to Koha 2020-02-04 09:56:29 +00:00
CirculationRules.pm Bug 24602: Make get_onshelfholds_policy fallback to 0 2020-02-10 08:56:39 +00:00
Cities.pm
City.pm Bug 23770: Add to_api_mapping method to Koha::City 2019-10-21 10:03:53 +01:00
ClassSortRule.pm
ClassSortRules.pm
ClassSource.pm
ClassSources.pm
ClassSplitRule.pm
ClassSplitRules.pm
Club.pm Bug 19809: Re-allow to call Koha::Objects::find in list context 2020-01-23 10:27:28 +00:00
Clubs.pm
Config.pm
CsvProfile.pm
CsvProfiles.pm
Database.pm
DateUtils.pm Bug 24643: Support fractional seconds 2020-02-13 15:56:34 +00:00
EDI.pm Bug 20595: Add handling for LRP field in EDI 2019-10-28 09:58:16 +00:00
Edifact.pm
Email.pm
Exceptions.pm Bug 24080: Add 'payout' method to Koha::Account::Line 2020-01-03 16:35:38 +00:00
ExternalContent.pm
FrameworkPlugin.pm
Hold.pm Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency 2019-10-24 17:24:30 +01:00
Holds.pm
I18N.pm
Illcomment.pm
Illcomments.pm
Illrequest.pm Bug 23712: (QA follow-up) Silence two other warns too 2019-10-21 09:43:24 +01:00
Illrequestattribute.pm
Illrequestattributes.pm
Illrequests.pm
Item.pm Bug 18936: Convert issuingrules fields to circulation_rules 2020-02-04 09:23:55 +00:00
Items.pm
ItemType.pm Bug 18936: Move guess_article_requestable_itemtypes method 2020-02-04 09:56:25 +00:00
ItemTypes.pm Bug 15497: (QA follow-up) Fix call in search_with_localization 2019-09-12 16:31:06 +01:00
KeyboardShortcut.pm
KeyboardShortcuts.pm
Libraries.pm Bug 24350: (follow-up) Clear Koha::Libraries->pickup_locations() and move logic to Koha::Template::Plugin::Branches->pickup_locations(). 2020-01-13 10:03:35 +00:00
Library.pm Bug 22284: New methods in Koha::Library::Groups and Koha::Library 2020-01-03 12:58:03 +00:00
Linktracker.pm
Localization.pm
Localizations.pm
Logger.pm Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields 2019-10-08 14:39:30 +01:00
Manual.pm Bug 11529: Remove field mapping table and admin page 2019-08-05 15:03:18 +01:00
MarcSubfieldStructure.pm
MarcSubfieldStructures.pm
MetadataIterator.pm
MetadataRecord.pm
MetaSearcher.pm Bug 24173: Advanced Editor: Show subtitle & published date on the search page 2020-01-03 16:21:29 +00:00
MoreUtils.pm
News.pm
NewsItem.pm
OAuth.pm
OAuthAccessToken.pm
OAuthAccessTokens.pm
Object.pm Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
Objects.pm Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
Patron.pm Bug 19809: Remove some new occurrences 2020-01-23 10:27:36 +00:00
Patrons.pm Bug 21684: Fix delete methods and add more tests 2020-01-03 10:58:47 +00:00
Plugins.pm
Rating.pm
Ratings.pm
RDF.pm
RecordProcessor.pm
RefundLostItemFeeRules.pm
Report.pm
Reports.pm
Review.pm
Reviews.pm
Schema.pm
Script.pm
SearchEngine.pm
SearchField.pm Bug 20589: Add field boosting and use query_string fields parameter 2019-10-02 13:28:57 +01:00
SearchFields.pm Bug 20589: Add field boosting and use query_string fields parameter 2019-10-02 13:28:57 +01:00
SearchMarcMap.pm
SearchMarcMaps.pm
Serial.pm
Serials.pm
SharedContent.pm Bug 23075: (follow-up) Dissallow transparent redirects 2019-11-06 17:05:10 +00:00
SimpleMARC.pm
Sitemapper.pm
Statistic.pm Bug 24149: Add Koha::Statistic->item 2020-01-23 10:40:24 +00:00
Statistics.pm Bug 24149: (QA follow-up) Add pod for Koha::Statistics->object_class 2020-01-23 10:40:24 +00:00
StockRotationItem.pm Bug 24296: Update stockrotation process to use branchtransfers.reason 2020-01-28 15:03:30 +00:00
StockRotationItems.pm
StockRotationRota.pm
StockRotationRotas.pm
StockRotationStage.pm
StockRotationStages.pm
Subscription.pm Bug 19809: Re-allow to call Koha::Objects::find in list context 2020-01-23 10:27:28 +00:00
Subscriptions.pm
Suggestion.pm Bug 24419: Add Koha::Suggestion->suggester accessor 2020-01-20 16:37:22 +00:00
SuggestionEngine.pm
Suggestions.pm
Tag.pm
Tags.pm
Token.pm
UploadedFile.pm Bug 21684: Fix UploadedFile[s]->delete 2020-01-07 16:32:53 +00:00
UploadedFiles.pm Bug 21684: Fix UploadedFile[s]->delete 2020-01-07 16:32:53 +00:00
Uploader.pm
Virtualshelf.pm
Virtualshelfcontent.pm
Virtualshelfcontents.pm
Virtualshelfshare.pm
Virtualshelfshares.pm
Virtualshelves.pm
XSLT_Handler.pm Bug 24313: Always display XSLT errors in logs 2020-01-10 08:29:15 +00:00
Z3950Responder.pm Bug 13937: (RM follow-up) Set working directory for daemon mode. 2019-10-15 13:48:28 +01:00
Z3950Server.pm
Z3950Servers.pm