Main Koha release repository https://koha-community.org
Find a file
Alex Buckley dfa883bbd0 Bug 21241: Conditional to choose appropriate message_transport_type for suggestion notices
Introducing a conditional into C4/Suggestions.pm to check if no patron
email exists but a smsalertnumber does exist then the suggestion notice
message_transport_type is set to 'sms', otherwise the suggestion
message_transport_type='email'.

This ensures patrons with no email address still receieve their
suggestion notices because at present the message_transport_type is
hardcoded to 'email'.

Test plan:
1. Chose a patron who has no email address set, but does have a
smsalertnumber set (this value is set in the Patron messaging
preferences section after the SMSSendDriver syspref is set)

2. Log into the OPAC with that user and submit a suggestion

3. In the staff client go to Acquisitions->Suggestions and tick the
suggestion and set its status to 'Accepted'

4. In the database query the message_queue and notice the
message_transport_type of the message is set to 'email' even though the
patron has no email address set.

5. Apply this patch, restart memcached and plack

6. Repeat steps 2,3 with the same patron and query the message_queue
table again and notice this time the message_transport_type = 'sms'

7. Repeat steps 2,3 with a patron with no smsalertnumber or email
address. Query the database and observe the
message_transport_type=email.

If no smsalertnumber is set then the message_transport_type is set to
'email' by default

Sponsored-By: Brimbank Library, Australia

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-01-28 11:42:31 +00:00
acqui Bug 21853: (follow-up) to solve printpdf error 2018-11-21 11:08:23 +00:00
admin Bug 17047: add a dedicated page for Mana setup 2019-01-23 14:39:26 +00:00
api/v1 Bug 21786: (QA follow-up) library_id can be null 2019-01-08 15:50:51 +00:00
authorities Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
basket Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
C4 Bug 21241: Conditional to choose appropriate message_transport_type for suggestion notices 2019-01-28 11:42:31 +00:00
catalogue Bug 21170: Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail 2019-01-18 20:35:49 +00:00
cataloguing Bug 21986: Do not escape quotation marks when cataloguing 2018-12-14 13:33:28 +00:00
circ Bug 21877: Use AuthorisedValues.GetDescriptionByKohaField for notforloan in checkout 2019-01-28 11:23:14 +00:00
clubs
course_reserves Bug 21501: Remove dead code from course reserves module 2018-11-02 10:37:45 +00:00
debian Bug 18909: Enable the maximum zebra records size to be specified per instance 2019-01-25 16:14:48 +00:00
docs Bug 7143: Fix typo in adding new dev 2019-01-18 20:12:08 +00:00
errors
etc Bug 17047: SQL reports management with Mana-KB 2019-01-23 14:39:26 +00:00
ill Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
installer Bug 22048: Use set_password in onboarding.pl 2019-01-25 20:15:28 +00:00
Koha Bug 21478: Make Koha::Hold->suspend reject found holds 2019-01-28 11:35:51 +00:00
koha-tmpl Bug 22207: course reserves page does not have unique <body> id 2019-01-28 11:41:11 +00:00
labels Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
members Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
misc Bug 22049: Make MarkIssueReturned rely on returndate only 2019-01-25 20:46:47 +00:00
offline_circ Bug 22049: (QA follow-up) update MarkIssueReturned call in process_koc.pl 2019-01-25 20:46:48 +00:00
opac Bug 22048: Use set_password opac/opac-password-recovery.pl 2019-01-25 20:15:31 +00:00
OpenILS
patron_lists
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins
reports Bug 17047: add a dedicated page for Mana setup 2019-01-23 14:39:26 +00:00
reserve Bug 21608: Disable dropdown for found holds - add button to revert 2018-12-11 19:13:30 +00:00
reviews
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 17047: add a dedicated page for Mana setup 2019-01-23 14:39:26 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel
suggestion
svc Bug 17047: add a dedicated page for Mana setup 2019-01-23 14:39:26 +00:00
t Bug 21478: Unit tests 2019-01-28 11:35:50 +00:00
tags Bug 22036: Indented code where '^I' was written rather than an indent. 2019-01-17 02:23:28 +00:00
test
tmp/modified_authorities
tools Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
virtualshelves Bug 21874: (QA follow-up) Fix intranet sendshelf 2018-11-26 12:38:56 +00:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig
.gitignore
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml
about.pl Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
install-CPAN.pl
Koha.pm Bug 17047: DBRev 18.12.00.008 2019-01-23 14:39:26 +00:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 17698: Do not send pending_checkout_notes from all circ scripts 2018-07-23 15:23:44 +00:00
Makefile.PL Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
package.json
README
README.md
README.robots
rewrite-config.PL
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo