Main Koha release repository https://koha-community.org
Find a file
Tomas Cohen Arazi e75c869785 Bug 21759: Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned
This patch changes the behaviour in the _FixAccountForLostAndFound
method.

The method will now add the amountoutstanding value for the lost item
fee to the CR credit to be generated. This means that:
- If there's some remaining debt, the same amount  will be added to the
  CR credit and used to cancel that debt. The final amountoutstanding
  will be the same as before, but an offset will be generated as
  required.
- If the line was written off, the behaviour remains unchanged, so no
  offset.
- If the line was payed and/or written off in full only the payments are
  refund, preserving the current behaviour.

To test:
- Apply the regression tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation.t
=> FAIL: Tests fail because the behaviour is not correct
- Apply this patch
- Run:
 k$ prove t/db_dependent/Circulation.t
=> SUCCESS: Tests now pass!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-12-11 20:35:08 +00:00
acqui Bug 21853: (follow-up) to solve printpdf error 2018-11-21 11:08:23 +00:00
admin Bug 19365: Index authority fields as phrases 2018-11-26 16:11:02 +00:00
api/v1 Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
authorities Bug 21405: Fix authorities pagination for Zebra and ES 2018-12-11 19:14:54 +00:00
basket Bug 21874: Fix encoding of cart and list email subjects 2018-11-26 12:38:56 +00:00
C4 Bug 21759: Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned 2018-12-11 20:35:08 +00:00
catalogue Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
cataloguing Bug 20435: Allow lowercase prefix in inventory value builder 2018-11-06 17:42:31 +00:00
circ Bug 21837: Don't set holdingbranch filter using selected homebranch filter 2018-11-21 11:24:02 +00:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 21501: Remove dead code from course reserves module 2018-11-02 10:37:45 +00:00
debian Bug 21897: Typo in postinst 2018-11-29 17:58:27 +00:00
docs Bug 7143: Update about page for Nazlı 2018-11-29 18:45:01 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 20078: (follow-up) Prevent conflict from attribute duplication 2018-11-06 12:22:53 +00:00
ill Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
installer Bug 21961: DBRev 18.12.00.001 2018-12-11 20:31:19 +00:00
Koha Bug 21465: Don't throw duplicate userid error if userid belongs to the matched patron 2018-12-11 20:32:24 +00:00
koha-tmpl Bug 21608: (QA follow-up) Rename revert button 2018-12-11 19:13:32 +00:00
labels Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
members Bug 18805: Add ability to use up account credits 2018-11-29 18:47:15 +00:00
misc Bug 21908: (QA follow-up) Remove useless parentheses in query 2018-12-11 19:19:47 +00:00
offline_circ Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl 2018-09-14 17:27:29 +00:00
opac Bug 21874: Fix encoding of cart and list email subjects 2018-11-26 12:38:56 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
reserve Bug 21608: Disable dropdown for found holds - add button to revert 2018-12-11 19:13:30 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 21467: Display a summary line per parent_ordernumber 2018-11-13 19:31:11 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-08 20:58:23 +00:00
svc Bug 15836: Remove debug statement 2018-11-13 15:18:24 +00:00
t Bug 21759: Regression tests 2018-12-11 20:35:08 +00:00
tags Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools Bug 21854: Use template plugin to display category description 2018-11-21 11:24:16 +00:00
virtualshelves Bug 21874: (QA follow-up) Fix intranet sendshelf 2018-11-26 12:38:56 +00:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Koha.pm Bug 21961: DBRev 18.12.00.001 2018-12-11 20:31:19 +00:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 17698: Do not send pending_checkout_notes from all circ scripts 2018-07-23 15:23:44 +00:00
Makefile.PL Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo