Main Koha release repository https://koha-community.org
Find a file
Jonathan Druart eed14b080d Bug 13001: Refactor VAT and price calculation - parcel page
Bug 12969 introduces a subroutine to centralize VAT and prices
calculation.
It should be use in the acqui/parcel.pl script.

Test plan:
1/ Create 4 suppliers with the different configurations
2/ Create a basket and create several orders
3/ Go on the parcel page
4/ You should see, on the "pending orders" table, the same prices as
before this patch.
Note that the prices are now correctly formated.

You could see one change for the supplier configuration 3 (1 0):
If the cost of the item is 82, discount 10% and vat 5%:
The "Order cost" = 140.58 instead of 140.57.
Indeed, before this patch, the order cost was wrong, now you should have
70.29*2 = 140.58

( before: 140.58 + 7.03 = 147.61
  now:    140.58 + 7.02 = 147.60 )

5/ Receive the items and return on the parcel page
Now the "Already received" table with the same prices as before this
patch.
Note some differences too:
- There was a td tag missing, the table was badly formated, it's now
fixed (column below the "Cancel receipt" link).
- The prices are now correctly formated.
- For the configuration 2 (1 1), if the cost of the item is 82, discount
  10% and vat 5%:

( before: 140.57 + 7.03 = 147.60
  now:    140.58 + 7.02 = 147.60 )

Note that 7.03 is the "correct" value, but on all other pages, 7.02 is
displayed.
To be consistent, we should display the same prices everywhere.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2015-01-21 11:25:59 -03:00
acqui Bug 13001: Refactor VAT and price calculation - parcel page 2015-01-21 11:25:59 -03:00
admin Revert "Bug 12279: Diacritics in system preference editor broken" 2015-01-13 13:07:37 -03:00
authorities Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
basket Bug 11944: Fix encoding on sending emails 2015-01-13 13:07:24 -03:00
C4 Bug 10606: Remove MySQLism in GetUpcomingDueIssues 2015-01-21 11:06:24 -03:00
catalogue Bug 11944: decode uri_unescape data 2015-01-13 13:07:43 -03:00
cataloguing Bug 13204: Plugin housekeeping: Remove labs_theses.pl plugin 2015-01-14 21:26:42 -03:00
circ Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
course_reserves Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
debian Bug 11927 - Add gr install option 2015-01-21 10:58:58 -03:00
docs Bug 7143: Adding releases to history file 2015-01-21 11:04:09 -03:00
errors Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
etc Bug 11927 - Small corrections on word-phrase-utf.chr 2015-01-21 10:59:17 -03:00
install_misc GRS-1 deprecation leftover used by jenkins 2015-01-13 15:30:31 -03:00
installer Bug 13577: Add the utf8_unicode_ci COLLATE to all tables 2015-01-17 10:28:44 -03:00
Koha Bug 12973: Allow passing code to XSLT_Handler instead of filename 2015-01-18 10:29:10 -03:00
koha-tmpl Bug 13001: Refactor VAT and price calculation - parcel page 2015-01-21 11:25:59 -03:00
labels Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
members Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly 2015-01-21 11:23:42 -03:00
misc Bug 13530: Typo in bulkmarcimport 2015-01-14 10:28:30 -03:00
offline_circ Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac Bug 13526 - Mandatory fields should not be able to be hidden in borrower self-registration 2015-01-18 10:45:10 -03:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patron_lists Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
patroncards Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
plugins Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
reports Bug 11944: Remove bad FIXME in guided_report 2015-01-13 13:07:31 -03:00
reserve Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
reviews Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
rotating_collections Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
services Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
suggestion Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
svc Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
t Bug 12973: (QA followup) warnings are features, test them 2015-01-18 10:29:19 -03:00
tags Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
test Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
virtualshelves Bug 11944: Fix encoding on sending emails 2015-01-13 13:07:24 -03:00
xt Bug 13199: follow up to fix Licence and some koha-qa errors 2014-11-20 09:47:54 -03:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Bug 13314: Follow-up for m.de.rooy in .mailmap 2014-11-26 11:16:18 -03:00
about.pl Bug 13579: Open history.txt using utf-8 encoding 2015-01-14 12:24:48 -03:00
changelanguage.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
edithelp.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
fix-perl-path.PL installer: improvements to fix-path-perl.PL on Win32 2007-12-20 19:20:12 -06:00
help.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.opensuse Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl Bug 11944: DBRev 3.19.00.006 2015-01-13 13:13:02 -03:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
Makefile.PL Bug 11927 - Add gr install option 2015-01-21 10:58:58 -03:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 12031: [QA Follow-up] Undefined routine and change to koha-conf.xml 2014-10-27 10:38:11 -03:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/