Main Koha release repository https://koha-community.org
Find a file
Yohann Dufour efee30f394 Bug 12623: SQLHelper replacement - Borrower::Modifications
With this patch, the subroutines AddModification and ApproveModifications uses DBIx::Class instead of C4::SQLHelper.
Moreover, the tests has been wrapped in a transaction.

Test plan:
1) Apply the patch

2) Execute the unit tests by launching :
prove t/db_dependent/Koha_borrower_modifications.t

3) The result has to be a success without error or warning :
t/db_dependent/Koha_borrower_modifications.t .. ok
All tests successful.
Files=1, Tests=14,  2 wallclock secs ( 0.03 usr  0.01 sys +  1.60 cusr  0.08 csys =  1.72 CPU)
Result: PASS

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2014-08-11 11:42:58 -03:00
acqui Bug 12619 - Shipment date gets lost on finishing and/or editing the invoice 2014-08-05 20:40:51 -03:00
admin Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl 2014-07-30 10:45:46 -03:00
authorities Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
basket Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
C4 Bug 12738: C4::Context should set 'keyword' as the default search class 2014-08-11 10:06:07 -03:00
catalogue Bug 12675: Remove CGI::scrolling_list from labeledMARCdetail.pl 2014-08-03 16:53:00 -03:00
cataloguing Bug 11349: (qa follow-up) Fix pod 2014-07-17 11:06:15 -03:00
circ Bug 12523 - Add patron email in Holds awaiting pickup circulation rapport 2014-08-07 16:18:23 -03:00
course_reserves Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
debian Bug 8773 - Start per-instance koha-index-daemon in .deb setup 2014-07-14 09:15:22 -03:00
docs Bug 7143: Updating new developers 2014-06-30 10:01:52 -03:00
errors Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
etc Bug 9612: (follow-up) restore elementSetName in Context.pm 2014-05-19 16:46:57 +00:00
install_misc Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
installer Bug 4045: DBRev 3.17.00.013 2014-08-07 11:58:19 -03:00
Koha Bug 12623: SQLHelper replacement - Borrower::Modifications 2014-08-11 11:42:58 -03:00
koha-tmpl Bug 12700 - Capitalization: "Close Help Window" in context help 2014-08-11 11:40:24 -03:00
labels Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
members Bug 7237 - duplicating patron not using patron's branch 2014-07-30 14:17:00 -03:00
misc Bug 9000: Followup to fix tabs & closing TT directive 2014-07-29 16:25:56 -03:00
offline_circ Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
opac Bug 10542: QueryParser + OpacSuppression doesn't allow search in 'all libraries' 2014-08-11 11:39:24 -03:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patron_lists Bug 10565: (follow-up) add new user permission for patron list management 2013-10-14 22:43:03 +00:00
patroncards Bug 5502 - Patron card category search field should be menu 2014-08-10 09:30:47 -03:00
plugins Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
reports Bug 12622: Fix export report as ods 2014-07-29 11:29:16 -03:00
reserve Bug 4045 - No check for maximum number of allowed holds. 2014-08-07 11:47:08 -03:00
reviews Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
rotating_collections Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
selenium
serials Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
services Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
suggestion Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
svc Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled 2014-07-30 14:29:29 -03:00
t Bug 12623: SQLHelper replacement - Borrower::Modifications 2014-08-11 11:42:58 -03:00
tags Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
test Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
tmp/modified_authorities
tools Bug 11331 - CSV export for viewlog.pl is missing newlines - followup 2014-08-05 20:26:02 -03:00
virtualshelves Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
xt Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Bug 12479: (QA followup) minor fixes, and tcohen added 2014-06-30 10:04:10 -03:00
about.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl Bug 11661: sanitize file names supplied to edithelp.pl 2014-02-05 01:36:10 +00:00
fix-perl-path.PL
help.pl Bug 11238: contruct links to the appropriate manual version dynamically 2013-11-23 19:30:16 +00:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.opensuse Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl Bug 4045: DBRev 3.17.00.013 2014-08-07 11:58:19 -03:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
Makefile.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/