Main Koha release repository https://koha-community.org
Find a file
Thomas Klausner f1e29b18ea
Bug 30195: Search by ISBN if it is provided in suggestion
When a patron enters an ISBN/ISSN when suggesting a new purchase, the
ISBN is used to find duplicates. Title/Author are ignored (as patrons
might misspell them, and the ISBN provides a better way to find
duplicates)

Test Plan:
* in the OPAC, go to /cgi-bin/koha/opac-suggestions.pl
* Click "new purchase suggestion"
* Enter any title
* Enter an ISBN that exists in your library
* Click "Submit your suggestion"
-> A new purchase suggestion has been submitted

* Apply the patch!

* Again start a new purchase suggestion, enter any title and the
  duplicate ISBN, and Submit
* You should see the note "A similar document already exists: ..."

Please note that the title should not be required when entering an ISBN,
but as the list of required fields is managed via OPACSuggestionMandatoryFields
I fear that it's rather complicated to make title an optional required
field if isbn is provided.

I also added a simple non-DB test case to t/db_dependent/Suggestions.t
(in a subtest at the end), but could not actually run it as I haven't
gotten around to set up / try a testing Koha dev env...

Sponsored-by: Steiermärkische Landesbibliothek
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-06-25 11:20:37 -03:00
acqui Bug 29607: Store the discount amount correctly when importing and order from a file 2022-06-06 14:28:51 -03:00
admin Bug 12446: (QA follow-up) Rename canbeguarantee => can_be_guarantee 2022-06-23 13:34:05 -03:00
api Bug 21978: Add middle_name to api specification 2022-06-24 12:24:10 -03:00
authorities Bug 29260: 210a is reported to Autor (meeting/conference) when upgrading an authority through Z3950 2022-06-06 13:48:13 -03:00
basket Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes 2022-06-06 14:26:51 -03:00
bin
C4 Bug 30195: Search by ISBN if it is provided in suggestion 2022-06-25 11:20:37 -03:00
catalogue Bug 21978: (follow-up) Stop passing holdfor_cardnumber 2022-06-24 12:29:14 -03:00
cataloguing Bug 29963: Do not prefill empty date fields with today's date 2022-06-17 10:35:35 -03:00
circ Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip 2022-06-25 10:56:50 -03:00
clubs Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
course_reserves Bug 30409: barcodedecode() should always trim barcode 2022-06-14 07:54:58 -03:00
debian Bug 30511: Don't lock up entire database while running koha-dump 2022-05-10 23:09:09 -10:00
docs Bug 30808: Add the 22.05 release team. 2022-05-25 23:56:12 -10:00
errors Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI 2022-04-20 09:03:39 -10:00
etc Bug 29936: Add holds_get_captured option to sip config 2022-05-05 11:17:37 -10:00
ill Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
installer Bug 29129: DBRev 22.06.00.007 2022-06-25 11:16:23 -03:00
Koha Bug 21978: Schema Update 2022-06-24 12:30:29 -03:00
koha-tmpl Bug 29129: Compiled CSS 2022-06-25 10:59:28 -03:00
labels Bug 30813: Update TransformMarcToKoha to accept a hashref 2022-06-08 11:40:29 -03:00
lib/CGI/Session/Serialize
members Bug 12446: (QA follow-up) Rename canbeguarantee => can_be_guarantee 2022-06-23 13:34:05 -03:00
misc Bug 29325: (QA follow-up) Tidy up 2022-06-24 11:36:19 -03:00
offline_circ Bug 30525: Items batch modification broken 2022-04-21 13:41:36 -10:00
opac Bug 30844: Ensure that allow_nonref is enabled when using older versions of JSON 2022-06-09 09:37:43 -03:00
patron_lists
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins Bug 29787: Add plugin version to plugin search results 2022-04-08 15:49:15 +02:00
pos Bug 28481: (RM follow-up) formatting 2021-12-16 12:13:51 -10:00
recalls Bug 30924: Add missing branchtransfers.reason value for recall cancellation 2022-06-13 10:30:51 -03:00
reports Bug 30551: Make cash register report take branchcode from cash register 2022-05-06 10:33:10 -10:00
reserve Bug 30960: Fix JS error message when no pick-up location is selected when placing a hold 2022-06-20 10:44:04 -03:00
reviews
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials Bug 30813: Update TransformMarcToKoha to accept a hashref 2022-06-08 11:40:29 -03:00
services
skel
suggestion Bug 30195: Search by ISBN if it is provided in suggestion 2022-06-25 11:20:37 -03:00
svc Bug 30971: (follow-up) Fix one more occurence 2022-06-16 09:40:57 -03:00
t Bug 30195: Search by ISBN if it is provided in suggestion 2022-06-25 11:20:37 -03:00
tags Bug 29469: (bug 17600 follow-up) Fix tag approval/rejection from staff 2021-11-16 15:49:22 +01:00
tmp/modified_authorities
tools Bug 22659: (follow-up) Add category to redirect 2022-06-25 10:52:35 -03:00
virtualshelves Bug 26346: Add option to make public lists editable by all staff 2022-04-12 17:13:02 +02:00
xt Bug 27619: (QA follow-up) Remove xt/sample_notices.t 2022-05-11 11:28:48 +01:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap 22.05.00: Update mailmap 2022-05-25 23:56:12 -10:00
.perlcriticrc
.proverc.dist
.scss-lint.yml
about.pl Bug 28998: (follow-up) Add warning on about for missing key 2022-05-04 05:18:31 -10:00
app.psgi
changelanguage.pl
cpanfile Bug 25669: (follow-up) Minor fixes 2022-06-23 11:30:44 -03:00
fix-perl-path.PL
gulpfile.js Bug 30373: Enable translation of UNIMARC frameworks 2022-04-21 13:41:35 -10:00
help.pl
INSTALL
Koha.pm Bug 29129: DBRev 22.06.00.007 2022-06-25 11:16:23 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 19532: Database and installer stuff 2022-03-14 22:45:50 -10:00
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo