Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Martin Renvoize	138212f856	Bug 26618: (QA follow-up) Fix unit test for TranferCollection change We update TransferCollection to use the settled upon standard for passing error messages back from a method. This patch updates the corresponding unit test. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	3 years ago
Martin Renvoize	87c3911bb8	Bug 26618: Remove use of transferbook in RotatingCollections This patch replaces the use of C4::Circulation::transferbook in C4::RotatingCollections with calls to Koha::Item->request_transfer and adds handling for the various failure cases which that can throw. We also introduce additional feedback for the end user where it did not exist before. Now we notify the user if some of the collection could not be transfers or if transfers were queued rather than set to request immediately. Test plan 1/ Set up a rotating collection 2/ Transfer the collection 3/ Confirm the action succeeds 4/ Set up some branch transfer limits that will affect items in your collection 5/ Transfer the collection 6/ Note that the transfer succeeds but some items are returned as failures Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	3 years ago
Julian Maurice	96cc447045	Bug 25898: Prohibit indirect object notation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	638786e719	Bug 24663: Remove authnotrequired if set to 0 It defaults to 0 in get_template_and_user Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Tomás Cohen Arazi	40803d3035	Bug 21500: Remove warnings in rotating collections To test: - Go to Tools > Rotating collections => FAIL: Some warinings on the logs - Apply this patch - Reload page => SUCCESS: No warinings - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Jonathan Druart	2b1b168ec4	Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls C4::Items::GetItemnumberFromBarcode calls can be replaced with Koha::Items->find({ barcode => $barcode }); We should make sure the barcode existed in DB and so that ->find returns an object. Note that most of the time we just wanted to know if the barcode existed. The changes are very simple, the only one that need attention is the one in batchMod.pl. It is basically reusing what we did on bug 21141. Test plan: Use the batch item modification/deletion tools to modify/delete items from their barcode (using the textarea or a file) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Jonathan Druart	df97814f30	Bug 15758: Koha::Libraries - Remove GetBranches Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	1ef0b3c471	Bug 15066: Make transfer rotating collection works under Plack This patch the 2 following errors: Undefined subroutine &C4::RotatingCollections::transferbook called at C4/RotatingCollections.pm line 451. Undefined subroutine &C4::RotatingCollections::GetTransfers called at C4/RotatingCollections.pm line 450. And this warning: "my" variable $colId masks earlier declaration in same scope at /home/koha/src/rotating_collections/transferCollection.pl line 75. Test plan: Create a rotating collection Transfer it to another branch It should work with this patch Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Jonathan Druart	ba0f84b46c	Bug 9978: (followup) Replace license header with the correct license (GPLv3+) There was another form of the v2. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	e20270fec4	Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Kyle Hall	45eb7e6d4f	Bug 8836 [QA Followup] - Sort transfer branches alphabetically Signed-off-by: Owen Leonard <oleonard@myacpl.org> Libraries sort correctly now. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>	10 years ago
Owen Leonard	bb505d77f4	Bug 8836 [Template follow-up] Resurrect Rotating Collections This follow-up makes drastic changes to the templates in order to bring them into compliance with established patterns and markup guidelines. Only minor changes are made to perl scripts. Changes: - Add a toolbar include for displaying new, edit, transfer, and delete buttons. - Improve title and breadcrumbs with collection titles and better specificity. - Correct page structure which was inconsistent with the markup of similarly-structured pages. - Correct styling of error and informational messages. - Added detailed error messages for a couple of conditions which were not defined in the template. - Add link to the detail page of titles which are in a collection using the view defined in the IntranetBiblioDefaultView preference. - Add a link to remove an item from a collection directly without having to scan the barcode. - Add client-side validation to collection creation form. - In RotatingCollections.pm, add biblionumber to the list of columns returned by GetItemsInCollection. - In rotating_collections/*.pl, remove obsolete declaration of system preference variables. To test, perform all the operations associated with Rotating Collections: - Add a new collection - Edit an existing collection - Add items to a collection - Remove items from a collection (via barcode and link) - Test the behavior of all new toolbar buttons - Verify that titles and breadcrumbs look correct and links work correctly. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>	10 years ago
Kyle Hall	c4d3f57279	Bug 8836 [QA Followup 2] Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>	10 years ago
Kyle Hall	4aa0e21f86	Bug 8836 [QA Followup] - Fix koha-qa.pl errors reported Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Trusting the sign off on the other page, I only tested the QA changes Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>	10 years ago
Kyle Hall	d14a0cf5be	Bug 8836 - Resurrect Rotating Collections Test Plan: In "Tools" -> "Rotating Collections" -> "Add/Remove items": When adding item barcodes to the collection, the input field <input type="text" id="barcode" name="barcode"> should become active automatically so it is easy to add multiple barcodes rapidly without touching the mouse or keyboard. Enter-press is dealt by the barcode reader so automatic form submittal should be handled by the barcode reader. In "Rotating collections" -> "Transfer Collection": When the collection is initially transferred, items are set to trasfer correctly. When the collection is transferred while items are still being transferred, the transfer destination library doesn't change from the original one. The holding library changes for all items in the collection to the destination library on retransfers as well. This is tricky if a user accidentally places the wrong destination. When I try to checkin these items to their new retransfer location, I get the following messages: -"This item is part of a rotating collection and needs to be transferred to <original transfer destination>" -"Please return Valkoinen ihmissyj / to <original transfer destination>" -"Print slip or Cancel transfer" When I checkin a Item to a arbitrary branch, I get the following messages: "This item is part of a rotating collection and needs to be transferred to <retransfer destination>" "Please return Valkoinen ihmissyj / to <original trasfer destination>" Bug 8836 - Resurrect Rotating Collections - QA Followup Bug 8836 - Resurrect Rotating Collections - Followup 2 - Perltidy rotating collections scripts Bug 8836 - Resurrect Rotating Collections - Followup 3 * Fix bad TT Tag * Fix bad sql query * Fix capitalization ( HTML4 ) * Allow a rotating collection's location to keep AutomaticItemReturn from sending it back to the branch of origin * Fix bad query Bug 8836 - Resurrect Rotating Collections - Followup 4 - Autofocus on barcode field Bug 8836 - Resurrect Rotating Collections - Followup 5 - Don't transfer issued and waiting items Items in a rotating collection are automatcially transferred when a collection is transferred. This is a problem for currently checked out items and items on hold marked as "Waiting". This patch resolves this issue by skipping the transfer for those items. When the items are then returned, the librarian will be alerted to transfer the item to the library currently holding that rotating collection. Bug 8836 - Resurrect Rotating Collections - Followup 5 - Link collections.colBranchcode to branches.branchcode Signed-off-by: jmbroust <jean-manuel.broust@univ-lyon2.fr> Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org> http://bugs.koha-community.org/show_bug.cgi?id=8835 Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>	10 years ago
Tomás Cohen Arazi	afd2418d73	Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Fridolyn SOMERS	76c3649db3	Bug 9605: rotating collections permissions are wrong In tools / rotating collections, permissions are 'parameters => 1'. But there is a dedicated permission : tools => rotating_collections. Test plan : - Disable tools/rotating_collections permission to your connected user - Check you dont have access to those pages : rotating_collections/addItems.pl rotating_collections/editCollections.pl rotating_collections/rotatingCollections.pl rotating_collections/transferCollection.pl - Enable tools/rotating_collections permission to your connected user - Check you have access to above pages Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes wrong permission on rotating collection related pages. This will allow to block access to those. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Chris Cormack	70d86d4fe0	Bug 6553 : Follow up adding license statements http://bugs.koha-community.org/show_bug.cgi?id=6653 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Patch only adds license text.	13 years ago
Chris Cormack	aa51c89d57	Bug 6553 : Fixing authentication issue, there is no reason we should be able to use these without authentication http://bugs.koha-community.org/show_bug.cgi?id=6653 Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>	13 years ago
Donovan Jones	e5bb64c1c1	Bug 2505 - Add commented use warnings where missing in the rotating_collections/ directory	14 years ago
Frédéric Demians	f650aad34b	Rotating Collections This feature is designed to manage collections of items that move from library to library periodically. Koha can already track who has and item, and who owns and item, but not who should have an item. That is the issue this feature addresses. It allows a persion to create a collection, and add any number of items to that collection. The collection can then be transferred from library to library. If an item shows up at a library that does not currently 'hold' that collection, Koha will ask you to transfer it to the library that does currently 'hold it. In that way, one can even transfer collections where some of the items are currently checked out. As soon as they make it back to a library, they will get transferred to the current library holding that collection. The feature consists of 4 main pages. 'Home' Page: The landing page, lists collections and provides access to the rest of the tools. Access is via the Tools page. Edit Collections: Add/Delete new rotating collections Add/Remove Items: Add/Remove items from a given collection Transfer Collection: Set the current 'holder' of a given collection. Librarian access is controlled by 'CAN_user_tools_rotating_collections'	15 years ago

21 Commits (12b6d1f79201f7d0702199afb841dc3ed24ff94b)