Koha/Koha
Martin Renvoize 693a0449d0 Bug 24434: Reinstate updateWrongTransfer
This patch re-instates the call to updateWrongTransfer to ensure the
transfer line is updated to reflect the new frombranch.

Test plan
note: when applying the patches, also update the database

1/ Check an item out from it's home library
2/ Check the item in at another library
   (with AutomaticItemReturn system preferences enabled)
2a/ Accept the transfer and note we now have a transfer present from the
    items check-in library to it's home library
3/ Check the item in at a third library
3a/ Note you are asked to return the item to it's home library.
3b/ With the patch applied, the modal title should highlight that a
    'Wrong transfer' was detected.
4/ Go to the item record and note the holding library has been updated
   to reflect where the item was most recently checked in.
4a/ With the patch applied the item status should reflect the last
    checked in branch as the 'from' branch of the transfer.
5/ check-in from a 4th library, but use the 'Print slip' option for
   accepting the transfer and confirm that also works.
6/ check-in from a 5th library, but use the 'Cancel' option and check
   that this results in the item staying at it's current location and the
   final transfer having been cancelled.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-06-18 10:37:17 -04:00
..
Account Bug 28482: Refresh line from DB to get stored value 2021-06-18 06:33:27 -04:00
Acquisition Bug 23971: Rename pref with AcquisitionLog 2021-04-23 11:58:49 +02:00
App Bug 20582: Reset CGI::PARAM_UTF8 to 1 before each CGI request 2020-10-06 14:34:17 +02:00
ArticleRequest Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Authority Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
BackgroundJob Bug 22417: Remove $dbh in Koha::BackgroundJob::* 2020-10-05 15:23:08 +02:00
Biblio Bug 26171: Show biblionumber in Koha::Exceptions::Metadata::Invalid 2021-01-04 13:29:50 +01:00
BiblioUtils Bug 24827: Specify UTF-8 as encoding in new_from_xml() 2020-03-16 14:45:47 +00:00
Cache Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Cash Bug 26274: (QA follow-up) Fix the order of summary groups 2021-02-17 16:21:22 +01:00
Charges Bug 23830: Adapt callers 2021-02-08 17:09:34 +01:00
Checkouts Bug 27004: Prevent claim resolution to fail 2021-01-04 13:29:47 +01:00
Club Bug 28272: Fix many things... 2021-05-11 09:04:13 +02:00
Config Bug 27154: Remove Koha::Util::SystemPreferences 2021-02-08 14:56:00 +01:00
Course Bug 23727: Editing course reserve items is broken 2020-04-17 13:45:56 +01:00
Edifact Bug 27793: Store FTX free text in vendor note 2021-05-07 14:44:00 +02:00
Exceptions Bug 26312: (follow-up) Fix passing of exception messages 2021-04-16 11:48:31 +02:00
Exporter
ExternalContent Bug 25527: Add logger to Koha::ExternalContent 2020-05-18 15:25:03 +01:00
Filter/MARC Bug 23583: Handle OpacHiddenItems with yaml_preference 2021-04-21 15:25:07 +02:00
Illrequest Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
Indexer Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Item Bug 24434: Reinstate updateWrongTransfer 2021-06-18 10:37:17 -04:00
Library Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
List
MetadataRecord Bug 28268: Improve memory usage when indexing authorities in Elasticsearch 2021-05-17 12:34:33 +02:00
Middleware Bug 25950: Remove <client> in X-Forwarded-For from proxy tests 2020-07-20 12:37:29 +02:00
Misc
Notice Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Number Bug 26239: Do not format large negative numbers 2020-08-19 08:22:02 +02:00
OAI/Server Bug 27584: Refactor OAI-PMH paging to improve performance 2021-05-07 14:44:00 +02:00
Object Bug 26555: (QA follow-up) Add a 'payload' attribute for carrying useful things 2020-10-15 14:50:06 +02:00
Objects Bug 23271: Prevent crash if called without parameters 2021-04-21 15:25:07 +02:00
Old Bug 28272: Fix note_seen, desk_id, cancellation_reason 2021-05-10 17:55:30 +02:00
Patron Bug 28220: Add more tests 2021-05-17 12:29:23 +02:00
Patrons Bug 28220: UI changes 2021-05-17 12:29:24 +02:00
pdfformat Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Plugins Bug 26803: Fix PLUGIN_DIR when plugin_dirs is multivalued 2020-11-04 12:59:33 +01:00
RecordProcessor
REST Bug 27931: Add GET /items/:item_id/pickup_locations 2021-06-18 08:44:45 -04:00
Schema Bug 28490: Add DBIx schema changes for testing 2021-06-18 07:47:34 -04:00
SearchEngine Bug 27724: Use lenient also in Elasticsearch authorities search 2021-05-19 14:52:19 +02:00
Serial Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Sitemapper Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
SMS Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SMTP Bug 26595: Remove password from the smtp_server API object 2020-10-14 15:53:38 +02:00
Subscription Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SuggestionEngine Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Tags Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Template/Plugin Bug 24154: (follow-up) Make parameter and variable more explicit, add tests 2021-05-10 10:27:53 +02:00
Util Bug 22569: Add a 'Transfers to send' report 2021-03-11 11:51:40 +01:00
XSLT Bug 23290: (RM follow-up) Correction to copyright statement 2020-02-25 14:35:39 +00:00
Z3950Responder Bug 27673: Replace YAML with YAML::XS 2021-02-16 14:54:50 +01:00
Account.pm Bug 27636: (QA follow-up) Restore force AutoReconcile 2021-04-30 17:07:31 +02:00
ActionLog.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ActionLogs.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AdditionalField.pm
AdditionalFields.pm
AdditionalFieldValue.pm
AdditionalFieldValues.pm
AdvancedEditorMacro.pm Bug 17268: (follow-up) Fix translatability 2020-05-04 08:26:22 +01:00
AdvancedEditorMacros.pm Bug 17268: (follow-up) Fix translatability 2020-05-04 08:26:22 +01:00
ApiKey.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ApiKeys.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ArticleRequest.pm Bug 23384: Fix use statement order for ArticleRequest::Status 2020-03-06 15:00:25 +00:00
ArticleRequests.pm Bug 23384: Fix use statement order for ArticleRequest::Status 2020-03-06 15:00:25 +00:00
AudioAlert.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AudioAlerts.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AuthorisedValue.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AuthorisedValueCategories.pm Bug 17355: (QA follow-up) Fix used package name 2020-05-07 19:10:29 -03:00
AuthorisedValueCategory.pm Bug 17355: (QA follow-up) Fix used package name 2020-05-07 19:10:29 -03:00
AuthorisedValues.pm Bug 23830: Make Koha::AuthorisedValues use Koha::Objects::Limit::Library 2021-02-08 17:09:34 +01:00
Authorities.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Authority.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AuthUtils.pm Bug 23816: (follow-up) Fix many things 2020-09-09 15:39:52 +02:00
BackgroundJob.pm Bug 26742: Remove die from connect 2021-03-05 12:27:22 +01:00
BackgroundJobs.pm Bug 22417: Add missing POD and html filters 2020-10-05 15:23:08 +02:00
Biblio.pm Bug 18989: (QA follow-up) Make Koha::Biblio->hidden_in_opac aware of OpacHiddenItemsHidesRecord 2021-05-12 14:12:07 +02:00
BiblioFramework.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
BiblioFrameworks.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Biblioitem.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Biblioitems.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Biblios.pm Bug 28273: Add Koha::Biblios->pickup_locations 2021-05-20 08:43:34 +02:00
BiblioUtils.pm Bug 26180: Add descending option to rebuild_elasticsearch.pl 2020-11-04 12:59:33 +01:00
Cache.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
Caches.pm
Calendar.pm Bug 25802: Change addDate to addDuration 2021-01-22 14:59:27 +01:00
Checkout.pm Bug 28272: Fix note_seen, desk_id, cancellation_reason 2021-05-10 17:55:30 +02:00
Checkouts.pm Bug 23207: Automatic checkin items should never be overdue 2021-04-22 14:37:14 +02:00
CirculationRule.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
CirculationRules.pm Bug 24083: Add support for unseen_renewals 2020-11-11 16:09:58 +01:00
Cities.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
City.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSortRule.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSortRules.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSource.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSources.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSplitRule.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSplitRules.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Club.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Clubs.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Config.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
Course.pm Bug 23727: Add Koha Object(s) related to course reserves 2020-04-17 13:45:51 +01:00
Courses.pm Bug 23727: Add Koha Object(s) related to course reserves 2020-04-17 13:45:51 +01:00
CoverImage.pm Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages 2020-10-12 11:28:41 +02:00
CoverImages.pm Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages 2020-10-12 11:28:41 +02:00
CsvProfile.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
CsvProfiles.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Database.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
DateUtils.pm Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0 2020-05-29 11:30:02 +02:00
Desk.pm Bug 13881: Add desk management 2020-03-25 09:19:15 +00:00
Desks.pm Bug 13881: Add desk management 2020-03-25 09:19:15 +00:00
EDI.pm Bug 27793: Store FTX free text in vendor note 2021-05-07 14:44:00 +02:00
Edifact.pm
Email.pm Bug 28017: Allow non-FQDN (@localhost) addresses 2021-04-01 18:51:37 +02:00
Exceptions.pm Bug 26518: Raise exception if the insert failed 2020-11-25 15:18:17 +01:00
ExternalContent.pm Bug 25527: Add logger to Koha::ExternalContent 2020-05-18 15:25:03 +01:00
FrameworkPlugin.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Hold.pm Bug 28254: (QA follow-up) override -> force 2021-05-04 14:22:08 +02:00
Holds.pm Bug 27069: Adapt uses of holdallowed 2021-04-07 16:08:04 +02:00
I18N.pm Bug 25517: Look in all possible places for MO files 2020-05-23 08:31:21 +01:00
Illcomment.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illcomments.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illrequest.pm Bug 23830: Adapt callers 2021-02-08 17:09:34 +01:00
Illrequestattribute.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illrequestattributes.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illrequests.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ImportBatch.pm Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages 2020-11-11 15:55:49 +01:00
ImportBatches.pm Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages 2020-11-11 15:55:49 +01:00
ImportBatchProfile.pm Bug 23019: (follow-up) Fix other things 2020-11-11 15:55:49 +01:00
ImportBatchProfiles.pm Bug 23019: (follow-up) Fix other things 2020-11-11 15:55:49 +01:00
Item.pm Bug 27064: (QA follow-up) Pass 'replace' through to Koha::Item::Transfer->cancel 2021-06-18 07:11:51 -04:00
Items.pm Bug 28286: Replace < 1 with <= 0 2021-05-10 15:46:55 +02:00
ItemType.pm Bug 21946: Display parent-child relationship on smart-rules.pl 2020-08-13 10:13:14 +02:00
ItemTypes.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
KeyboardShortcut.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
KeyboardShortcuts.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Libraries.pm Bug 24368: Remove Koha::Libraries->pickup_locations 2020-05-13 10:30:41 +01:00
Library.pm Bug 22569: Add a 'Transfers to send' report 2021-03-11 11:51:40 +01:00
Linktracker.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Localization.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Localizations.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Logger.pm Bug 25172: Remove _recheck_logfile 2020-04-22 13:43:58 +01:00
Manual.pm Bug 26944: Point help link to automatic item mod in manual 2020-11-18 12:03:03 +01:00
MarcSubfieldStructure.pm Bug 8976: (QA follow-up) Trivial POD fixes 2021-03-01 15:14:22 +01:00
MarcSubfieldStructures.pm Bug 8976: (QA follow-up) Trivial POD fixes 2021-03-01 15:14:22 +01:00
MessageAttribute.pm Bug 22818: (QA follow-up) Licence and POD fixes 2020-11-11 08:35:10 +01:00
MessageAttributes.pm Bug 22818: Fix TestBuilder.t 2020-11-11 18:03:17 +01:00
MetadataIterator.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
MetadataRecord.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
MetaSearcher.pm Bug 17515: Order Z3950 server by rank and preserve ordering 2020-11-02 11:03:09 +01:00
MoreUtils.pm
News.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
NewsItem.pm Bug 27714: Prevent Koha::NewsItem->author to explode 2021-02-23 13:12:56 +01:00
OAuth.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
OAuthAccessToken.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
OAuthAccessTokens.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Object.pm Bug 27819: Fix Object POD 2021-04-28 11:16:14 +02:00
Objects.pm Bug 21549: Make filter_by_last_update returns a Koha::Objects-based object 2021-04-14 15:34:27 +02:00
Patron.pm Bug 28490: Revert "Bug 26995: Remove references to relationship column" 2021-06-18 07:47:34 -04:00
Patrons.pm Bug 21549: Rename filter_by_dateexpiry with filter_by_expiration_date 2021-04-14 15:34:27 +02:00
Plugins.pm Bug 25549: Add error reporting to plugins-home 2020-10-22 10:04:30 +02:00
ProblemReport.pm Bug 4461: Update license statements 2020-04-06 11:18:39 +01:00
ProblemReports.pm Bug 4461: Update license statements 2020-04-06 11:18:39 +01:00
PseudonymizedTransaction.pm Bug 24151: Rename the config key with 'bcrypt_settings' 2020-07-20 15:17:42 +02:00
PseudonymizedTransactions.pm Bug 24151: (QA follow-up) Fix POD warnings from QA tools 2020-07-20 15:17:42 +02:00
Quote.pm Bug 27251: Rewrite QOTD with the Koha REST API 2021-01-29 09:03:45 +01:00
Quotes.pm Bug 16371: Fix inconsistencies with timestamp 2020-08-13 10:15:34 +02:00
Rating.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Ratings.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
RDF.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
RecordProcessor.pm Bug 25008: Overload Koha::RecordProcessor->options to update filters 2020-04-14 08:31:37 +01:00
Report.pm Bug 24695: (QA follow-up) Fix POD 2021-04-12 15:27:50 +02:00
Reports.pm Bug 24695: Move to Koha::Report->is_sql_valid 2021-04-12 15:27:50 +02:00
Review.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Reviews.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Schema.pm
Script.pm Bug 23571: (QA follow-up) Remove perlcritic warning 2020-04-14 17:24:35 +01:00
SearchEngine.pm Bug 24000: Some modules do not return 1 2021-04-06 15:56:30 +02:00
SearchField.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SearchFields.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SearchMarcMap.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SearchMarcMaps.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Serial.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Serials.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SharedContent.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SimpleMARC.pm Bug 26894: Handle subfield 0 and delete empty fields 2021-01-12 16:02:35 +01:00
Sitemapper.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Statistic.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Statistics.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationItem.pm Bug 22569: Add a 'Transfers to send' report 2021-03-11 11:51:40 +01:00
StockRotationItems.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationRota.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationRotas.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationStage.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationStages.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Subscription.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Subscriptions.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Suggestion.pm Bug 23591: Add some useful methods to Koha::Suggestions 2020-04-14 16:36:13 +01:00
SuggestionEngine.pm
Suggestions.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Tag.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Tags.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Token.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
UploadedFile.pm Bug 28123: Quote filename value in Content-Disposition header 2021-04-16 12:28:18 +02:00
UploadedFiles.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Uploader.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelf.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelfcontent.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelfcontents.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelfshare.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelfshares.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelves.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Z3950Responder.pm Bug 25292: Flushing L1 on every Z3950 server search 2021-01-11 10:27:37 +01:00
Z3950Server.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Z3950Servers.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00