Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Tomas Cohen Arazi 2d19a34529 Bug 18434: Add tests for K:SE:E::get_fixer_rules 
This patch tries to introduce exhaustive tests for this class method.
I didn't try to provide a regression test for the current bug per-se, but
cover the current method behaviour as much as I could.

(kidclamp) I added a quick test of _convert_marc_to_json to use the mocking here
and illuminate what the change does, before the patches this should
fail (fields are indexed in place of one another), after it should succeed (new indexed fields are appended).

A minor bug is highlighted by this new tests, I'll provide a followup for it.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ de kohaclone
 k$ prove t/db_dependent/Koha_Elasticsearch.t
=> FAIL: The returned fixer rules are not the expected ones

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-07-06 14:29:02 -03:00
..
Acquisition Bug 8612: [QA Follow-up] Remove two newlines from template output 2017-06-05 12:02:08 -03:00
api/v1 Bug 17932: (followup) Fix /patrons endpoint 2017-02-17 15:33:00 +00:00
Auth
Authorities Bug 9988: Refactor the cron script 2017-04-13 08:53:47 -04:00
Biblio
Circulation Bug 18651: Fix tests if no circ rule exist 2017-06-21 11:08:36 -03:00
Creators Bug 18044: Add a test 2017-02-07 17:46:00 +00:00
data
Exporter Bug 17196: [QA Follow-up] Wrong module in Record.t 2017-01-13 13:49:29 +00:00
Holds Bug 12063: [QA Follow-up] Small change of two test scripts 2017-05-09 08:59:40 -04:00
Items Bug 18761: Fix tests for AutomaticItemModificationByAge.t - clear cache 2017-06-14 14:36:11 -03:00
Koha Bug 18361: [QA Follow-up] Resolve warning on undef values supplied 2017-06-16 11:52:18 -03:00
Labels
LDAP
Letters Bug 17975: TT syntax for notices - Prove that HOLD_SLIP is compatible 2017-06-15 15:56:00 -03:00
Members Bug 18664: Make IssueSlip returns if params are not valid 2017-05-28 22:26:23 -04:00
OAI Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios 2017-06-13 16:18:59 -03:00
Patron Bug 18420: Do not use 'S' as patron category code in other tests 2017-04-21 10:49:25 -04:00
Record Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests 2016-10-21 15:13:55 +00:00
Reports Bug 17898: Automagically convert SQL reports 2017-05-19 18:48:26 +00:00
Reserves Bug 17560: Hold fee placement at point of checkout 2017-03-31 12:06:04 +00:00
Search Bug 18762: Remove a warning from History.t 2017-06-14 14:36:28 -03:00
selenium Bug 18804: Add additional information to execute successfuly selenium tests 2017-06-16 17:04:08 -03:00
Serials Bug 18697: Final polishing 2017-06-19 15:35:51 -03:00
SIP Bug 15006: Centralize timeout logic and allow zero client timeout 2016-07-15 14:11:05 +00:00
Template/Plugin Bug 18512: Add tests 2017-05-08 08:38:11 -04:00
Utils Bug 18094: Add tests to highlight the problem 2017-03-22 21:12:43 +00:00
www Bug 18807: t/db_dependent/www/batch.t fails 2017-06-19 15:34:39 -03:00
XSLT_Handler
00-strict.t Bug 18233 - t/db_dependent/00-strict.t has non-existant resetversion.pl 2017-05-08 09:22:27 -04:00
01-test_dbic.t Bug 18226: Perltidy + license 2017-06-05 17:52:48 -03:00
Accounts.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
Acquisition.t Bug 18554: Adjust a few typos including responsability 2017-05-09 21:03:22 +00:00
AdditionalField.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
Amazon.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
ArticleRequests.t Bug 18766: Remove itemtype-related warnings from ArticleRequests.t 2017-06-09 10:50:53 -03:00
AudioAlerts.t
Auth.t Bug 18442: Add a test 2017-05-08 08:29:13 -04:00
Auth_with_cas.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Auth_with_ldap.t Bug 6979 - Fix Already in a transaction error 2017-03-31 12:21:28 +00:00
AuthorisedValues.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
AuthoritiesMarc.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
BackgroundJob.t Bug 17426: Do not set AutoCommit in tests 2016-10-21 14:34:21 +00:00
Barcodes.t Bug 15878 - Updated unit tests for hbyymmincr barcodes 2016-05-23 17:42:10 +00:00
Barcodes_ValueBuilder.t
Biblio.t Bug 18554: Adjust a few typos including responsability 2017-05-09 21:03:22 +00:00
Bookseller.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
Breeding.t
Budgets.t Bug 18420: Fix Budgets.t when no patron category 'S' exists 2017-04-21 10:49:24 -04:00
Calendar.t Bug 12063 - Fix QA failures 2017-05-09 08:59:39 -04:00
Charset.t Bug 18269: Move field mappings related code to Koha::FieldMapping[s] 2017-03-31 10:20:00 +00:00
check_sysprefs.t Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t 2017-01-20 13:39:37 +00:00
Circulation.t Bug 18759: (follow-up) Try to fix random failure from Circulation.t 2017-06-09 10:08:37 -03:00
ClassSource.t Bug 16860: Remove the comment about the warning 2016-07-08 13:29:50 +00:00
Clubs.t Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable 2017-05-12 08:53:21 -04:00
ColumnsSettings.t Bug 16177: Fix tests for ColumnsSsettings.t 2016-04-01 19:08:23 +00:00
Context.t Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 1 2017-06-05 17:52:47 -03:00
Contract.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
CourseReserves.t Bug 17716: (followup) Remove dep on existing data and tidy 2016-12-05 15:32:57 +00:00
db_structure.t Bug 16173: db_structure.t shouldn't have a fixed number of tests 2016-04-01 19:14:53 +00:00
DecreaseLoanHighHolds.t Bug 16387: Fix default shortened loan period time 2017-02-07 17:54:21 +00:00
default_search_class.pl Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Filter_MARC_ViewPolicy.t Bug 11592: Add should_hide_marc method to filter 2016-09-08 11:54:16 +00:00
Fines.t
FrameworkPlugin.t
Heading_MARC21.t
Hold.t Bug 12063 - Remove Koha::Hold::waiting_expires_on since dateexpiration is set on database 2017-05-09 08:59:39 -04:00
Holds.t Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds 2017-07-05 13:42:52 -03:00
HoldsQueue.t Bug 18001 - Unit Test 2017-04-21 07:16:25 -04:00
Holidays.t Bug 16376: (regression tests) 2016-12-09 15:25:01 +00:00
ILSDI_Services.t Bug 17836: (ILSDI) Regression test 2017-01-20 13:44:57 +00:00
ImportBatch.t Bug 18611: [QA Follow-up] Add unit test for GetItemNumbersFromImportBatch 2017-05-28 22:23:34 -04:00
Installer.t Bug 17234: Need to separate KEY and FOREIGN KEY checks 2017-01-12 12:43:10 +00:00
Items.t Bug 17512: Improve handling dates in C4::Items 2017-02-14 13:57:49 +00:00
Items_DelItemCheck.t Bug 14504: Changes missed while fixing patches 2016-08-26 12:07:27 +00:00
KitchenSinkPlugin.kpz Bug 17368: Update KitchenSinkPlugin.kpz 2016-10-21 14:48:53 +00:00
Koha.t Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
Koha_Authority.t
Koha_Database.t
Koha_Elasticsearch.t Bug 18434: Add tests for K:SE:E::get_fixer_rules 2017-07-06 14:29:02 -03:00
Koha_Elasticsearch_Indexer.t Bug 17372: Standardize Elasticsearch paths 2016-10-11 01:07:03 +00:00
Koha_Misc_Files.t
Koha_SearchEngine_Elasticsearch_Search.t Bug 18068: ES - Fix location and (home|holding)branch facets 2017-02-17 11:34:41 +00:00
Languages.t Bug 16866: Catch warning t/db_dependent/Languages.t 2016-07-08 14:50:18 +00:00
Letters.t Bug 18478 - Unit tests 2017-05-28 22:17:13 -04:00
Linker_FirstMatch.t Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t 2016-08-04 20:04:24 +00:00
Log.t Bug 16829: Unit tests for logaction's 'interface parameter' 2016-08-17 18:01:50 +00:00
MarcModificationTemplates.t
Members.t Bug 15702: Add test cases for modified code 2017-04-24 13:21:27 -04:00
MungeMarcPrice.t
NewsChannels.t Bug 17960: Rename opac_news.new with opac_news.content 2017-02-06 17:42:12 +00:00
Overdues.t Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
Passwordrecovery.t Bug 18420: Fix HoldFulfillmentPolicy.t and Passwordrecovery.t 2017-04-21 10:49:25 -04:00
PatronLists.t Bug 17486: [QA Follow-up] Changes as to set_userenv 2017-01-13 12:32:20 +00:00
Patrons.t Bug 17742: Use TestBuilder to create the library and patron category 2016-12-28 13:34:21 +00:00
Plugins.t Bug 15879: Add Tests 2017-01-11 14:03:00 +00:00
QueryParser.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Record.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t Bug 14048: (QA followup) Default to 1 if no default rule 2016-07-07 10:37:01 -06:00
Reports.t
Reserves.t Bug 18620: [QA Follow-up] Move the final rollback to the very end 2017-05-28 22:17:13 -04:00
rollingloans.t Bug 17578: GetMemberDetails - Remove GetMemberDetails 2016-12-16 13:12:44 +00:00
RotatingCollections.t
Search.t Bug 18762: Remove some warnings from Search.t 2017-06-14 14:36:28 -03:00
Serials.t Bug 18782: Remove unused C4::Serials::getsupplierbyserialid 2017-07-05 13:41:47 -03:00
Serials_2.t Bug 18420: Do not use 'S' as patron category code in other tests 2017-04-21 10:49:25 -04:00
Service.t
ShelfBrowser.t
Sitemapper.t Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication 2017-06-05 17:52:48 -03:00
Stats.t
SuggestionEngine_ExplodedTerms.t Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t 2016-07-08 13:08:09 +00:00
Suggestions.t Bug 18420: Use TestBuilder to create a patron category in Suggestions.t 2017-04-21 10:49:25 -04:00
sysprefs.t Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
Tags.t
Templates.t Bug 18010: Unit test for gettemplate 2017-03-23 00:36:12 +00:00
TestBuilder.t Bug 18182: Tests all Koha::Objects-based modules 2017-04-21 00:10:50 +00:00
Upload.t Bug 18300: [QA Follow-up] Fix return value inconsistency 2017-04-21 00:11:40 +00:00
UsageStats.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
Virtualshelves.t Bug 18228: QA Followup - use gender neutral language in new tests 2017-07-05 13:35:49 -03:00
XISBN.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
XSLT_Handler.t
zebra_config.pl