Main Koha release repository https://koha-community.org
Find a file
Katrin Fischer 368bdcf4e9
Bug 30788: Fix warning in Overdues.pm when fine is empty in circ rules
Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm

To test:
* Create a issuing rule where fine is empty, but a fine interval is set.
  Fine amount: empty
  To do this, remove the 0 displayed in the input field before saving.
  Fine charging interval: 5 or any other numeric value
  When to charge: Start of interval
  Fine grace period: 0
* Check out an item with the due date yester (use specify due date)
* Run misc/cronjobs/fines.pl -v
* You should see above warn in the output
* Apply patch
* Rerun fines.pl, there should be no warn.
* Run:
  t/db_dependent/Circulation/CalcFine.t
  t/db_dependent/Fines.t
  t/db_dependent/Circulation.t
  t/db_dependent/Overdues.t

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-06-01 16:06:47 -03:00
acqui Bug 28082: Add acquisitions toolbar to vendors on vendor search page 2022-05-10 15:17:17 -10:00
admin Bug 30747: (follup-up) Add missing otherholdings_datelastborrowed column in settings 2022-05-23 08:52:40 -10:00
api Bug 30853: Add description for baskets in swagger.yaml 2022-06-01 15:55:44 -03:00
authorities Bug 20615: Add the link of number of times the authority are used in edit mode 2022-05-10 15:17:18 -10:00
basket Bug 29609: Centralized code to build the link to a biblio detail page 2022-04-08 15:49:16 +02:00
bin
C4 Bug 30788: Fix warning in Overdues.pm when fine is empty in circ rules 2022-06-01 16:06:47 -03:00
catalogue Bug 30009: Do not set MARCNOTES to empty list in list context 2022-05-18 17:22:09 -10:00
cataloguing Bug 30717: (QA follow-up) Move to module 2022-05-13 15:41:55 -10:00
circ Bug 30735: Fix filtering by patron attribute with AV in overdues report 2022-05-18 17:22:09 -10:00
clubs
course_reserves
debian Bug 30511: Don't lock up entire database while running koha-dump 2022-05-10 23:09:09 -10:00
docs Bug 30808: Add the 22.05 release team. 2022-05-25 23:56:12 -10:00
errors Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI 2022-04-20 09:03:39 -10:00
etc Bug 29936: Add holds_get_captured option to sip config 2022-05-05 11:17:37 -10:00
ill
installer Koha 22.06 - start of a new dev cycle 2022-05-31 08:43:28 -03:00
Koha Bug 30830: Add Koha Objects for Koha Import Items 2022-05-31 08:53:55 -03:00
koha-tmpl Bug 30828: Remove useless 'type' parameter in placerequest.pl 2022-06-01 16:05:14 -03:00
labels Bug 29821: Add interface for generating barcodes using svc/barcode 2022-04-08 15:49:17 +02:00
lib/CGI/Session/Serialize
members Bug 30611: Add ability for staff to send password reset emails 2022-05-10 15:17:17 -10:00
misc 22.05.00: Fix translations (bis) 2022-05-25 23:56:14 -10:00
offline_circ Bug 30525: Items batch modification broken 2022-04-21 13:41:36 -10:00
opac Bug 29925: Add a password reset page for expired passwords 2022-05-06 10:33:09 -10:00
patron_lists
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins Bug 29787: Add plugin version to plugin search results 2022-04-08 15:49:15 +02:00
pos Bug 28481: (RM follow-up) formatting 2021-12-16 12:13:51 -10:00
recalls Bug 30291: Changes to staff client files 2022-05-05 11:17:36 -10:00
reports Bug 30551: Make cash register report take branchcode from cash register 2022-05-06 10:33:10 -10:00
reserve Bug 30828: Remove useless 'type' parameter in placerequest.pl 2022-06-01 16:05:14 -03:00
reviews
rotating_collections
serials Bug 23352: Set default collection code when creating subscription 2022-05-10 15:17:17 -10:00
services
skel
suggestion Bug 30127: By default show pending suggestions tab 2022-05-10 23:09:09 -10:00
svc Bug 30167: (follow-up) Return a hash with soonest_renew_date 2022-05-04 14:29:23 -10:00
t Bug 29860: Remove item type-related warnings 2022-06-01 15:59:07 -03:00
tags
tmp/modified_authorities
tools Bug 29926: Add ability for superlibrarians to batch edit password expiration dates 2022-05-06 10:33:09 -10:00
virtualshelves Bug 26346: Add option to make public lists editable by all staff 2022-04-12 17:13:02 +02:00
xt Bug 27619: (QA follow-up) Remove xt/sample_notices.t 2022-05-11 11:28:48 +01:00
.editorconfig
.eslintrc.json
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
.mailmap 22.05.00: Update mailmap 2022-05-25 23:56:12 -10:00
.perlcriticrc
.proverc.dist
.scss-lint.yml
about.pl Bug 28998: (follow-up) Add warning on about for missing key 2022-05-04 05:18:31 -10:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28998: Add Crypt::CBC dependency 2022-05-04 05:18:31 -10:00
fix-perl-path.PL
gulpfile.js Bug 30373: Enable translation of UNIMARC frameworks 2022-04-21 13:41:35 -10:00
help.pl
INSTALL
Koha.pm Koha 22.06 - start of a new dev cycle 2022-05-31 08:43:28 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 19532: Database and installer stuff 2022-03-14 22:45:50 -10:00
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo