Nick Clemens de4d6983ab Bug 26634: Remove GetHoldRule subroutine in C4::Reserves ... This routine is only used internally and incorrectly overrides the precedence of holds rules - it should be removed This patch removes the routine, adjusts tests, and adds test to confirm correct precedence is followed To test: 1 - At the All Libraries level, create a circ rule for a specific patron category and a specific item type that only allows 1 hold 2 - At the branch-specific level for Branch A, create an All/All rule that allows 2 holds 3 - confirm ReservesControll is set to patron's library 4 - find a patron from Branch A of the category for which you made your rule 5 - find two bibs with items of the itype got which you made your rule 6 - place a hold on one bib. success! 7 - try to place a hold on the second bib. you're told you cannot because the patron is only allowed 1 hold 8 - apply patch, restart services 9 - try to place your second hold again, success! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>		2020-12-21 10:07:38 +01:00
..
AuthoritiesMarc
Barcodes	Bug 26673: Fix perlcritic complains	2020-11-02 08:42:20 +01:00
ClassSortRoutine
ClassSplitRoutine	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Creators	Bug 25852: Improve C4::Creators::Lib reliability under plack	2020-07-31 10:03:26 +02:00
External
Form
Heading	Bug 24269: Adjust C4::Heading to generate headings from auth tags	2020-02-19 13:33:32 +00:00
ILSDI	Bug 24083: (follow-up) Fix params to AddRenewal	2020-11-11 16:09:58 +01:00
Installer	Bug 24545: Fix license statements	2020-02-24 13:31:26 +00:00
Labels	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Linker	Bug 25189: Don't create authority if results found	2020-06-24 14:31:37 +02:00
Members	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
OAI	Bug 25460: Update OAI sets when adding/editing/deleting item records	2020-10-15 12:56:30 +02:00
Output
Patroncards	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Reports	Bug 22001: execute reports in an eval	2020-03-31 17:48:14 +01:00
Search
Serials
SIP	Bug 27166: Set destination_loc to item->homebranch	2020-12-14 14:17:35 +01:00
Utils	Bug 15400: Display date of birth and age more consistantly	2020-06-29 12:37:02 +02:00
Accounts.pm	Bug 22394: Remove C4::Accounts::manualinvoice	2020-11-04 12:59:33 +01:00
Acquisition.pm	Bug 26584: Remove unused C4::Acquisition::CloseBasket function	2020-11-05 15:24:20 +01:00
Auth.pm	Bug 24786: Default to 'branch default' on auth.	2020-11-06 15:40:00 +01:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Auth_with_ldap.pm	Bug 20443: Use search_with_library_limits for attribute types	2020-03-23 13:49:22 +00:00
Auth_with_shibboleth.pm
AuthoritiesMarc.pm	Bug 25313: Add skip_merge to ModAuthority	2020-11-18 12:03:03 +01:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm	Bug 26518: Move BiblioAutoLink within the transaction	2020-11-25 15:18:17 +01:00
Boolean.pm
Breeding.pm	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
Budgets.pm
Calendar.pm	Bug 25723: (QA follow-up) Handle holiday and exception on same day	2020-07-20 17:45:31 +02:00
Charset.pm
Circulation.pm	Bug 24083: (follow-up) Squashed follow ups	2020-11-11 16:09:58 +01:00
ClassSortRoutine.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
ClassSource.pm
ClassSplitRoutine.pm
Context.pm	Bug 24786: (follow-up) Cache the register_name in the session	2020-11-06 15:40:00 +01:00
Contract.pm
CourseReserves.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Creators.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Debug.pm
Heading.pm	Bug 24269: Adjust C4::Heading to generate headings from auth tags	2020-02-19 13:33:32 +00:00
HoldsQueue.pm	Bug 26510: Transport Cost Matrix editor doesn't show all data when HoldsQueueSkipClosed is enabled	2020-09-28 10:10:02 +02:00
HTML5Media.pm	Bug 20783: Use iframe to embed Youtube videos	2020-06-15 10:32:43 +02:00
ImportBatch.pm	Bug 26557: (bug 23463 follow-up) Fix Batch import when incoming records contain itemnumber	2020-11-20 14:25:46 +01:00
ImportExportFramework.pm
InstallAuth.pm	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
Installer.pm	Bug 23895: Move installer file into the mandatory directory	2020-10-14 14:50:07 +02:00
ItemCirculationAlertPreference.pm
Items.pm	Bug 20888: (follow-up) 'is not' operator behaves as 'not like'	2020-11-04 12:59:33 +01:00
Koha.pm	Bug 16371: Move GetDailyQuote to get_daily_quote	2020-08-13 10:15:33 +02:00
Labels.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Languages.pm	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
Letters.pm	Bug 26922: Better error handling in SendAlerts	2020-11-20 15:44:20 +01:00
Linker.pm
Log.pm	Bug 23632: Remove C4::Logs::GetLogs	2020-08-18 15:45:48 +02:00
MarcModificationTemplates.pm	Bug 24840: Replace DateTime->now with dt_from_string	2020-04-08 11:54:23 +01:00
Matcher.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Members.pm	Bug 23916: (follow-up) Adapt all the things to the new column and accessor names	2020-11-10 15:00:14 +01:00
Message.pm
NewsChannels.pm	Bug 21066: Rename publicationdate with published_on	2020-09-02 15:35:08 +02:00
Output.pm	Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml	2020-06-24 14:31:37 +02:00
Overdues.pm	Bug 27079: Floating point comparison correction	2020-11-27 09:37:40 +01:00
Patroncards.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Record.pm	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
Reports.pm
Reserves.pm	Bug 26634: Remove GetHoldRule subroutine in C4::Reserves	2020-12-21 10:07:38 +01:00
Ris.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
RotatingCollections.pm	Bug 12556: (QA follow-up) Fix QA Script failures	2020-10-14 14:50:07 +02:00
Scheduler.pm
Scrubber.pm
Search.pm	Bug 12430: Use releance ranking without QueryWeightFields	2020-12-04 15:26:56 +01:00
Serials.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Service.pm	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
ShelfBrowser.pm	Bug 26673: Remove shebangs from Perl modules	2020-10-26 00:14:42 +01:00
SMS.pm
SocialData.pm
Stats.pm	Bug 24151: Copy info to the pseudonymized table when a transaction is done	2020-07-20 15:17:42 +02:00
Suggestions.pm	Bug 25033: Remove CountSuggestion	2020-08-25 11:31:41 +02:00
Tags.pm
Templates.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm	Bug 26673: Remove #!/usr/bin/env perl from .pm modules too	2020-10-26 00:14:42 +01:00
UsageStats.pm	Bug 23420: (QA follow-up) Remove more AllowPurchaseSuggestionBranchChoice code	2020-10-09 12:22:01 +02:00
XISBN.pm	Bug 26270: Fix ThingISBN after a change in behaviour	2020-08-24 10:12:47 +02:00
XSLT.pm	Bug 24052: Rename XSLT_Handler	2020-03-24 10:42:23 +00:00