Main Koha release repository https://koha-community.org
Find a file
Jonathan Druart 4d78b9588a Bug 12098: Refactor can_*_subscription in C4::Serials
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested on top of patches for 12048 and 12080.

Subscription search
- superlibrarian, IndyBranches on/off - always sees all subscriptions
- superserials, IndyBranches on/off - always sees all subscriptions
- no superserials, IndyBranches on - only sees own subscriptions
Note: Subscriptions without branches will only show, when all subscriptions
      are visible. In a future enh it might be good to enforce setting a
      branch, when IndyBranches is used.
- no superserials, IndyBranches off - always sees all subscriptions

Subscription editing
- superlibrarian, IndyBranches on/off - can edit all subscriptions
- superserials, IndyBranches on/off - can edit all subscriptions
- no superserials, IndyBranches on - can only edit own subscriptons and
  subscriptions without branch
  NOTE: it would make sense to also allow Edit > Edit as new (duplicate)
  here, so one can copy the subscription from another branch to modify
  it for the own branch.

Passes tests in t, xt and QA script, also newly provided unit tests.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2014-04-18 20:46:00 +00:00
acqui Bug 7267: Add account number to German PDF template 2014-04-11 15:06:07 +00:00
admin Bug 7413: (follow-up) validate norenewalbefore values better 2014-04-08 22:46:28 +00:00
authorities Bug 11955: Remove spaces in empty indicators when linking an authority to a biblio record. 2014-04-18 15:50:02 +00:00
basket Bug 10605: fix encoding issue on basket email (INTRANET) 2013-12-10 04:37:12 +00:00
C4 Bug 12098: Refactor can_*_subscription in C4::Serials 2014-04-18 20:46:00 +00:00
catalogue Bug 11885: (follow-up) remove tabs 2014-04-11 14:50:59 +00:00
cataloguing Bug 11096: support the retrieval of large MARCXML records 2014-02-28 19:50:09 +00:00
circ Bug 9448: (follow-up) prevent unauthorized operator from bypassing check on forgiving overdue fines 2014-04-17 16:09:40 +00:00
course_reserves Bug 11866: (follow-up) repair security issue introduced by main patch 2014-03-10 14:57:17 +00:00
debian Bug 11705 - change versioning of build-git-snapshot 2014-03-12 01:49:56 +00:00
docs Bug 7143: Updating history with new developers 2014-04-14 14:37:48 +00:00
errors Housekeeping in errors scripts 2010-05-12 07:29:03 -04:00
etc Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
install_misc Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
installer Bug 9448: DBRev 3.15.00.031 2014-04-17 15:48:17 +00:00
Koha Bug 7413: update DBIC schema classes 2014-04-08 22:40:52 +00:00
koha-tmpl Bug 10533: move JavaScript functions for basket groups to a separate file 2014-04-18 19:25:12 +00:00
labels Bug 11096: support the retrieval of large MARCXML records 2014-02-28 19:50:09 +00:00
members Bug 11869: Add more informations to the patron account printing page 2014-04-18 14:34:20 +00:00
misc Bug 11484: (follow-up) standardize capitalization of "Z39.50" 2014-04-17 15:31:33 +00:00
offline_circ Bug 10240: (follow-up) don't display patrons as lost or gone-no-address incorrectly 2013-10-11 01:57:05 +00:00
opac Bug 7413: OPAC bootstrap theme changes 2014-04-07 18:28:57 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patron_lists Bug 10565: (follow-up) add new user permission for patron list management 2013-10-14 22:43:03 +00:00
patroncards Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
plugins Bug 7804 - Add Koha Plugin System - QA Followup 2 2013-03-20 14:50:19 -04:00
reports Bug 11718 - Use new DataTables include in reports templates 2014-03-12 17:33:25 +00:00
reserve Bug 9823: Refactor return from GetReservesFromBiblionumber 2014-01-30 16:19:55 +00:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections Bug 9605: rotating collections permissions are wrong 2013-03-30 22:11:05 -04:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Bug 11637: don't try to guess publication dates for irregular subscriptions 2014-03-14 15:16:44 +00:00
services Bug 7178: Acquisition item creation improvement 2012-03-26 11:07:23 +02:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 10611: Use mysql_auto_reconnect instead of ping 2014-03-10 23:15:35 +00:00
suggestion Bug 10277 - Add C4::Context->IsSuperLibrarian() 2013-12-30 15:47:23 +00:00
svc Bug 11704: Make */svc/report print the correct headers 2014-02-13 02:59:42 +00:00
t Bug 12098: Fix C4::Serials::can_edit_subscription 2014-04-18 20:45:59 +00:00
tags Bug 10730: Use DataTables on the tag review page 2013-09-25 16:47:59 +00:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools Bug 7567: QA followup: remove useless $parameters hashref 2014-04-07 18:14:20 +00:00
virtualshelves Bug 10853: All existing routing to get a CSV should return a MARC csv 2013-10-11 02:16:33 +00:00
xt Bug 12076: better detect an untranslatable template construct 2014-04-12 17:57:35 +00:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap 7439 Mailmap for master 2012-01-27 12:27:58 +01:00
about.pl Bug 11772: Show warning on About page:System information if no active currency is defined 2014-02-18 20:54:23 +00:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl Bug 11661: sanitize file names supplied to edithelp.pl 2014-02-05 01:36:10 +00:00
fix-perl-path.PL installer: improvements to fix-path-perl.PL on Win32 2007-12-20 19:20:12 -06:00
help.pl Bug 11238: contruct links to the appropriate manual version dynamically 2013-11-23 19:30:16 +00:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.opensuse Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl Bug 9448: DBRev 3.15.00.031 2014-04-17 15:48:17 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 7567 - Use, display, filter News by library 2014-04-07 18:14:19 +00:00
Makefile.PL Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 10580: adjust Makefile.PL to reflect that Zebra no longer optional in Koha setup 2014-02-21 17:38:15 +00:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/