Koha/Koha
Shi Yao Wang 87e589d79f
Bug 31105: Holds to pull counts items from other branches when independentbranches is active
Holds to pull should not show items from other branches that shares a
record when IndependentBranches is active. Except for superlibrarians.

Test plan:
1- Have IndependentBranches set to Yes
2- Have a record with an item from the current branch and another item from a different branch. We will call them branch A and branch B respectively
3- Have a patron from branch A place a hold on that record
4- Have a staff account on branch A and B with the following permissions:
    - circulate (all)
    - catalogue
5- Go to circulation > holds to pull
6- Notice under "Libraries" it displays branch A and B. Also, it shows 2 under "Items available"
7- Checkout the item from branch A to another patron
8- Go back to circulation > holds to pull
9- Notice under "Libraries" it displays branch B even though we are in branch A
10- Apply the patch
11- Return the checked out item from step 7
12- Redo step 5 to 9 with superlibrarian privileges and notice nothing changed
13- Redo step 11-12 but using accounts from step 4 and notice Holds to
pull only shows information relevant to their branch

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-09-23 09:44:18 -03:00
..
Account Bug 31254: Add additional fields for accountlines 2022-09-21 18:58:28 -03:00
Acquisition Bug 15348: (follow-up) Fix filtering results on estimated delivery date 2022-09-16 10:36:57 -03:00
App
ArticleRequest
Auth Bug 31389: Calculate user permissions in separate function 2022-09-22 08:39:21 -03:00
Authority
BackgroundJob Bug 27421: MARC staging/import are long-running tasks 2022-09-19 15:33:56 -03:00
Biblio Bug 29697: Fix t/db_dependent/Exporter/Record.t 2022-07-25 09:30:35 -03:00
BiblioUtils Bug 29697: Use flag embed_items 2022-07-22 15:24:11 -03:00
Cache
Cash Bug 27779: Group payouts by type of debit they're applied against 2022-08-08 13:37:25 -03:00
Charges
Checkouts
Club
CodeList/Unimarc Bug 30941: (QA follow-up) Only export what is needed 2022-08-19 11:00:42 -03:00
Config Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Course
Database Bug 21978: Add support for middle name 2022-06-24 12:24:11 -03:00
Edifact
Exceptions Bug 30650: Prevent pickup to be created on holiday 2022-07-29 15:00:51 -03:00
Exporter Bug 29697: Fix t/db_dependent/Exporter/Record.t 2022-07-25 09:30:35 -03:00
ExternalContent
Filter/MARC Bug 15187: Index 880 in Zebra the same as Elasticsearch 2022-07-22 15:09:46 -03:00
Hold Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es) 2022-07-29 15:28:20 -03:00
Illrequest Bug 30484: Implement support for ILL request updates 2022-09-23 09:18:45 -03:00
Import Bug 30779: Remove _update_import_record_marc and update tests 2022-08-18 09:02:04 -03:00
Indexer Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Item Bug 31183: Add Koha::Item::Transfers->filter_by_current 2022-08-09 08:26:24 -03:00
Library Bug 29922: Make get_search_groups return results sorted by title 2022-07-18 15:11:35 -03:00
List
MetadataRecord
Middleware
Misc
Notice
Number
OAI/Server Bug 30921: (QA follow-up) Remove unnecessary if 2022-09-12 16:26:35 -03:00
Object
Objects
Old Bug 30612: Rename other occurrences 2022-08-01 09:59:05 -03:00
Patron Bug 23681: Move to ::Patron::Restriction::Type(s) 2022-08-25 08:50:35 -03:00
Patrons Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
pdfformat
Plugins Bug 29121: Catch errors in ->install and ->upgrade calls on plugins 2021-10-01 16:28:55 +02:00
RecordProcessor
REST Bug 30982: (QA follow-up) Spelling 2022-09-23 08:57:50 -03:00
Result
Schema Bug 7021: DBIC schema 2022-09-22 09:41:31 -03:00
SearchEngine Bug 25375: Spelling fixes 2022-09-23 09:13:10 -03:00
Serial
Sitemapper
SMS
SMTP Bug 28416: Delay load of Email::Sender::Transport::SMTP 2022-03-25 11:01:04 -10:00
Subscription
SuggestionEngine Bug 31069: Remove ExplodedTerms dependency on templates 2022-07-18 12:37:35 -03:00
Tags
Template/Plugin Bug 31401: (QA follow-up) Remove Koha.ArePluginsEnabled, it is no longer needed 2022-09-07 13:55:37 -07:00
UI Bug 31154: (QA follow-up) Fix UI form builder 2022-09-16 10:26:26 -03:00
Util Bug 30678: (follow-up) Add oclc_number routine and friends 2022-07-22 14:58:11 -03:00
XSLT
Z3950Responder Bug 24295: Remove GetTransfer from Z3950Responder 2022-08-26 15:42:07 -03:00
Account.pm Bug 30458: Include librarian (manager_id) in accountline when using "Payout amount" button 2022-07-21 16:01:08 -03:00
ActionLog.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ActionLogs.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AdditionalContent.pm
AdditionalContents.pm Bug 29144: Add $contents->find_best_match, $library->opac_info 2022-09-16 09:55:19 -03:00
AdditionalField.pm
AdditionalFields.pm Bug 15774: Add POD and license notices 2019-03-07 20:37:05 +00:00
AdditionalFieldValue.pm
AdditionalFieldValues.pm Bug 15774: (follow-up) Address QA issues 2019-03-07 20:37:05 +00:00
AdvancedEditorMacro.pm
AdvancedEditorMacros.pm
ApiKey.pm
ApiKeys.pm
ArticleRequest.pm
ArticleRequests.pm Bug 29082: Add filtering methods to Koha::ArticleRequests 2021-10-07 10:54:59 +02:00
AudioAlert.pm
AudioAlerts.pm
AuthorisedValue.pm
AuthorisedValueCategories.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
AuthorisedValueCategory.pm
AuthorisedValues.pm Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
Authorities.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Authority.pm Bug 29897: Remove 'linkage' leftover 2022-08-09 10:58:48 -03:00
AuthUtils.pm Bug 29744: (QA follow-up) Call psgi_env in OO style 2022-09-22 08:11:58 -03:00
BackgroundJob.pm Bug 30982: (QA follow-up) Spelling 2022-09-23 08:57:50 -03:00
BackgroundJobs.pm Bug 30982: (QA follow-up) No userenv, no jobs 2022-09-23 08:57:51 -03:00
Biblio.pm Bug 29897: Add and fix POD 2022-08-09 10:58:45 -03:00
BiblioFramework.pm
BiblioFrameworks.pm
Biblioitem.pm
Biblioitems.pm
Biblios.pm
BiblioUtils.pm Bug 29697: Don't crash ES reindex if a record is wrong 2022-07-22 15:24:12 -03:00
Cache.pm
Caches.pm Bug 17935: Adjust some POD lines, fix a few typos 2017-02-14 14:12:50 +00:00
Calendar.pm
Checkout.pm Bug 30612: Rename other occurrences 2022-08-01 09:59:05 -03:00
Checkouts.pm
CirculationRule.pm
CirculationRules.pm Bug 22456: Add waiting_hold_cancellation circulation rule 2022-07-29 15:28:13 -03:00
Cities.pm
City.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
ClassSortRule.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
ClassSortRules.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
ClassSource.pm
ClassSources.pm
ClassSplitRule.pm
ClassSplitRules.pm
Club.pm
Clubs.pm
Config.pm
CookieManager.pm Bug 31250: (QA follow-up) The future will be easier 2022-09-12 15:34:11 -03:00
Course.pm
Courses.pm
CoverImage.pm
CoverImages.pm
CsvProfile.pm
CsvProfiles.pm
CurbsidePickup.pm Bug 30650: (QA follow-up) Some higher-level methods usage 2022-07-29 15:38:51 -03:00
CurbsidePickupIssue.pm Bug 30650: Add some useful modules and tests 2022-07-29 14:59:57 -03:00
CurbsidePickupIssues.pm Bug 30650: Add some useful modules and tests 2022-07-29 14:59:57 -03:00
CurbsidePickupOpeningSlot.pm Bug 30650: Add some useful modules and tests 2022-07-29 14:59:57 -03:00
CurbsidePickupOpeningSlots.pm Bug 30650: Add some useful modules and tests 2022-07-29 14:59:57 -03:00
CurbsidePickupPolicies.pm Bug 30650: Add some useful modules and tests 2022-07-29 14:59:57 -03:00
CurbsidePickupPolicy.pm Bug 30650: Allow to restrict curbside pickup for waiting holds only 2022-07-29 15:00:31 -03:00
CurbsidePickups.pm Bug 30650: Add filter_by_scheduled_today 2022-07-29 15:00:47 -03:00
Database.pm
DateUtils.pm
Desk.pm
Desks.pm
EDI.pm Bug 31054: Manual importing for EDIFACT invoices fails with a 500 error page 2022-07-11 18:23:12 -03:00
Edifact.pm
Email.pm
Encryption.pm
Exception.pm
Exceptions.pm Bug 23681: Move to ::Patron::Restriction::Type(s) 2022-08-25 08:50:35 -03:00
ExternalContent.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
FrameworkPlugin.pm
Hold.pm Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
Holds.pm Bug 31183: Use filter_by_current in Koha::Holds->get_items_that_can_fill 2022-08-09 08:26:25 -03:00
I18N.pm Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) 2022-08-19 08:55:09 -03:00
Illcomment.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illcomments.pm
Illrequest.pm Bug 30484: Implement support for ILL request updates 2022-09-23 09:18:45 -03:00
Illrequestattribute.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illrequestattributes.pm
Illrequests.pm
ImportBatch.pm
ImportBatches.pm Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages 2020-11-11 15:55:49 +01:00
ImportBatchProfile.pm
ImportBatchProfiles.pm
Item.pm Bug 31535: Fix warning - uninitialized value for location 2022-09-12 16:16:29 -03:00
Items.pm Bug 31105: Holds to pull counts items from other branches when independentbranches is active 2022-09-23 09:44:18 -03:00
ItemType.pm Bug 29844: Some more uncaught cases 2022-02-09 15:36:23 -10:00
ItemTypes.pm
KeyboardShortcut.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
KeyboardShortcuts.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Libraries.pm
Library.pm Bug 29144: Add $contents->find_best_match, $library->opac_info 2022-09-16 09:55:19 -03:00
Linktracker.pm
Localization.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Localizations.pm
Logger.pm Bug 31468: Change interface in Koha::Logger 2022-09-23 09:33:53 -03:00
Manual.pm
MarcOverlayRule.pm
MarcOverlayRules.pm
MarcSubfieldStructure.pm
MarcSubfieldStructures.pm
MessageAttribute.pm
MessageAttributes.pm
MetadataIterator.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
MetadataRecord.pm Bug 30813: (follow-up) Correct C4::Breeding call 2022-06-08 11:40:31 -03:00
MetaSearcher.pm
MoreUtils.pm
OAuth.pm
OAuthAccessToken.pm
OAuthAccessTokens.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Object.pm
Objects.pm Bug 29844: Remove use of wantarray from Koha::Objects 2022-02-09 15:36:23 -10:00
Patron.pm Bug 23538: Email library when new patron self-registers 2022-09-23 09:37:54 -03:00
Patrons.pm
Plugins.pm Bug 30180: (follow-up) Add temporary deprecation warning 2022-05-04 14:29:24 -10:00
ProblemReport.pm
ProblemReports.pm
PseudonymizedTransaction.pm
PseudonymizedTransactions.pm
Quote.pm
Quotes.pm
Rating.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Ratings.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
RDF.pm
Recall.pm
Recalls.pm Bug 7021: Catch new introductions of UpdateStats 2022-09-22 09:31:28 -03:00
RecordProcessor.pm
Report.pm Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
Reports.pm
Review.pm
Reviews.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Schema.pm Bug 11891: (follow-up) remove custom storage class 2014-06-19 11:55:03 -03:00
Script.pm
SearchEngine.pm
SearchField.pm
SearchFields.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
SearchMarcMap.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
SearchMarcMaps.pm
Serial.pm
Serials.pm
SharedContent.pm
SimpleMARC.pm
Sitemapper.pm
Statistic.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Statistics.pm
StockRotationItem.pm
StockRotationItems.pm
StockRotationRota.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationRotas.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationStage.pm
StockRotationStages.pm
Subscription.pm
Subscriptions.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Suggestion.pm Bug 31374: (follow-up) change private note to staff_note and reorder columns 2022-09-07 13:32:51 -07:00
SuggestionEngine.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Suggestions.pm
Tag.pm
Tags.pm
Token.pm Bug 27849: (follow-up) Add test 2022-08-01 09:53:35 -03:00
TrackedLink.pm Bug 22690: (QA follow-up) Add TrackedLink classes and use them 2021-08-27 11:02:41 +02:00
TrackedLinks.pm
UploadedFile.pm
UploadedFiles.pm
Uploader.pm Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
Virtualshelf.pm Bug 29955: Fix method import issues 2022-08-22 13:06:18 -03:00
Virtualshelfcontent.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Virtualshelfcontents.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Virtualshelfshare.pm Bug 25498: (QA follow-up) Rename virtualshelfshare->patron 2022-07-19 11:25:26 -03:00
Virtualshelfshares.pm
Virtualshelves.pm Bug 31288: (QA follow-up) Check userenv in disown_or_delete 2022-08-03 11:44:07 -03:00
Z3950Responder.pm Bug 25292: Flushing L1 on every Z3950 server search 2021-01-11 10:27:37 +01:00
Z3950Server.pm
Z3950Servers.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00