Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
25220 commits 35 branches 612 tags 1.8 GiB
Perl 45.3%
JavaScript 39.4%
HTML 7.2%
XSLT 3.9%
Vue 1.4%
Other 2.3%
Find a file
Marc Véron 9afc8e96f3 Bug 14015 - Checkout: Fix software error if barcode '0' is given 
To reproduce the bug:
- Go to Home > Circulation > Checkouts > [a patron]
- Enter 0 (zero) in barcode field and hit Enter

Result:
Software error
  Can't use string ("1") as a HASH ref while "strict refs" in use
  at /usr/share/kohaclone/circ/circulation.pl line 473

To test:
- Apply patch
- Repeat steps above
- Verify that the sofware error is gone and that you get a
  message as with other invalid barcodes.
- Test with other values: '00', '000', existing barcode,
  and a barcode that does not exist
- Test with empty barcode (for printing slip)
- Search for regressions

This patch implements Jonathan's solution (see comment #15)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2016-01-27 02:20:41 +00:00
acqui Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
admin Bug 15354: Sort itemtypes by translated description everywhere on circ rules admin page 2016-01-19 15:34:32 -07:00
api/v1 Bug 13799: Add types for patron's fields in Swagger spec 2015-11-04 13:47:33 -03:00
authorities Bug 15572: Follow-up to fix error on authority creation 2016-01-25 07:09:50 -07:00
basket Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
C4 Bug 15209: Check the parameter at the beginning of the subroutines 2016-01-27 02:07:21 +00:00
catalogue Bug 15295: Koha::Libraries - Remove GetBranchCategories 2016-01-14 15:45:31 +00:00
cataloguing Bug 15572: Follow-up to fix error on authority creation 2016-01-25 07:09:50 -07:00
circ Bug 14015 - Checkout: Fix software error if barcode '0' is given 2016-01-27 02:20:41 +00:00
course_reserves Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
debian Bug 15626: Remove log4perl.conf when using koha-remove 2016-01-27 01:10:16 +00:00
docs Bug 7143: Adding releases and fixing some missing tabs 2016-01-06 16:03:30 -07:00
errors Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
etc Bug 15405 - XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux Adjusts the modulePath to search in the well-known location for 64 bit systems. Required for at least Fedora. 2015-12-30 14:35:45 +00:00
install_misc Bug 14066: Removing more Readonly 2015-05-06 11:05:22 -03:00
installer Bug 12375 - Add new serial fields to kohastructure 2016-01-06 12:17:55 +00:00
Koha Bug 15135: Remove Warning Subroutine HasOverdues redefined 2016-01-27 02:12:38 +00:00
koha-tmpl Bug 15299: Ask for confirmation when deleting a report from second page 2016-01-27 01:59:43 +00:00
labels Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
members Bug 15542 [QA Followup] - Tidy member-password.pl 2016-01-23 19:15:08 +00:00
misc Bug 14133: Print notices should be generated with the print template 2016-01-27 02:18:07 +00:00
offline_circ Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-30 11:53:18 +00:00
opac Bug 15550: Fix authority search and detail at the OPAC 2016-01-23 18:34:06 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patron_lists Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
patroncards Bug 14131 - Patroncard: Add possibility to print from patron lists 2015-12-31 20:24:58 +00:00
plugins Bug 14951: Remove C4::Dates from plugins/*.pl files 2015-10-06 10:29:42 -03:00
reports Bug 10154 Add Call number in the filter of most circulated items 2015-12-31 16:16:10 +00:00
reserve Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
reviews Bug 14779: Cannot paginate reviews 2015-09-07 11:38:26 -03:00
rotating_collections Bug 15066: Make transfer rotating collection works under Plack 2015-11-05 09:50:09 -03:00
selenium
serials Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
services Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
suggestion Bug 9468: use new SUGGEST_FORMAT list 2015-11-05 10:46:57 -03:00
svc Bug 15477: (follow-up) Bug 14100: Better errors handling 2016-01-12 16:13:41 +00:00
t Bug 15209: Add tests 2016-01-27 02:07:21 +00:00
tags Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax 2015-11-02 12:49:13 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
tools Bug 15542: Always display the patron's info the same way. 2016-01-23 19:15:08 +00:00
virtualshelves Bug 15137: Display ISBN and author info when sending list by email 2015-11-16 12:36:01 -03:00
xt Bug 13632: (QA followup) remove xt/permissions.t 2015-10-19 12:42:59 -03:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess
.mailmap (RM followup) .mailmap updates 2015-05-22 17:02:21 -03:00
about.pl Bug 7895: Test for PSGI-related env to report in about.pl 2015-11-10 15:18:28 -03:00
changelanguage.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
edithelp.pl Bug 14813: Fix encoding issues on editing help pages 2015-09-16 10:42:15 -03:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 14812: Display the help in the correct language 2015-10-02 15:06:08 -03:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
INSTALL.opensuse Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
Koha.pm Bug 15443 - DBrev 3.23.00.015 2016-01-04 12:53:08 +00:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 10904: (QA followup) Use branch limit if either IndependentBranches or IndependentBranchesPatronModifications is enabled 2015-11-02 12:34:46 -03:00
Makefile.PL Bug 15447 - log4perl.conf does not have __LOG_DIR__ replaced when installing 2015-12-31 11:36:38 +00:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00

README 

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/