Koha/Koha
emlam dae5607fd1
Bug 34435: Remove side effect from get_password_expiry_date
If get_password_expiry_date is passed a DateTime object
as a parameter, it modifies and returns the original
object. This can create possible side effects.

This patch modifies get_password_expiry_date to clone the
DateTime object that it receives as a parameter and
return the modified clone, so that object references can
be passed in safely.

To test:
prove t/db_dependent/Koha/Patron/Category.t

Signed-off-by: Sam Lau <samalau@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-08-15 12:17:04 +03:00
..
Account Bug 33444: Update AddRenewal to take a hashref of params 2023-07-19 12:06:52 -03:00
Acquisition Bug 33105: Add missing POD 2023-07-20 10:59:32 -03:00
App
ArticleRequest
Auth Bug 33880: Remove Version param from GB::Barcode->new 2023-06-09 08:28:59 -03:00
Authority
BackgroundJob Bug 33755: Set profile_id and add missing import 2023-08-15 12:16:59 +03:00
Biblio Bug 33270: (QA follow-up) Do not change param hashref 2023-07-18 12:47:00 -03:00
Cache
Cash
Charges
Checkouts Bug 33362: Allow return claims to be resolved even if the issue has since been delete from the database 2023-05-24 11:21:31 -03:00
Club
CodeList/Unimarc
Config Bug 32478: Remove Koha::Config::SysPref->find since bypasses cache 2023-06-07 15:25:18 -03:00
Course
Database Bug 33735: Misspelling in SMS provier 2023-05-17 10:28:24 -03:00
Edifact Bug 30649: Vendor EDI account passwords should be encrypted in the database 2023-05-15 18:23:49 -03:00
ERM Bug 33490: Fix ambiguous query error 2023-05-05 09:13:36 -03:00
Exceptions Bug 33028: (follow-up) Add POD to new Exception 2023-07-19 12:06:49 -03:00
Exporter Bug 25503: Make _get_biblio_for_export test pass 2023-05-10 15:26:19 -03:00
ExternalContent Bug 33697: Remove RecordedBooks (rbdigital) integration 2023-06-05 15:36:11 -03:00
Filter/MARC Bug 32464: Koha::Item->as_marc_field obsolete option mss 2023-06-06 15:40:15 -03:00
Hold Bug 28966: (QA follow-up) Changes for Koha objects 2023-07-25 16:25:39 -03:00
Illrequest Bug 21548: ILLLIBS patron category / partner_code seems extraneous 2023-03-31 12:14:51 +02:00
Import Bug 32437: (QA follow-up) Change to replace POD 2023-03-31 13:13:28 +02:00
Indexer
Item Bug 33739: Only trigger indexing on last item modification at ModItemTransfer 2023-05-16 11:26:06 +02:00
Library Bug 32894: Remove wrong caching from Koha:: methods - simple 2023-06-07 16:44:03 -03:00
List
MetadataRecord
Middleware Bug 33967: Fix SetEnv middleware to preserve $env integrity 2023-06-09 08:50:12 -03:00
Misc
Notice Bug 33360: Extend Koha::Notice::Util with domain groups 2023-04-14 11:35:30 -03:00
Number
OAI/Server Bug 33270: (follow-up) Handle records that fail attempt to ignore bad characters 2023-07-18 12:46:58 -03:00
Object Bug 32894: Remove wrong caching from Koha:: methods - simple 2023-06-07 16:44:03 -03:00
Objects Bug 32735: (follow-up) Make Koha::Objects::Record::Collections->print_collection work with Authorities and Biblios 2023-05-05 12:13:50 -03:00
Old
Patron Bug 34435: Remove side effect from get_password_expiry_date 2023-08-15 12:17:04 +03:00
Patrons Bug 31095: Remove GetDebarments from Patron::Import 2023-01-31 10:19:38 -03:00
pdfformat Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages 2023-05-16 15:17:28 -03:00
Plugins
RecordProcessor
REST Bug 34365: Add cancellation request flow to DELETE /holds 2023-08-15 11:25:54 +03:00
Result
Schema Bug 28966: DBIC schema 2023-07-26 15:41:13 -03:00
SearchEngine Bug 33594: Update mappings and comment 2023-05-18 11:03:28 -03:00
Serial
Sitemapper
SMS
SMTP Bug 33964: Use Email::Sender::Transport::SMTP::Persistent for sending email 2023-07-24 14:55:33 -03:00
Subscription
SuggestionEngine
Tags
Template/Plugin Bug 30524: (QA follow-up) Only generate CSRF token if it will be used 2023-08-07 21:00:06 -03:00
Ticket Bug 31028: Add catalog concern management page to staff 2023-03-06 11:23:17 -03:00
UI Bug 32484: (QA follow-up) Few typos 2023-04-21 10:36:30 -03:00
Util
XSLT Bug 12758: Add new module call in Koha::XSLT::Base 2022-11-09 09:52:25 -03:00
Z3950Responder
Account.pm Bug 34316: Add_credit should rethrow an exception correctly 2023-07-20 10:59:35 -03:00
ActionLog.pm
ActionLogs.pm
AdditionalContent.pm
AdditionalContents.pm
AdditionalField.pm Bug 11844: Fix QA issues (POD, TT filters, file exec flag) 2023-05-16 12:58:38 +02:00
AdditionalFields.pm
AdditionalFieldValue.pm
AdditionalFieldValues.pm
AdvancedEditorMacro.pm
AdvancedEditorMacros.pm
ApiKey.pm
ApiKeys.pm
ArticleRequest.pm Bug 32894: (QA follow-up) Fix typo 2023-06-07 16:44:04 -03:00
ArticleRequests.pm
AudioAlert.pm
AudioAlerts.pm
AuthorisedValue.pm Bug 30920: (follow-up) Flush on delete 2023-03-13 15:11:44 -03:00
AuthorisedValueCategories.pm
AuthorisedValueCategory.pm Bug 32997: Add REST API endpoint to list authorised values for multiple given categories 2023-03-02 12:00:15 -03:00
AuthorisedValues.pm Bug 34051: Cache empty hashref for non-existent authorised values 2023-06-21 13:20:31 -03:00
Authorities.pm Bug 33083: Add a generic class to handle methods for collections of records 2023-03-13 15:11:59 -03:00
Authority.pm Bug 33996: (QA follow-up) Fix mappings to match guidelines 2023-06-29 11:11:13 -03:00
AuthUtils.pm Bug 33341: Address some perlcritic errors in 5.36 2023-03-28 14:50:33 +02:00
BackgroundJob.pm Bug 33044: Return job id if there is no connection to rabbit 2023-03-06 09:51:45 -03:00
BackgroundJobs.pm Bug 31969: Use filter_by_last_update 2022-11-25 09:40:09 -03:00
Biblio.pm Bug 32711: Fix biblio embeds 2023-07-24 13:58:25 -03:00
BiblioFramework.pm
BiblioFrameworks.pm
Biblioitem.pm Bug 32711: Add 'public_read_list' appropriately 2023-07-24 13:58:25 -03:00
Biblioitems.pm
Biblios.pm Bug 33974: (follow-up) biblionumber column needs special handling 2023-07-03 14:51:46 -03:00
BiblioUtils.pm
Cache.pm
Caches.pm
Calendar.pm
Checkout.pm
Checkouts.pm
CirculationRule.pm Bug 32894: Remove wrong caching from Koha:: methods - simple 2023-06-07 16:44:03 -03:00
CirculationRules.pm Bug 32271: (QA follow-up) Correction to 'can_be_blank' logic 2023-07-19 13:00:38 -03:00
Cities.pm
City.pm
ClassSortRule.pm
ClassSortRules.pm
ClassSource.pm Bug 30920: (follow-up) Flush on delete 2023-03-13 15:11:44 -03:00
ClassSources.pm
ClassSplitRule.pm
ClassSplitRules.pm
Club.pm
Clubs.pm
Config.pm
CookieManager.pm
Course.pm
Courses.pm
CoverImage.pm
CoverImages.pm
CsvProfile.pm
CsvProfiles.pm
CurbsidePickup.pm
CurbsidePickupIssue.pm
CurbsidePickupIssues.pm
CurbsidePickupOpeningSlot.pm
CurbsidePickupOpeningSlots.pm
CurbsidePickupPolicies.pm
CurbsidePickupPolicy.pm Bug 32891: Fix slot selection in last hour 2023-02-21 10:22:28 -03:00
CurbsidePickups.pm
Database.pm
DateUtils.pm Bug 33611: Ensure dt_from_string always returns a new object 2023-05-09 10:58:04 -03:00
Desk.pm
Desks.pm
EDI.pm Bug 28672: (QA follow-up) Method calls cannot be interpolated directly 2023-02-07 15:39:31 -03:00
Edifact.pm
Email.pm
Encryption.pm Bug 33934: Add more detail to 'No encryption_key in koha-conf.xml' 2023-06-07 15:25:18 -03:00
Exception.pm
Exceptions.pm Bug 32334: Add general exception FileNotFound 2023-04-12 11:21:55 -03:00
ExternalContent.pm
FrameworkPlugin.pm
Hold.pm Bug 32894: Remove wrong caching from Koha:: methods - simple 2023-06-07 16:44:03 -03:00
Holds.pm Bug 32529: Add Koha::Holds->filter_by_found 2023-01-05 09:21:10 -03:00
I18N.pm
Illbackend.pm Bug 22440: Move backend statuses api endpoint 2023-05-05 09:13:43 -03:00
Illcomment.pm
Illcomments.pm
Illrequest.pm Bug 21983: (QA follow-up) Skip deleted_biblio_id from the API object 2023-06-06 15:40:13 -03:00
Illrequestattribute.pm Bug 22440: Add standard accessors for later usage 2023-05-05 09:13:41 -03:00
Illrequestattributes.pm Bug 22440: New ILL requests table 2023-05-05 09:13:41 -03:00
Illrequests.pm Bug 22440: Add Koha::Illrequests->filter_by_visible 2023-05-05 09:13:40 -03:00
ImportBatch.pm
ImportBatches.pm
ImportBatchProfile.pm
ImportBatchProfiles.pm
Item.pm Bug 28966: (QA follow-up) tmp_holdsqueue no longer an iterator 2023-07-26 17:48:28 -03:00
Items.pm Bug 32019: (follow-up) Fix terminology and styling 2023-02-20 09:54:20 -03:00
ItemType.pm Bug 34357: Replace SUPER->imageurl in ItemTypes 2023-08-15 12:16:48 +03:00
ItemTypes.pm
KeyboardShortcut.pm
KeyboardShortcuts.pm
Libraries.pm
Library.pm Bug 30920: (follow-up) Flush on delete 2023-03-13 15:11:44 -03:00
Linktracker.pm
Localization.pm Bug 30920: (follow-up) Flush on delete 2023-03-13 15:11:44 -03:00
Localizations.pm
Logger.pm Bug 33020: (QA follow-up) POD and chmod 2023-02-27 11:33:50 -03:00
Manual.pm Bug 33790: Fix and add various links to the manual 2023-07-07 09:18:06 -03:00
MarcOverlayRule.pm
MarcOverlayRules.pm
MarcSubfieldStructure.pm
MarcSubfieldStructures.pm
MessageAttribute.pm
MessageAttributes.pm
MetadataIterator.pm
MetadataRecord.pm Bug 30358: Strip leading/trailing whitespace characters from input fields when cataloguing 2023-05-16 15:17:26 -03:00
MetaSearcher.pm
MoreUtils.pm
OAuth.pm
OAuthAccessToken.pm
OAuthAccessTokens.pm
Object.pm Bug 33745: Tell perlcritic we know what we are doing 2023-07-18 12:30:17 -03:00
Objects.pm
Patron.pm Bug 34280: (QA follow-up) perltidy 2023-07-24 14:55:32 -03:00
Patrons.pm Bug 31937: Fix Patrons::search_unsubscribed - sharpen condition 2022-11-17 13:41:24 -03:00
Plugins.pm
ProblemReport.pm
ProblemReports.pm
PseudonymizedTransaction.pm
PseudonymizedTransactions.pm
Quote.pm
Quotes.pm
Rating.pm
Ratings.pm
Recall.pm Bug 18398: Update C4::Message enqueue to use $patron->notice_email_address 2023-03-31 13:13:33 +02:00
Recalls.pm Bug 31147: Recalls should not adjust due time for related checkouts 2023-07-13 15:19:31 -03:00
RecordProcessor.pm
Report.pm Bug 27824: Trim column headers 2023-07-13 15:19:33 -03:00
Reports.pm
Review.pm
Reviews.pm
Schema.pm
Script.pm
SearchEngine.pm
SearchField.pm
SearchFields.pm
SearchFilter.pm
SearchFilters.pm
SearchMarcMap.pm
SearchMarcMaps.pm
Serial.pm
Serials.pm
SharedContent.pm
SimpleMARC.pm
Sitemapper.pm
Statistic.pm
Statistics.pm
StockRotationItem.pm
StockRotationItems.pm
StockRotationRota.pm
StockRotationRotas.pm
StockRotationStage.pm
StockRotationStages.pm
Subscription.pm
Subscriptions.pm
Suggestion.pm Bug 33236: (follow-up) Add use statements 2023-06-06 10:08:36 -03:00
SuggestionEngine.pm
Suggestions.pm Bug 33238: Fix bad suggestions query (Bug 29886 follow-up) 2023-04-17 09:39:43 -03:00
Tag.pm
Tags.pm
TemplateUtils.pm Bug 33030: Add standardized subroutine for processing Template Toolkit syntax outside of notices 2023-07-14 16:52:05 -03:00
Ticket.pm Bug 31028: (follow-up) Update notice module codes 2023-03-06 11:23:17 -03:00
Tickets.pm Bug 31028: Add new Koha::Object(s) classes 2023-03-06 11:23:17 -03:00
Token.pm Bug 34212: Compare strings with eq instead of == 2023-07-07 09:18:12 -03:00
TrackedLink.pm
TrackedLinks.pm
UploadedFile.pm
UploadedFiles.pm
Uploader.pm
Virtualshelf.pm Bug 32894: Remove wrong caching from Koha:: methods - simple 2023-06-07 16:44:03 -03:00
Virtualshelfcontent.pm
Virtualshelfcontents.pm
Virtualshelfshare.pm Bug 32894: Make ->sharee looks like others 2023-06-07 16:44:05 -03:00
Virtualshelfshares.pm
Virtualshelves.pm Bug 30418: Add ability for permitted staff to edit list contents 2023-05-15 18:23:57 -03:00
Z3950Responder.pm
Z3950Server.pm
Z3950Servers.pm