Main Koha release repository https://koha-community.org
Find a file
Jonathan Druart a86242c2ea Bug 27669: Fix 'importing' and 'reverting' statuses when importing/reverting a batch
SetImportBatchStatus is not called with $batch_id

It has been caught by bug 25026, and www/search_utf8.t fails with
t/db_dependent/www/search_utf8.t .. 14/87 Error POSTing http://koha:8081/cgi-bin/koha/tools/manage-marc-import.pl: Internal Server Error at t/db_dependent/www/search_utf8.t line 240.

And, from logs:

manage-marc-import.pl: C4::ImportBatch::SetImportBatchStatus(): DBI Exception: DBD::mysql::st execute failed: Truncated incorrect DOUBLE value: 'importing' [for Statement "UPDATE import_batches SET import_status = ? WHERE import_batch_id = ?" with ParamValues: 0=undef, 1='importing'] at /kohadevbox/koh
a/C4/ImportBatch.pm line 579: /kohadevbox/koha/tools/manage-marc-import.pl, referer: http://koha:8081/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=2

Test plan:
Read the changes and confirm it does make sense.
Import and revert a batch

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-02-12 15:41:03 +01:00
acqui Bug 23830: Adapt callers 2021-02-08 17:09:34 +01:00
admin Bug 27655: Add barcode "columnname" to "column_settings.yml" 2021-02-09 09:23:50 +01:00
api Bug 26274: Add cashups api routes 2021-02-12 12:33:41 +01:00
authorities Bug 11299: (follow-up) correct link 2021-01-14 14:03:49 +01:00
basket Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
C4 Bug 27669: Fix 'importing' and 'reverting' statuses when importing/reverting a batch 2021-02-12 15:41:03 +01:00
catalogue Bug 23763: Make search on staff and opac use new routine 2021-02-08 17:09:32 +01:00
cataloguing Bug 20971: Prevent Storable::thaw to fail on LastCreatedItem 2021-01-19 16:03:34 +01:00
circ Bug 27676: Correct finesMode ne off condition 2021-02-12 12:14:50 +01:00
clubs Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
course_reserves Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
debian Bug 20410: Remove OpacGroupResults and PazPar2 2021-02-08 16:12:42 +01:00
docs Bug 7143: Update about page for new devs 2021-01-22 14:59:27 +01:00
errors Bug 26048: Use ErrorDocument middleware for Plack HTTP errors 2021-01-27 10:30:43 +01:00
etc Bug 20410: Remove OpacGroupResults and PazPar2 2021-02-08 16:12:42 +01:00
ill Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
installer Bug 25026: Use HandleError to not raise or print error 2021-02-09 10:20:49 +01:00
Koha Bug 27068: Fix errors in _checkHoldPolicy 2021-02-12 13:08:55 +01:00
koha-tmpl Bug 26274: Update register.tt to use the API 2021-02-12 12:33:41 +01:00
labels Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
members Bug 27454: Pass the arrayref 2021-02-08 14:56:00 +01:00
misc Bug 27050: Allow multiple category_codes in delete_patrons.pl 2021-02-08 17:09:34 +01:00
offline_circ Bug 24083: Add support for unseen_renewals 2020-11-11 16:09:58 +01:00
opac Bug 27380: (follow-up) Remove earlier declaration and unused assignment 2021-02-12 12:30:58 +01:00
patron_lists Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
patroncards Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
plugins Bug 24633: Add support for gitlab searching of plugins 2020-11-06 15:55:17 +01:00
pos Bug 24786: Update point of sale to use session register 2020-11-06 15:39:59 +01:00
reports Bug 27380: Move get_prepped_report to object and use for svc/reports 2021-02-12 12:29:56 +01:00
reserve Bug 26963: (QA follow-up) Fix cases where we expected a list 2020-11-13 14:20:11 +01:00
reviews Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
rotating_collections Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
serials Bug 27398: Made values in number patterns subscription length translatable 2021-02-08 14:56:00 +01:00
services Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
skel
suggestion Bug 26738: (bug 24819 follow-up) Fix manager selection 2020-11-04 12:59:32 +01:00
svc Bug 27380: Move get_prepped_report to object and use for svc/reports 2021-02-12 12:29:56 +01:00
t Bug 27380: FIX Reports/Guided.t 2021-02-12 14:31:01 +01:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
tmp/modified_authorities
tools Bug 26059: Create guarantor/guarantee links on patron import 2021-02-12 12:14:50 +01:00
virtualshelves Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
xt Bug 26971: Remove obsolete test file translatable-templates.t 2020-11-09 11:20:43 +01:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore
.htaccess
.mailmap Bug 26621: Adjust .mailmap to reduce the number of invalid authors 2020-10-15 12:56:30 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml
about.pl Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info 2021-01-07 15:32:20 +01:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 26848: Fix Readonly dependency in cpanfile 2021-01-12 11:17:35 +01:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js Bug 27072: Don't process staff interface CSS with rtlcss 2020-11-24 21:27:59 +01:00
help.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 18506: DBRev 20.12.00.011 2021-02-09 09:48:49 +01:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
LICENSE
mainpage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Makefile.PL Bug 20410: Remove OpacGroupResults and PazPar2 2021-02-08 16:12:42 +01:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
package.json Bug 25067: Move PO file manipulation code into gulp tasks 2020-11-06 09:46:11 +01:00
README
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 20410: Remove OpacGroupResults and PazPar2 2021-02-08 16:12:42 +01:00
yarn.lock Bug 25067: Move PO file manipulation code into gulp tasks 2020-11-06 09:46:11 +01:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo