Main Koha release repository https://koha-community.org
Find a file
Tomas Cohen Arazi b033366bea Bug 28600: (bug 18989 follow-up) Resolve variable scope issue
This patch fixes a scope issue. Originally, a variable declared as

our $borcat

was replaced by

my $patron

This patch makes the method not rely on global variables, but have a
parameter for the patron, and thus things are clearer.

To test:
1. Open the OPAC detail page for a record
=> FAIL: The logs show some errors about the $patron variable not
available in the scope
2. Apply this patch
3. Repeat 1
=> SUCCESS: No errors
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-06-24 11:53:35 +02:00
acqui Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
admin Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
api Bug 28480: Add q parameters for GET /patrons 2021-06-23 15:09:55 +02:00
authorities Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
basket Bug 27268: (QA follow-up) Add Koha::Biblios to basket scripts 2021-03-09 17:20:47 +01:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
C4 Bug 28581: (QA follow-up) Fix method on unblessed reference 2021-06-23 15:09:55 +02:00
catalogue Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
cataloguing Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
circ Bug 28581: Use 'from_email_address' where appropriate 2021-06-23 15:09:55 +02:00
clubs Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
course_reserves Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
debian Bug 27348: Fix test on ALTERNATE_INDEXER_DAEMON in koha-indexer 2021-06-21 12:07:28 +02:00
docs Bug 28476: Update info in docs/teams.yaml file 2021-06-21 12:07:28 +02:00
errors Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
etc Bug 8280: Add koha set and item fields to pqf.properties 2021-06-21 14:01:50 +02:00
ill Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
installer Bug 26205: DBRev 21.06.00.005 2021-06-23 15:09:55 +02:00
Koha Bug 28588: (follow-up) Make the API use the new method 2021-06-23 15:09:56 +02:00
koha-tmpl Bug 26205: (QA follow-up) Add punctuation and widen pref description a bit 2021-06-23 14:56:56 +02:00
labels Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
lib/CGI/Session/Serialize Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
members Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
misc Bug 28581: Use 'from_email_address' where appropriate 2021-06-23 15:09:55 +02:00
offline_circ Bug 24083: Add support for unseen_renewals 2020-11-11 16:09:58 +01:00
opac Bug 28600: (bug 18989 follow-up) Resolve variable scope issue 2021-06-24 11:53:35 +02:00
patron_lists Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
patroncards Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
plugins Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
pos Bug 28514: Remove getletter 2021-06-21 13:49:58 +02:00
reports Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
reserve Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
reviews Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
rotating_collections Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
serials Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
services Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
skel
suggestion Bug 28581: Use 'from_email_address' where appropriate 2021-06-23 15:09:55 +02:00
svc Bug 28271: Preselect the current item lost value 2021-06-21 10:50:09 +02:00
t Bug 28588: Unit tests 2021-06-23 15:09:56 +02:00
tags Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
tmp/modified_authorities
tools Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
virtualshelves Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
xt Bug 28370: Rewrite tests 2021-05-25 09:28:18 +02:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
.mailmap Bug 28386: Disambiguate Tomas and Blou 2021-05-26 12:30:59 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28317: Use the default CGI::Session serializer 2021-05-19 14:45:32 +02:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js Bug 27072: Don't process staff interface CSS with rtlcss 2020-11-24 21:27:59 +01:00
help.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 26205: DBRev 21.06.00.005 2021-06-23 15:09:55 +02:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Makefile.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
MANIFEST.SKIP
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo