Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
48016 commits 35 branches 616 tags 1.8 GiB
Perl 45.6%
JavaScript 39.3%
HTML 7.2%
XSLT 3.7%
Vue 1.4%
Other 2.3%
Find a file
Tomas Cohen Arazi cc58ca2a3c
Bug 32528: Make safe_to_delete exit earlier on error conditions 
This patch makes the `Koha::Item->safe_to_delete` method return right
after one of the checked conditions is met. This way we avoid further DB
queries and processing.

No behavior change is expected

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Item.t
=> SUCCESS: Tests pass!
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests STILL pass!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Bug 32528: Change return logic

Back to 1 return statement
Prevent the Koha::Result::Boolean instanciation duplication

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-01-11 20:47:09 -03:00
acqui Bug 32457: Fix CGI vulnerability in addorder.pl 2022-12-14 15:07:09 -03:00
admin Bug 32348: Add library public in columns settings 2022-12-23 14:02:30 -03:00
api Bug 31160: Required fields in patron api 2022-12-13 08:44:35 -03:00
authorities Bug 30250: Use ApplyFrameworkDefaults when importing a record 2022-11-09 14:03:22 -03:00
basket Bug 31309: Remove GetItemsInfo from basket/sendbasket 2022-08-16 09:22:14 -03:00
bin
C4 Bug 32208: Adjust Auth.pm for relogin without perms 2023-01-10 18:19:55 -03:00
catalogue Bug 31543: Use query string, rather than query, to build link 2022-11-16 15:57:28 -03:00
cataloguing Bug 24606: (QA follow-up) Remove duplicate include 2022-11-11 15:47:36 -03:00
circ Bug 30963: Automatically refresh the curbside pickups list 2022-12-01 09:34:48 -03:00
clubs Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
course_reserves Bug 30409: barcodedecode() should always trim barcode 2022-06-14 07:54:58 -03:00
debian Bug 31675: Remove packages from debian/control that are no longer used 2022-12-07 14:20:54 -03:00
docs 22.11.00: Update history.txt 2022-11-25 15:20:02 -03:00
erm Bug 32030: Add missing sponsors 2022-11-09 12:25:44 -03:00
errors Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI 2022-04-20 09:03:39 -10:00
etc Bug 32030: Add Apache RewriteRule 2022-11-08 09:43:48 -03:00
ill Bug 28909: Allow illview to use backend template 2022-08-09 13:21:39 -03:00
installer Bug 32330: DBRev 22.12.00.001 2022-12-19 10:17:26 -03:00
Koha Bug 32528: Make safe_to_delete exit earlier on error conditions 2023-01-11 20:47:09 -03:00
koha-tmpl Bug 32422: Compiled CSS 2023-01-06 14:25:26 -03:00
labels Bug 31633: (follow-up) Group template params 2022-10-03 14:09:59 -03:00
lib/CGI/Session/Serialize Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
members Bug 32119: (bug 31422 follow-up) Fix add guarantee 2022-11-07 11:09:56 -03:00
misc Bug 32481: Limit prefetch size for background jobs worker 2023-01-11 20:46:01 -03:00
offline_circ Bug 30016: Remove GetOpenIssue subroutine 2022-08-31 08:50:37 -03:00
opac Bug 32445: (follow-up) Fix availability display on opac-course-details 2023-01-05 09:09:48 -03:00
patron_lists Bug 16446: Add ability to add patrons to list by borrowernumber 2021-10-21 12:24:04 +02:00
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins Bug 29787: Add plugin version to plugin search results 2022-04-08 15:49:15 +02:00
pos Bug 30619: Add email receipt to POS 2022-09-07 15:59:34 -07:00
recalls Bug 30924: Add missing branchtransfers.reason value for recall cancellation 2022-06-13 10:30:51 -03:00
reports Bug 28967: Patrons with no checkouts report shows patrons from other libraries with IndependentBranches 2022-10-17 08:10:59 -03:00
reserve Bug 24860: Add ability to select an item group when placing a hold 2022-11-04 19:39:55 -03:00
reviews Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials Bug 29608: Made so doesn't require full permission 2022-09-07 13:49:53 -07:00
services Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
skel
suggestion Bug 32531: Restore behaviour of 'include archived' filter 2023-01-05 09:22:58 -03:00
svc Bug 24860: Add hold's item group to holds table on circulation.pl and moremember.pl 2022-11-04 19:39:57 -03:00
t Bug 32349: Remove TEST_QA 2023-01-11 20:44:21 -03:00
tags Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
tmp/modified_authorities
tools Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file 2022-11-15 18:44:30 -03:00
virtualshelves Bug 28375: (follow-up) Use C4::Context->interface 2022-10-20 11:50:53 -03:00
xt Bug 32349: Remove find-nonutf8 tests 2023-01-11 20:44:26 -03:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json
.gitignore Bug 32030: Add dist dir to .gitignore 2022-11-08 09:49:57 -03:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap 22.11.00: Update .mailmap 2022-11-25 15:20:01 -03:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.stylelintrc.json Bug 31528: (follow-up) A few additional rules 2022-10-03 08:23:15 -03:00
about.pl Bug 30808: Add support for version codenames 2022-11-25 15:20:00 -03:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 12758: Make LWP::Protocol::https required module 2022-11-09 09:52:13 -03:00
cypress.json Bug 32030: Move cypress to t/ 2022-11-08 09:44:51 -03:00
fix-perl-path.PL Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
gulpfile.js Bug 32422: Hardcoded paths in _common.scss precent using external node_modules 2022-12-12 12:19:10 -03:00
help.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
INSTALL
Koha.pm Bug 32330: DBRev 22.12.00.001 2022-12-19 10:17:26 -03:00
koha_perl_deps.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 30650: Add filter_by_scheduled_today 2022-07-29 15:00:47 -03:00
Makefile.PL Bug 32030: Fix Makefile.t 2022-11-09 09:48:30 -03:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
package.json Bug 32212: (bug 32030 follow-up) Restore bootstrap 4 2022-11-17 14:49:07 -03:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 32030: Move cypress to t/ 2022-11-08 09:44:51 -03:00
yarn.lock Bug 32212: Updated yarn.lock 2022-11-18 12:04:29 -03:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo