Main Koha release repository https://koha-community.org
Find a file
Tomas Cohen Arazi e5d5fbdd3e Bug 27797: (QA follow-up) Pickup locations can be overridden too
This patch adds regression tests for overridding pickup locations, which
was inadvertedly not covered by the original dev. What this does, is
moving the $can_override variable definition above, and avoid returning
400 if conditions are not met for the passed pickup_library_id, when
$can_override is true.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-05-04 14:22:04 +02:00
acqui Bug 23971: Rename pref with AcquisitionLog 2021-04-23 11:58:49 +02:00
admin Bug 28207: Fix biblio_framework.frameworktext isn't in GROUP BY 2021-04-30 17:07:32 +02:00
api Bug 27797: (follow-up): Remove stray x-koha-override definition 2021-05-04 14:22:04 +02:00
authorities
basket Bug 27268: (QA follow-up) Add Koha::Biblios to basket scripts 2021-03-09 17:20:47 +01:00
bin
C4 Bug 17202: Don't report an item in a collection if the collection doesn't exist 2021-04-28 11:07:06 +02:00
catalogue Bug 28213: Prevent crash if patron or club deleted after search to hold 2021-04-28 11:07:06 +02:00
cataloguing
circ
clubs
course_reserves
debian
docs Bug 28244: Fix typo in Ukrainian in history 2021-04-30 17:07:31 +02:00
errors
etc
ill
installer Bug 28244: DBRev 20.12.00.044 2021-04-30 17:07:32 +02:00
Koha Bug 27797: (QA follow-up) Pickup locations can be overridden too 2021-05-04 14:22:04 +02:00
koha-tmpl Bug 27864: (QA follow-up) Select2 style on multi-holds 2021-04-30 17:19:01 +02:00
labels
members Bug 26734: Convert printfeercpt/printinvoice to use GetPreparedLetter 2021-04-27 16:23:49 +02:00
misc Bug 27819: Spurious item deletion errors from delete_records_via_leader.pl 2021-04-28 11:16:14 +02:00
offline_circ
opac
patron_lists
patroncards
plugins
pos Bug 26734: (QA follow-up) Add missing copyright statement 2021-04-27 16:23:49 +02:00
reports
reserve
reviews
rotating_collections Bug 26618: (QA follow-up) Fix unit test for TranferCollection change 2021-03-03 15:36:13 +01:00
serials
services
skel
suggestion
svc Bug 27061: Remove duplicate permission check in svc/mana/search 2021-04-30 17:07:32 +02:00
t Bug 27797: (QA follow-up) Pickup locations can be overridden too 2021-05-04 14:22:04 +02:00
tags
tmp/modified_authorities
tools Bug 21818: Replace AutoCommit flag with DBIx transaction in stage-marc-import.pl 2021-04-27 16:23:49 +02:00
virtualshelves
xt
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml
about.pl
app.psgi
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile
fix-perl-path.PL
gulpfile.js
help.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 28244: DBRev 20.12.00.044 2021-04-30 17:07:32 +02:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl
LICENSE
mainpage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Makefile.PL
MANIFEST.SKIP
package.json
README
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
rewrite-config.PL
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo