Main Koha release repository https://koha-community.org
Find a file
Olli-Antti Kivilahti 0cada7a323 Bug 11369: fix issue that can cause staff client searches to stop working
This patch fixes an issue where too many search cursor cookies overflow
the HTTP-header size after making multiple searches in the staff client.

To replicate this issue, make multiple searches in catalogue/search.pl.
50+ Should be enough to cause the HTTP-request header to overgrow.
One can verify this issue by observing the searchCookie growth in
browser's stored cookies.

-------------
- TEST PLAN -
-------------

Keep making searches.
One should never have more than 10 searchCookies. Browser might display
only 9, because for some reason the newest js-generated cookie is not
included in Firefox's cookies listing.

------------
- DRAWBACK -
------------

Removing these cookies disables the search cursor for traversing search
results (next/previous) for the removed cookie. This maybe be problematic
in some cases,
(for ex when multiple search tabs need to be open and they need to be
 traversed)
One easy solution is to grow the amount of stored searchCookies from 10 to
20, but 10 is chosen so there will be plenty of room for other cookies as
well.

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2014-05-02 23:17:04 +00:00
acqui Bug 12089: Remove use of dt_add_type_uk_date() - Acquisitions 2014-04-28 18:41:28 +00:00
admin Bug 11351: (follow-up) ensure itemtypes.sip_media_type is set to NULL when cleared 2014-04-28 18:08:58 +00:00
authorities Bug 11955: Remove spaces in empty indicators when linking an authority to a biblio record. 2014-04-18 15:50:02 +00:00
basket Bug 10605: fix encoding issue on basket email (INTRANET) 2013-12-10 04:37:12 +00:00
C4 Bug 10694: (follow-up) add unit tests, improve AddReturn POD 2014-05-02 21:46:41 +00:00
catalogue Bug 11369: fix issue that can cause staff client searches to stop working 2014-05-02 23:17:04 +00:00
cataloguing Bug 11254: make reservoir search normalize ISBNs 2014-04-19 21:44:30 +00:00
circ Bug 10694: (follow-up) display the note about restricted patrons consistently 2014-05-02 22:49:23 +00:00
course_reserves Bug 11866: (follow-up) repair security issue introduced by main patch 2014-03-10 14:57:17 +00:00
debian Bug 10942: (QA followup) make warnings to to STDERR 2014-04-24 12:50:54 +00:00
docs Bug 7143: Updating history with new developers 2014-04-14 14:37:48 +00:00
errors Housekeeping in errors scripts 2010-05-12 07:29:03 -04:00
etc Bug 9865 (follow-up) give better usage examples in example SIPconfig.xml 2014-04-30 16:34:18 +00:00
install_misc Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
installer Bug 10694: DBrev 3.15.00.042 2014-05-02 21:48:14 +00:00
Koha Bug 10694: (follow-up) fix problems with the new Borrowers plugin 2014-05-02 22:49:23 +00:00
koha-tmpl Bug 11369: fix issue that can cause staff client searches to stop working 2014-05-02 23:17:04 +00:00
labels Bug 11096: support the retrieval of large MARCXML records 2014-02-28 19:50:09 +00:00
members Bug 6273: add support for recording type of payment made via SIP2 2014-04-30 16:38:09 +00:00
misc Bug 9016: (follow-up) treat missing transports for overdue notices as warnings 2014-05-02 21:11:30 +00:00
offline_circ Bug 10240: (follow-up) don't display patrons as lost or gone-no-address incorrectly 2013-10-11 01:57:05 +00:00
opac Bug 11986: fix searching by tags in OPAC when DOM mode is in use 2014-04-28 16:17:07 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patron_lists Bug 10565: (follow-up) add new user permission for patron list management 2013-10-14 22:43:03 +00:00
patroncards Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
plugins Bug 7804 - Add Koha Plugin System - QA Followup 2 2013-03-20 14:50:19 -04:00
reports Bug 11679: Add ODS as an export format for reports 2014-04-28 19:06:41 +00:00
reserve Bug 9823: Refactor return from GetReservesFromBiblionumber 2014-01-30 16:19:55 +00:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections Bug 9605: rotating collections permissions are wrong 2013-03-30 22:11:05 -04:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Bug 12003: Do not calculate next pubdate for irregular subscriptions 2014-04-18 20:57:51 +00:00
services Bug 7178: Acquisition item creation improvement 2012-03-26 11:07:23 +02:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 10611: Use mysql_auto_reconnect instead of ping 2014-03-10 23:15:35 +00:00
suggestion Bug 10277 - Add C4::Context->IsSuperLibrarian() 2013-12-30 15:47:23 +00:00
svc Bug 12114: (QA Followup) Use JSON instead of JSON::XS 2014-04-25 15:32:06 +00:00
t Bug 10694: (follow-up) remove truncate table from test case 2014-05-02 22:00:45 +00:00
tags Bug 10730: Use DataTables on the tag review page 2013-09-25 16:47:59 +00:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools Bug 9016: (QA Follow-up) Remove warning from content.length test 2014-05-02 20:29:18 +00:00
virtualshelves Bug 11248: fix encoding issue on emailing a list (INTRANET) 2014-04-20 16:16:03 +00:00
xt Bug 12076: better detect an untranslatable template construct 2014-04-12 17:57:35 +00:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap 7439 Mailmap for master 2012-01-27 12:27:58 +01:00
about.pl Bug 11596: report warnings on the about patch if indexing options in koha-conf.xml are missing 2014-04-20 17:07:04 +00:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl Bug 11661: sanitize file names supplied to edithelp.pl 2014-02-05 01:36:10 +00:00
fix-perl-path.PL installer: improvements to fix-path-perl.PL on Win32 2007-12-20 19:20:12 -06:00
help.pl Bug 11238: contruct links to the appropriate manual version dynamically 2013-11-23 19:30:16 +00:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.opensuse Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl Bug 10694: DBrev 3.15.00.042 2014-05-02 21:48:14 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 7567 - Use, display, filter News by library 2014-04-07 18:14:19 +00:00
Makefile.PL Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 10580: adjust Makefile.PL to reflect that Zebra no longer optional in Koha setup 2014-02-21 17:38:15 +00:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/