Main Koha release repository https://koha-community.org
Find a file
Alex Buckley 195531c038 Bug 21249: New syspref controlling branch fields queried against selected library group value in advanced search
This commit allows librarians to choose whether they want to query the
homebranch, holdingbranch or homebranch AND holdingbranch when they set
a library or library group search condition in the staff client and OPAC
advanced searches.

Test plan:
1. Apply patches, update database, restart services
2. Set up a record with one item. Edit the item so that:
home branch = Branch A
holding/current branch = Branch B.
Note the barcode of your item.
3. Go to Administration -> Library Groups. Create a library group that
only contains Branch A.

= homebranch and holdingbranch =

4. Go to Administration -> System preferences and find the new
SearchLimitLibrary syspref. Confirm it is set to 'homebranch and
holdingbranch' by default. Keep this tab open.
5. Go to Advanced Search in the staff client in another tab. Under 'location and
availability', select your library group from the dropdown. Under
'search for', select the barcode option and enter your item's barcode.
6. Submit the search and confirm you are taken to your item as expected.
7. Go back to Advanced Search. Under 'location and availability', select
Branch A from the individual libraries dropdown. Under 'search for',
select the barcode option and enter your item's barcode.
8. Submit the search and confirm you are taken to your item as expected.
9. Go back to Advanced Search. Under 'location and availability', select
Branch B from the individual libraries dropdown. Under 'search for',
select the barcode option and enter your item's barcode.
10. Submit the search and confirm you are taken to your item as expected.

= homebranch only =

11. Go back to your System preferences tab. Set the SearchLimitLibrary
syspref to 'homebranch'. keep this tab open.
12. Go to Advanced Search in the staff client in another tab. Under 'location and
availability', select your library group from the dropdown. Under
'search for', select the barcode option and enter your item's barcode.
13. Submit the search and confirm you are taken to your item as expected,
because the syspref is set to homebranch and the library group contains our item's
homebranch.
14. Go back to Advanced Search. Under 'location and availability', select
Branch A from the individual libraries dropdown. Under 'search for',
select the barcode option and enter your item's barcode.
15. Submit the search and confirm you are taken to your item as expected.
16. Go back to Advanced Search. Under 'location and availability', select
Branch B from the individual libraries dropdown. Under 'search for',
select the barcode option and enter your item's barcode.
17. Submit the search and confirm you are NOT taken to your item and your item
does not show in the search results.

= holdingbranch only =

18. Go back to your System preferences tab. Set the SearchLimitLibrary
syspref to 'holdingbranch'. keep this tab open.
19. Go to Advanced Search in the staff client in another tab. Under 'location and
availability', select your library group from the dropdown. Under
'search for', select the barcode option and enter your item's barcode.
20. Submit the search and confirm you are NOT taken to your item and your
item does not show in the search results, because the syspref is set to
holdingbranch and the library group does not contain our item's holdingbranch.
21. Go back to Advanced Search. Under 'location and availability', select
Branch B from the individual libraries dropdown. Under 'search for',
select the barcode option and enter your item's barcode.
22. Submit the search and confirm you are taken to your item as expected.
23. Go back to Advanced Search. Under 'location and availability', select
Branch A from the individual libraries dropdown. Under 'search for',
select the barcode option and enter your item's barcode.
24. Submit the search and confirm you are NOT taken to your item and your item
does not show in the search results.

25. Repeat the above test plan but do your searching with the OPAC
advanced search.

Sponsored-By: Brimbank Library

Signed-off-by: Amandine Zocca <azocca@ville-montauban.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: David Cook <dcook@prosentient.com.au>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-05-06 15:52:43 +02:00
acqui Bug 23971: Rename pref with AcquisitionLog 2021-04-23 11:58:49 +02:00
admin Bug 28207: Fix biblio_framework.frameworktext isn't in GROUP BY 2021-04-30 17:07:32 +02:00
api Bug 28254: Make PUT /holds/:hold_id/pickup_location honour x-koha-override 2021-05-04 14:22:08 +02:00
authorities Bug 8976: Sort subfields for authority records 2021-03-01 15:14:22 +01:00
basket Bug 27268: (QA follow-up) Add Koha::Biblios to basket scripts 2021-03-09 17:20:47 +01:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
C4 Bug 27577: Autolink biblio after biblionumber is generated 2021-05-06 15:52:38 +02:00
catalogue Bug 21249: New syspref controlling branch fields queried against selected library group value in advanced search 2021-05-06 15:52:43 +02:00
cataloguing Bug 27739: Advanced editor should use DefaultCountryField008 preference 2021-04-16 12:28:17 +02:00
circ Bug 27896: Remove DeleteTransfer from circ/return.pl 2021-04-23 11:58:49 +02:00
clubs Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
course_reserves Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
debian Bug 23207: (QA follow-up) Add to cron files 2021-04-22 11:11:05 +02:00
docs Bug 28244: Fix typo in Ukrainian in history 2021-04-30 17:07:31 +02:00
errors Bug 26048: Use ErrorDocument middleware for Plack HTTP errors 2021-01-27 10:30:43 +01:00
etc Bug 14300: Add %P to SIP LogPattern 2021-04-21 15:25:07 +02:00
ill Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
installer Bug 21249: New syspref controlling branch fields queried against selected library group value in advanced search 2021-05-06 15:52:43 +02:00
Koha Bug 28254: (QA follow-up) override -> force 2021-05-04 14:22:08 +02:00
koha-tmpl Bug 21249: New syspref controlling branch fields queried against selected library group value in advanced search 2021-05-06 15:52:43 +02:00
labels Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
members Bug 26734: Convert printfeercpt/printinvoice to use GetPreparedLetter 2021-04-27 16:23:49 +02:00
misc Bug 27819: Spurious item deletion errors from delete_records_via_leader.pl 2021-04-28 11:16:14 +02:00
offline_circ Bug 24083: Add support for unseen_renewals 2020-11-11 16:09:58 +01:00
opac Bug 21249: New syspref controlling branch fields queried against selected library group value in advanced search 2021-05-06 15:52:43 +02:00
patron_lists Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
patroncards Bug 23271: Replace search_limited with search_with_library_limits 2021-04-21 15:25:07 +02:00
plugins Bug 24633: Add support for gitlab searching of plugins 2020-11-06 15:55:17 +01:00
pos Bug 26734: (QA follow-up) Add missing copyright statement 2021-04-27 16:23:49 +02:00
reports Bug 16486: Display the timestamp when an accountline is updated 2021-05-06 15:52:41 +02:00
reserve Bug 16787: (follow-up) Fix check to ensure reasons are passed to template 2021-04-22 14:50:11 +02:00
reviews Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
rotating_collections Bug 26618: (QA follow-up) Fix unit test for TranferCollection change 2021-03-03 15:36:13 +01:00
serials Bug 23243: Adjust previous patch 2021-04-21 15:25:07 +02:00
services Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-01 11:16:42 +01:00
svc Bug 27061: Remove duplicate permission check in svc/mana/search 2021-04-30 17:07:32 +02:00
t Bug 27577: Unit test 2021-05-06 15:52:38 +02:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
tmp/modified_authorities
tools Bug 21818: Replace AutoCommit flag with DBIx transaction in stage-marc-import.pl 2021-04-27 16:23:49 +02:00
virtualshelves Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
xt Bug 27673: Replace YAML with YAML::XS 2021-02-16 14:54:50 +01:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Bug 26621: Adjust .mailmap to reduce the number of invalid authors 2020-10-15 12:56:30 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 28125: Display a warning on the about page for OPACHiddenItems is needed 2021-04-16 12:28:17 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28110: Require YAML::XS 0.67 2021-04-14 15:28:12 +02:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js Bug 27072: Don't process staff interface CSS with rtlcss 2020-11-24 21:27:59 +01:00
help.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 28244: DBRev 20.12.00.044 2021-04-30 17:07:32 +02:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
LICENSE
mainpage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Makefile.PL Bug 26363: Provide a systemd unit file for koha-worker for source installs 2021-03-01 10:51:15 +01:00
MANIFEST.SKIP
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
rewrite-config.PL Bug 20410: Remove OpacGroupResults and PazPar2 2021-02-08 16:12:42 +01:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo