Main Koha release repository https://koha-community.org
Find a file
Joonas Kylmälä 30fac5c75a Bug 27064: (QA follow-up) Add error message only if we have one defined
This moves the DestinationEqualsHolding error message addition to if
clause so the value is added to %err hash only when there is actually
an error. Then we only append to the @errmsgloop array the error
message if one was defined.

To test:
 1) Create a hold request to a pickup library where the item currently
 is not
 2) Add transfer to the pickup library using branchtransfers.pl and
 notice without this patch we get and empty message box but with this
 patch we don't get it.

Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-06-18 07:11:56 -04:00
acqui Bug 23971: Rename pref with AcquisitionLog 2021-04-23 11:58:49 +02:00
admin Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
api Bug 28463: Add summary to all routes 2021-05-27 17:17:19 +02:00
authorities Bug 28160: Values from 150$a aren't prefilled in z39.50 search form from an existing authority record 2021-05-10 15:52:53 +02:00
basket Bug 27268: (QA follow-up) Add Koha::Biblios to basket scripts 2021-03-09 17:20:47 +01:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
C4 Bug 27064: (QA follow-up) Do not create transfer prior to accepting it 2021-06-18 07:11:45 -04:00
catalogue Bug 28171: Revert "Bug 27980: Remove itemdata_publisheddate from controller" 2021-06-18 06:49:38 -04:00
cataloguing Bug 27739: Advanced editor should use DefaultCountryField008 preference 2021-04-16 12:28:17 +02:00
circ Bug 27064: (QA follow-up) Add error message only if we have one defined 2021-06-18 07:11:56 -04:00
clubs Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
course_reserves Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
debian Bug 28364: Make log4perl.conf belong to the instance user 2021-05-27 17:17:30 +02:00
docs 21.05.00 - Update history.txt 2021-05-28 08:47:22 +02:00
errors Bug 26048: Use ErrorDocument middleware for Plack HTTP errors 2021-01-27 10:30:43 +01:00
etc Bug 14300: Add %P to SIP LogPattern 2021-04-21 15:25:07 +02:00
ill Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
installer Koha 21.05.00 is here! 2021-05-28 14:45:37 +02:00
Koha Bug 27064: (QA follow-up) Pass 'replace' through to Koha::Item::Transfer->cancel 2021-06-18 07:11:51 -04:00
koha-tmpl Bug 27064: (QA follow-up) Do not create transfer prior to accepting it 2021-06-18 07:11:45 -04:00
labels Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
members Bug 18112: Use GetAuthValueDropbox from the template 2021-05-11 15:37:42 +02:00
misc Add release notes for Koha 21.05.00 2021-05-28 14:45:29 +02:00
offline_circ Bug 24083: Add support for unseen_renewals 2020-11-11 16:09:58 +01:00
opac Bug 20982: Sanitize category to prevent XSS on opac-shelves.pl 2021-05-26 09:26:54 +02:00
patron_lists Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
patroncards Bug 23271: Replace search_limited with search_with_library_limits 2021-04-21 15:25:07 +02:00
plugins Bug 24633: Add support for gitlab searching of plugins 2020-11-06 15:55:17 +01:00
pos Bug 28368: Add fallback language for anonymous payment receipts 2021-05-27 14:12:24 +02:00
reports Bug 16486: Display the timestamp when an accountline is updated 2021-05-06 15:52:41 +02:00
reserve Bug 28273: Multi-hold should not offer invalid pickup locations 2021-05-20 08:43:34 +02:00
reviews Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
rotating_collections Bug 26618: (QA follow-up) Fix unit test for TranferCollection change 2021-03-03 15:36:13 +01:00
serials Bug 23243: Adjust previous patch 2021-04-21 15:25:07 +02:00
services Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
skel
suggestion Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-01 11:16:42 +01:00
svc Bug 27061: Remove duplicate permission check in svc/mana/search 2021-04-30 17:07:32 +02:00
t Bug 27064: (QA follow-up) Pass 'replace' through to Koha::Item::Transfer->cancel 2021-06-18 07:11:51 -04:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
tmp/modified_authorities
tools Bug 28353: Display a list of items that cannot be deleted 2021-06-18 06:48:28 -04:00
virtualshelves Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
xt Bug 28370: Rewrite tests 2021-05-25 09:28:18 +02:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json
.gitignore
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Bug 28386: Disambiguate Tomas and Blou 2021-05-26 12:30:59 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml
about.pl Bug 28386: Sort authors by lastname || firstname 2021-05-27 15:07:36 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28317: Use the default CGI::Session serializer 2021-05-19 14:45:32 +02:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js Bug 27072: Don't process staff interface CSS with rtlcss 2020-11-24 21:27:59 +01:00
help.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Koha 21.05.00 is here! 2021-05-28 14:45:37 +02:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
LICENSE
mainpage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Makefile.PL Bug 26363: Provide a systemd unit file for koha-worker for source installs 2021-03-01 10:51:15 +01:00
MANIFEST.SKIP
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
README
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
rewrite-config.PL Bug 20410: Remove OpacGroupResults and PazPar2 2021-02-08 16:12:42 +01:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo