Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
42443 commits 35 branches 616 tags 1.8 GiB
Perl 45.6%
JavaScript 39.3%
HTML 7.2%
XSLT 3.7%
Vue 1.4%
Other 2.3%
Find a file
Jonathan Druart 5faddae26f Bug 28524: Escape 'rank' in cat_issues_top.pl 
It's a MySQL 8 keyword

Test plan:
Turn off strict_sql_modes (there are other problems in this script)
Hit Home Reports > Most-circulated items
Submit the form

Without this patch you got:
  You have an error in your SQL syntax; check the manual that
  corresponds to your MySQL server version for the right syntax to use
  near 'RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM,
  ccode as CCODE, loca' at line 1

With this patch applied you see the report result view

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-07-06 10:12:58 +02:00
acqui Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
admin Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
api Bug 28480: Add q parameters for GET /patrons 2021-06-23 15:09:55 +02:00
authorities Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
basket Bug 27268: (QA follow-up) Add Koha::Biblios to basket scripts 2021-03-09 17:20:47 +01:00
bin
C4 Bug 28571: Remove C4::Auth::_session_log 2021-06-24 11:53:44 +02:00
catalogue Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
cataloguing Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
circ Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
clubs Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
course_reserves Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
debian Bug 27348: Fix test on ALTERNATE_INDEXER_DAEMON in koha-indexer 2021-06-21 12:07:28 +02:00
docs Bug 28476: Update info in docs/teams.yaml file 2021-06-21 12:07:28 +02:00
errors Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
etc Bug 8280: Add koha set and item fields to pqf.properties 2021-06-21 14:01:50 +02:00
ill Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
installer Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
Koha Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
koha-tmpl Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
labels Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
lib/CGI/Session/Serialize Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
members Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
misc Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
offline_circ Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
opac Bug 28409: Simplify data validation 2021-07-06 10:12:54 +02:00
patron_lists Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
patroncards Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
plugins Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
pos Bug 28514: Remove getletter 2021-06-21 13:49:58 +02:00
reports Bug 28524: Escape 'rank' in cat_issues_top.pl 2021-07-06 10:12:58 +02:00
reserve Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
reviews Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
rotating_collections Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
serials Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
services Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
skel
suggestion Bug 28581: Use 'from_email_address' where appropriate 2021-06-23 15:09:55 +02:00
svc Bug 28271: Preselect the current item lost value 2021-06-21 10:50:09 +02:00
t Bug 28409: Adjust regression test 2021-07-06 10:12:54 +02:00
tags Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
tmp/modified_authorities
tools Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
virtualshelves Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
xt Bug 28370: Rewrite tests 2021-05-25 09:28:18 +02:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap Bug 28386: Disambiguate Tomas and Blou 2021-05-26 12:30:59 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml
about.pl Bug 28591: Don't pass debug to get_template_and_user 2021-06-22 12:04:32 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28317: Use the default CGI::Session serializer 2021-05-19 14:45:32 +02:00
fix-perl-path.PL Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
gulpfile.js Bug 27072: Don't process staff interface CSS with rtlcss 2020-11-24 21:27:59 +01:00
help.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 26205: DBRev 21.06.00.005 2021-06-23 15:09:55 +02:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Makefile.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
MANIFEST.SKIP
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
README
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo