Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/Koha
History
Tomas Cohen Arazi 6870273c65 Bug 29139: Only pass the offsets for lines the credit was applied to 
On writing the regression tests, I noticed the CREATE offset was added
to the template. The idea behind passing the offsets is that we can
print information about the lines that got the credit applied. Having
the CREATE offset is meaningless, and (worse) would require users to add
logic to skip it. And all the payment information is already passed in
the 'credit' variable anyway.

This patch filters the credit_offsets by type, leaving the APPLY ones
only.

To test:
1. Apply up to the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Account.t
=> FAIL: 3 offsets, including the CREATE one, boo!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! Only the two APPLY offsets are returned!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-10-08 09:51:58 -04:00
..
Account Bug 29139: Add exceptions to relation accessors 2021-10-08 09:51:58 -04:00
Acquisition Bug 23971: Rename pref with AcquisitionLog 2021-04-23 11:58:49 +02:00
App Bug 20582: Reset CGI::PARAM_UTF8 to 1 before each CGI request 2020-10-06 14:34:17 +02:00
ArticleRequest
Authority
BackgroundJob Bug 22417: Remove $dbh in Koha::BackgroundJob::* 2020-10-05 15:23:08 +02:00
Biblio Bug 26171: Show biblionumber in Koha::Exceptions::Metadata::Invalid 2021-01-04 13:29:50 +01:00
BiblioUtils
Cache
Cash Bug 26274: (QA follow-up) Fix the order of summary groups 2021-02-17 16:21:22 +01:00
Charges Bug 23830: Adapt callers 2021-02-08 17:09:34 +01:00
Checkouts Bug 27004: Prevent claim resolution to fail 2021-01-04 13:29:47 +01:00
Club Bug 28272: Fix many things... 2021-05-11 09:04:13 +02:00
Config Bug 27154: Remove Koha::Util::SystemPreferences 2021-02-08 14:56:00 +01:00
Course Bug 23727: Editing course reserve items is broken 2020-04-17 13:45:56 +01:00
Edifact Bug 27793: Store FTX free text in vendor note 2021-05-07 14:44:00 +02:00
Exceptions Bug 26312: (follow-up) Fix passing of exception messages 2021-04-16 11:48:31 +02:00
Exporter
ExternalContent Bug 25527: Add logger to Koha::ExternalContent 2020-05-18 15:25:03 +01:00
Filter/MARC Bug 23583: Handle OpacHiddenItems with yaml_preference 2021-04-21 15:25:07 +02:00
Illrequest Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
Indexer
Item Bug 28520: Revert "Bug 12362: Reverse transfer upon cancellation" 2021-06-18 10:46:41 -04:00
Library
List
MetadataRecord Bug 28268: Improve memory usage when indexing authorities in Elasticsearch 2021-05-17 12:34:33 +02:00
Middleware Bug 25950: Remove <client> in X-Forwarded-For from proxy tests 2020-07-20 12:37:29 +02:00
Misc
Notice
Number Bug 26239: Do not format large negative numbers 2020-08-19 08:22:02 +02:00
OAI/Server Bug 26195: Add a way to specify authorised values should be expanded [OAI] 2021-09-03 11:17:51 -04:00
Object Bug 26555: (QA follow-up) Add a 'payload' attribute for carrying useful things 2020-10-15 14:50:06 +02:00
Objects Bug 23271: Prevent crash if called without parameters 2021-04-21 15:25:07 +02:00
Old Bug 28272: Fix note_seen, desk_id, cancellation_reason 2021-05-10 17:55:30 +02:00
Patron Bug 28581: Use from_email_address in the codebase 2021-07-09 09:05:48 -04:00
Patrons Bug 28616: (bug 28220 follow-up) Replace Data::Printer with simple warn 2021-06-23 09:29:49 -04:00
pdfformat Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Plugins Bug 28228: Supress plugin related error message 2021-10-01 13:44:19 -04:00
RecordProcessor
REST Bug 29032: Pre-load ILL backends to speed up response 2021-10-01 14:25:57 -04:00
Schema Bug 28813: DBIC Schema Update 2021-08-13 07:39:39 -04:00
SearchEngine Bug 28826: Add FacetOrder system preference 2021-10-08 09:30:31 -04:00
Serial
Sitemapper Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
SMS
SMTP Bug 26595: Remove password from the smtp_server API object 2020-10-14 15:53:38 +02:00
Subscription
SuggestionEngine Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Tags
Template/Plugin Bug 24154: (follow-up) Make parameter and variable more explicit, add tests 2021-05-10 10:27:53 +02:00
Util Bug 27461: Move hardcoded value to module 2021-10-08 07:57:55 -04:00
XSLT
Z3950Responder Bug 27673: Replace YAML with YAML::XS 2021-02-16 14:54:50 +01:00
Account.pm Bug 29139: Only pass the offsets for lines the credit was applied to 2021-10-08 09:51:58 -04:00
ActionLog.pm
ActionLogs.pm
AdditionalField.pm
AdditionalFields.pm
AdditionalFieldValue.pm
AdditionalFieldValues.pm
AdvancedEditorMacro.pm Bug 17268: (follow-up) Fix translatability 2020-05-04 08:26:22 +01:00
AdvancedEditorMacros.pm Bug 17268: (follow-up) Fix translatability 2020-05-04 08:26:22 +01:00
ApiKey.pm Bug 28772: Make validate_secret return 1|0 2021-09-15 10:47:12 -04:00
ApiKeys.pm
ArticleRequest.pm Bug 28582: Fix hashref in a warning message 2021-07-02 09:07:56 -04:00
ArticleRequests.pm
AudioAlert.pm
AudioAlerts.pm
AuthorisedValue.pm
AuthorisedValueCategories.pm Bug 17355: (QA follow-up) Fix used package name 2020-05-07 19:10:29 -03:00
AuthorisedValueCategory.pm Bug 17355: (QA follow-up) Fix used package name 2020-05-07 19:10:29 -03:00
AuthorisedValues.pm Bug 28554: In Koha::AuthorisedValues sort by description 2021-09-03 10:47:08 -04:00
Authorities.pm
Authority.pm
AuthUtils.pm Bug 28772: Add a warning about hash_password usage in updatedatabase.pl 2021-09-15 10:47:11 -04:00
BackgroundJob.pm Bug 26742: Remove die from connect 2021-03-05 12:27:22 +01:00
BackgroundJobs.pm Bug 22417: Add missing POD and html filters 2020-10-05 15:23:08 +02:00
Biblio.pm Bug 18989: (QA follow-up) Make Koha::Biblio->hidden_in_opac aware of OpacHiddenItemsHidesRecord 2021-05-12 14:12:07 +02:00
BiblioFramework.pm
BiblioFrameworks.pm
Biblioitem.pm
Biblioitems.pm
Biblios.pm Bug 28273: Add Koha::Biblios->pickup_locations 2021-05-20 08:43:34 +02:00
BiblioUtils.pm Bug 26180: Add descending option to rebuild_elasticsearch.pl 2020-11-04 12:59:33 +01:00
Cache.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
Caches.pm
Calendar.pm Bug 25802: Change addDate to addDuration 2021-01-22 14:59:27 +01:00
Checkout.pm Bug 28272: Fix note_seen, desk_id, cancellation_reason 2021-05-10 17:55:30 +02:00
Checkouts.pm Bug 23207: Automatic checkin items should never be overdue 2021-04-22 14:37:14 +02:00
CirculationRule.pm
CirculationRules.pm Bug 28774: Don't store blank values for rental discount 2021-09-03 11:15:53 -04:00
Cities.pm
City.pm
ClassSortRule.pm
ClassSortRules.pm
ClassSource.pm
ClassSources.pm
ClassSplitRule.pm
ClassSplitRules.pm
Club.pm
Clubs.pm
Config.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
Course.pm Bug 23727: Add Koha Object(s) related to course reserves 2020-04-17 13:45:51 +01:00
Courses.pm Bug 23727: Add Koha Object(s) related to course reserves 2020-04-17 13:45:51 +01:00
CoverImage.pm Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages 2020-10-12 11:28:41 +02:00
CoverImages.pm Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages 2020-10-12 11:28:41 +02:00
CsvProfile.pm
CsvProfiles.pm
Database.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
DateUtils.pm Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0 2020-05-29 11:30:02 +02:00
Desk.pm Bug 13881: Add desk management 2020-03-25 09:19:15 +00:00
Desks.pm Bug 13881: Add desk management 2020-03-25 09:19:15 +00:00
EDI.pm Bug 28960: Explicitly call get_column 2021-10-01 13:29:31 -04:00
Edifact.pm
Email.pm Bug 28017: Allow non-FQDN (@localhost) addresses 2021-04-01 18:51:37 +02:00
Exceptions.pm Bug 26518: Raise exception if the insert failed 2020-11-25 15:18:17 +01:00
ExternalContent.pm Bug 25527: Add logger to Koha::ExternalContent 2020-05-18 15:25:03 +01:00
FrameworkPlugin.pm
Hold.pm Bug 28520: Revert "Bug 12362: Cancel transfer with hold cancelation" 2021-06-18 10:46:41 -04:00
Holds.pm Bug 27069: Adapt uses of holdallowed 2021-04-07 16:08:04 +02:00
I18N.pm Bug 25517: Look in all possible places for MO files 2020-05-23 08:31:21 +01:00
Illcomment.pm
Illcomments.pm
Illrequest.pm Bug 28581: Use 'from_email_address' where appropriate 2021-07-09 09:05:48 -04:00
Illrequestattribute.pm
Illrequestattributes.pm
Illrequests.pm
ImportBatch.pm Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages 2020-11-11 15:55:49 +01:00
ImportBatches.pm Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages 2020-11-11 15:55:49 +01:00
ImportBatchProfile.pm Bug 23019: (follow-up) Fix other things 2020-11-11 15:55:49 +01:00
ImportBatchProfiles.pm Bug 23019: (follow-up) Fix other things 2020-11-11 15:55:49 +01:00
Item.pm Bug 28520: Revert "Bug 12362: (QA follow-up) Fix ModItemTransfer cancellation handling" 2021-06-18 10:46:41 -04:00
Items.pm Bug 28286: Replace < 1 with <= 0 2021-05-10 15:46:55 +02:00
ItemType.pm Bug 21946: Display parent-child relationship on smart-rules.pl 2020-08-13 10:13:14 +02:00
ItemTypes.pm
KeyboardShortcut.pm
KeyboardShortcuts.pm
Libraries.pm Bug 24368: Remove Koha::Libraries->pickup_locations 2020-05-13 10:30:41 +01:00
Library.pm Bug 28581: Add 'from_email_address' method and use in Koha::Patron 2021-07-09 09:05:48 -04:00
Linktracker.pm
Localization.pm
Localizations.pm
Logger.pm Bug 25172: Remove _recheck_logfile 2020-04-22 13:43:58 +01:00
Manual.pm Bug 26944: Point help link to automatic item mod in manual 2020-11-18 12:03:03 +01:00
MarcSubfieldStructure.pm Bug 8976: (QA follow-up) Trivial POD fixes 2021-03-01 15:14:22 +01:00
MarcSubfieldStructures.pm Bug 8976: (QA follow-up) Trivial POD fixes 2021-03-01 15:14:22 +01:00
MessageAttribute.pm Bug 22818: (QA follow-up) Licence and POD fixes 2020-11-11 08:35:10 +01:00
MessageAttributes.pm Bug 22818: Fix TestBuilder.t 2020-11-11 18:03:17 +01:00
MetadataIterator.pm
MetadataRecord.pm
MetaSearcher.pm Bug 17515: Order Z3950 server by rank and preserve ordering 2020-11-02 11:03:09 +01:00
MoreUtils.pm
News.pm
NewsItem.pm Bug 27714: Prevent Koha::NewsItem->author to explode 2021-02-23 13:12:56 +01:00
OAuth.pm Bug 28772: Make secret validation use the new method 2021-09-15 10:47:11 -04:00
OAuthAccessToken.pm
OAuthAccessTokens.pm
Object.pm Bug 28744: Better handling of undefined to_api_mapping 2021-09-03 10:52:47 -04:00
Objects.pm Bug 21549: Make filter_by_last_update returns a Koha::Objects-based object 2021-04-14 15:34:27 +02:00
Patron.pm Bug 28581: Add 'from_email_address' method and use in Koha::Patron 2021-07-09 09:05:48 -04:00
Patrons.pm Bug 21549: Rename filter_by_dateexpiry with filter_by_expiration_date 2021-04-14 15:34:27 +02:00
Plugins.pm Bug 25549: Add error reporting to plugins-home 2020-10-22 10:04:30 +02:00
ProblemReport.pm Bug 4461: Update license statements 2020-04-06 11:18:39 +01:00
ProblemReports.pm Bug 4461: Update license statements 2020-04-06 11:18:39 +01:00
PseudonymizedTransaction.pm Bug 24151: Rename the config key with 'bcrypt_settings' 2020-07-20 15:17:42 +02:00
PseudonymizedTransactions.pm Bug 24151: (QA follow-up) Fix POD warnings from QA tools 2020-07-20 15:17:42 +02:00
Quote.pm Bug 27251: Rewrite QOTD with the Koha REST API 2021-01-29 09:03:45 +01:00
Quotes.pm Bug 16371: Fix inconsistencies with timestamp 2020-08-13 10:15:34 +02:00
Rating.pm
Ratings.pm
RDF.pm
RecordProcessor.pm Bug 25008: Overload Koha::RecordProcessor->options to update filters 2020-04-14 08:31:37 +01:00
Report.pm Bug 24695: (QA follow-up) Fix POD 2021-04-12 15:27:50 +02:00
Reports.pm Bug 24695: Move to Koha::Report->is_sql_valid 2021-04-12 15:27:50 +02:00
Review.pm
Reviews.pm
Schema.pm
Script.pm Bug 23571: (QA follow-up) Remove perlcritic warning 2020-04-14 17:24:35 +01:00
SearchEngine.pm Bug 24000: Some modules do not return 1 2021-04-06 15:56:30 +02:00
SearchField.pm
SearchFields.pm
SearchMarcMap.pm
SearchMarcMaps.pm
Serial.pm
Serials.pm
SharedContent.pm
SimpleMARC.pm Bug 26894: Handle subfield 0 and delete empty fields 2021-01-12 16:02:35 +01:00
Sitemapper.pm
Statistic.pm
Statistics.pm
StockRotationItem.pm Bug 22569: Add a 'Transfers to send' report 2021-03-11 11:51:40 +01:00
StockRotationItems.pm
StockRotationRota.pm
StockRotationRotas.pm
StockRotationStage.pm
StockRotationStages.pm
Subscription.pm
Subscriptions.pm
Suggestion.pm Bug 23591: Add some useful methods to Koha::Suggestions 2020-04-14 16:36:13 +01:00
SuggestionEngine.pm
Suggestions.pm
Tag.pm
Tags.pm
Token.pm
UploadedFile.pm Bug 28123: Quote filename value in Content-Disposition header 2021-04-16 12:28:18 +02:00
UploadedFiles.pm
Uploader.pm
Virtualshelf.pm
Virtualshelfcontent.pm
Virtualshelfcontents.pm
Virtualshelfshare.pm
Virtualshelfshares.pm
Virtualshelves.pm
Z3950Responder.pm Bug 25292: Flushing L1 on every Z3950 server search 2021-01-11 10:27:37 +01:00
Z3950Server.pm
Z3950Servers.pm