Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
43534 commits 35 branches 616 tags 1.8 GiB
Perl 45.6%
JavaScript 39.3%
HTML 7.2%
XSLT 3.7%
Vue 1.4%
Other 2.3%
Find a file
Joonas Kylmälä ae84b13e48 Bug 14999: Make sure order prices are not mixed-up 
We were shifting the price and replacement price for imported orders
only after the line:

> $duplinbatch = $import_batch_id and next if $duplifound;

This lead to the "replacementprice" and "price" query parameters not
being shifted/removed from the list if a duplicate record came across
and caused the prices be applied to the next record being imported.

To reproduce:
 1) Download two records from koha to marcxml file, then cat those:
   cat bib1.marcxml bib2.marcxml > bibs.marcxml
 2) Delete bib2 from koha
 3) Stage bibs.marcxml for import
 4) Create a new order basket, then "Add to basket" using "From a
    staged file" option
 5) Select both bib1 and bib2 and set price & replacement price for
    bib1 to be 99.00 and for bib2 to be 88.00
 6) Click save and notice bib2 was imported with the wrong prices, 99.00!
 7) Apply patch and notice the prices are now correctly set to 88.00.

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-11-02 14:57:06 +01:00
acqui Bug 14999: Make sure order prices are not mixed-up 2021-11-02 14:57:06 +01:00
admin Bug 28859: Fix missing column setting 2021-10-28 17:32:34 +02:00
api Bug 29290: Add spec changes 2021-10-28 17:32:34 +02:00
authorities Bug 28785: Adjust check_cookie_auth calls 2021-10-18 11:28:41 +02:00
basket Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
bin
C4 Bug 29374: Don't crash if search engine returns a deleted record 2021-10-29 15:46:17 +02:00
catalogue Bug 28959: (QA follow-up) One more lost 'category' to 'public' change 2021-11-02 14:27:12 +01:00
cataloguing Bug 27526: Fix for prefill preventing duplication 2 2021-10-28 10:54:42 +02:00
circ Bug 28211: Replace use of call_recursive() with call() 2021-10-18 11:28:41 +02:00
clubs Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
course_reserves Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
debian Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
docs Bug 29300: Add 22.05 release team to teams.yaml 2021-10-28 12:21:23 +02:00
errors Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
etc Bug 20463: (follow-up) Configure short name mrl for Multipart-resource-level index 2021-10-25 14:08:06 +02:00
ill Bug 22614: Migrate original request 2021-09-21 20:22:57 +02:00
installer Bug 28959: DBRev 21.06.00.039 2021-10-28 17:47:46 +02:00
Koha Bug 28959: DBIC update 2021-10-28 17:47:47 +02:00
koha-tmpl Bug 24370: (QA follow-up) Make new suggestions default to the library you re viewing 2021-11-02 14:57:04 +01:00
labels Bug 17600: Fix POSIX imports 2021-07-29 14:37:26 +02:00
lib/CGI/Session/Serialize Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
members Bug 28211: Replace use of call_recursive() with call() 2021-10-18 11:28:41 +02:00
misc Bug 14957: (QA follow-up) Clarify 'context' param 2021-10-26 16:46:02 +02:00
offline_circ Bug 28785: Adjust check_cookie_auth calls 2021-10-18 11:28:41 +02:00
opac Bug 28959: Fix other cases 2021-10-28 17:47:38 +02:00
patron_lists Bug 16446: Add ability to add patrons to list by borrowernumber 2021-10-21 12:24:04 +02:00
patroncards Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
plugins Bug 28785: Adjust check_cookie_auth calls 2021-10-18 11:28:41 +02:00
pos Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
reports Bug 17600: Fix imports for GetClassSources in guided_reports.pl 2021-11-02 14:27:48 +01:00
reserve Bug 29116: Use a pre-existing accessor instead of reimplementing it 2021-10-12 11:15:32 +02:00
reviews Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials Bug 28785: Adjust check_cookie_auth calls 2021-10-18 11:28:41 +02:00
services Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
skel
suggestion Bug 24370: Allow resetting library to ANY 2021-11-02 14:57:04 +01:00
svc Bug 28959: Add virtualshelves.public as a boolean 2021-10-28 17:47:38 +02:00
t Bug 29368: Fix remove_from_cart 2021-10-29 15:46:17 +02:00
tags Bug 28785: Adjust check_cookie_auth calls 2021-10-18 11:28:41 +02:00
tmp/modified_authorities
tools Bug 28959: Fix occurrence in tools/batch_record_modification.pl 2021-11-02 14:27:12 +01:00
virtualshelves Bug 28959: Fix other cases 2021-10-28 17:47:38 +02:00
xt Bug 27622: Fix sample_notices.t 2021-10-07 15:49:01 +02:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Bug 28386: Disambiguate Tomas and Blou 2021-05-26 12:30:59 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.scss-lint.yml
about.pl Bug 28870: Move email address validation to a specific class method 2021-09-28 10:22:36 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28870: Remove traces of Email::Valid 2021-09-28 10:22:35 +02:00
fix-perl-path.PL Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
gulpfile.js Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
help.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 28959: DBRev 21.06.00.039 2021-10-28 17:47:46 +02:00
koha_perl_deps.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl
LICENSE
mainpage.pl Bug 29020: Add link on the mainpage for users without admin access 2021-10-19 09:29:09 +02:00
Makefile.PL Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
MANIFEST.SKIP
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
README
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo