Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
45944 commits 35 branches 612 tags 1.8 GiB
Perl 45.3%
JavaScript 39.4%
HTML 7.2%
XSLT 3.9%
Vue 1.4%
Other 2.3%
Find a file
Nick Clemens e609e20c04
Bug 31086: Prevent placing hold with no pickup location 
To test:
1 - Apply patch
2 - Repeat test on previous patch
3 - You should get a warning popup when attempting to save hold
4 - Reload page
5 - Inspect the HTML and manualy set #pickup value of selected option to ""
6 - Attempt to save hold
7 - You get the popup
8 - Place a hold normally (with location) and verify it works

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-07-22 14:19:17 -03:00
acqui Bug 14680: Always subtract discount from price to calculate estimated cost 2022-07-18 11:17:50 -03:00
admin Bug 29001: Fix framework edition when subfields are reordered 2022-07-21 15:57:25 -03:00
api Bug 31128: Add effective_not_for_loan_status into items response 2022-07-22 11:32:26 -03:00
authorities Bug 29333: Fix encoding of imported UNIMARC authorities 2022-07-08 15:43:33 -03:00
basket Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes 2022-06-06 14:26:51 -03:00
bin
C4 Bug 31202: Don't remove optional SIP fields with a value of "0" 2022-07-21 15:55:56 -03:00
catalogue Bug 31213: Auto search simple term quoted 2022-07-22 11:11:19 -03:00
cataloguing Bug 30909: Retain permanent_location if mapped 2022-07-20 09:05:45 -03:00
circ Bug 31192: Check for item before calling is_bundle 2022-07-20 11:50:05 -03:00
clubs
course_reserves Bug 30409: barcodedecode() should always trim barcode 2022-06-14 07:54:58 -03:00
debian Bug 21903: (follow-up) update documentation 2022-07-05 11:46:37 -03:00
docs Bug 30808: Add the 22.05 release team. 2022-05-25 23:56:12 -10:00
errors Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI 2022-04-20 09:03:39 -10:00
etc Bug 29936: Add holds_get_captured option to sip config 2022-05-05 11:17:37 -10:00
ill
installer Bug 31086: DB update 2022-07-22 14:19:12 -03:00
Koha Bug 31086: Throw an exception when a hold is stored with no branchcode 2022-07-22 14:19:17 -03:00
koha-tmpl Bug 31086: Prevent placing hold with no pickup location 2022-07-22 14:19:17 -03:00
labels Bug 31137: (QA follow-up) Also fix new template page 2022-07-18 10:22:30 -03:00
lib/CGI/Session/Serialize
members Bug 23838: Add renewals modal 2022-07-22 11:39:09 -03:00
misc Bug 31122: Terminology - Replace occurences of 'Notices & slips' with 'Notices and slips' 2022-07-08 15:08:23 -03:00
offline_circ Bug 30275: Rename issues.renewals to issues.renewals_count 2022-07-05 09:45:55 -03:00
opac Bug 31213: Auto search simple term quoted 2022-07-22 11:11:19 -03:00
patron_lists
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins Bug 29787: Add plugin version to plugin search results 2022-04-08 15:49:15 +02:00
pos
recalls Bug 30924: Add missing branchtransfers.reason value for recall cancellation 2022-06-13 10:30:51 -03:00
reports Bug 27045: Fix items lost report export if delimiter is tab 2022-07-20 11:50:40 -03:00
reserve Bug 30960: Fix JS error message when no pick-up location is selected when placing a hold 2022-06-20 10:44:04 -03:00
reviews
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials Bug 27045: (follow-up) Fix delimiter in header rows 2022-07-20 11:50:41 -03:00
services
skel
suggestion Bug 23991: Move SearchSuggestion to Koha::Suggestions 2022-06-27 12:30:28 -03:00
svc Bug 25498: Add transfer button on intranet 2022-07-19 11:25:23 -03:00
t Bug 31128: Unit tests 2022-07-22 11:32:21 -03:00
tags
tmp/modified_authorities
tools Bug 31000: Warn removal: param record_type can be undef 2022-07-11 18:20:15 -03:00
virtualshelves Bug 30933: (follow-up) Use cannot_be_transferred in shelves scripts 2022-07-20 09:04:07 -03:00
xt Bug 27619: (QA follow-up) Remove xt/sample_notices.t 2022-05-11 11:28:48 +01:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json
.gitignore
.htaccess
.mailmap 22.05.00: Update mailmap 2022-05-25 23:56:12 -10:00
.perlcriticrc
.proverc.dist
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 27667: Display a warning for records missing in Elasticsearch 2022-07-18 14:53:15 -03:00
app.psgi
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 25669: (follow-up) Minor fixes 2022-06-23 11:30:44 -03:00
fix-perl-path.PL Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
gulpfile.js Bug 30373: Enable translation of UNIMARC frameworks 2022-04-21 13:41:35 -10:00
help.pl
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 30933: DBRev 22.06.00.019 2022-07-20 09:16:47 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl
Makefile.PL Bug 19532: Database and installer stuff 2022-03-14 22:45:50 -10:00
MANIFEST.SKIP
package.json
README
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
yarn.lock

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo