Main Koha release repository https://koha-community.org
Find a file
Jonathan Druart fc96399c95 Bug 28622: (bug 15758 follow-up) Remove incorrect branch selection in adv search
From
  commit df97814f30
  Bug 15758: Koha::Libraries - Remove GetBranches

+    selected_branchcode => ( C4::Context->IsSuperLibrarian ? C4::Context->userenv : '' ),

And

-        [% PROCESS options_for_libraries libraries => Branches.all() %]
+        [%# FIXME Should not we filter the libraries displayed? %]
+        [% PROCESS options_for_libraries libraries => Branches.all( selected => selected_branchcode, unfiltered => 1 ) %]

The change in the pl is wrong as it should pass C4::Context->userenv->{branch},
but prior to this commit it seems that we didn't select the logged in
library anyway.

Looks like we should remove this code but preserve the current behavior and select "All libraries".

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-07-26 10:39:22 +02:00
acqui Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
admin Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
api Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
authorities Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
basket Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
C4 Bug 28660: (bug 21325 follow-up) Fix auto self check 2021-07-22 08:12:51 +02:00
catalogue Bug 28622: (bug 15758 follow-up) Remove incorrect branch selection in adv search 2021-07-26 10:39:22 +02:00
cataloguing Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
circ Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
clubs Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
course_reserves Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
debian Bug 27348: Fix test on ALTERNATE_INDEXER_DAEMON in koha-indexer 2021-06-21 12:07:28 +02:00
docs Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
errors Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
etc Bug 8280: Add koha set and item fields to pqf.properties 2021-06-21 14:01:50 +02:00
ill Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
installer Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Koha Bug 22801: (follow-up) Use date-of-publication directly 2021-07-26 10:39:18 +02:00
koha-tmpl Bug 28622: (bug 15758 follow-up) Remove incorrect branch selection in adv search 2021-07-26 10:39:22 +02:00
labels Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
lib/CGI/Session/Serialize Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
members Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
misc Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
offline_circ Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
opac Bug 28731: (bug 17600 follow-up) Import necessary subroutines in reports svc endpoint 2021-07-21 17:04:06 +02:00
patron_lists Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
patroncards Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
plugins Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
pos Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
reports Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
reserve Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
reviews Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
services Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
skel
suggestion Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
svc Bug 28731: (bug 17600 follow-up) Import necessary subroutines in reports svc endpoint 2021-07-21 17:04:06 +02:00
t Bug 22801: (follow-up) Use date-of-publication directly 2021-07-26 10:39:18 +02:00
tags Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
tmp/modified_authorities
tools Bug 28745: (bug 28158 follow-up) Restore the items table once the job is done 2021-07-23 15:02:26 +02:00
virtualshelves Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
xt Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap Bug 28386: Disambiguate Tomas and Blou 2021-05-26 12:30:59 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml
about.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28317: Use the default CGI::Session serializer 2021-05-19 14:45:32 +02:00
fix-perl-path.PL Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
gulpfile.js Bug 27072: Don't process staff interface CSS with rtlcss 2020-11-24 21:27:59 +01:00
help.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 20472: DBRev 21.06.00.010 2021-07-12 15:47:34 +02:00
koha_perl_deps.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
LICENSE
mainpage.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Makefile.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
MANIFEST.SKIP
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
README
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo