Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
44003 commits 35 branches 616 tags 1.8 GiB
Perl 45.6%
JavaScript 39.3%
HTML 7.2%
XSLT 3.7%
Vue 1.4%
Other 2.3%
Find a file
Tomas Cohen Arazi fe0a0ee834 Bug 29807: Make Branches plugin handle empty pickup locations list 
This patch makes the plugin handle empty Koha::Biblio->pickup_locations
and Koha::Item->pickup_locations correctly.

It does so by explicitly calling ->as_list. It also restores the logic
that was changed by 6cd1ffab4e so, now
that ->empty is handled correctly, it doesn't return ALL the pickup
locations when the item/biblio doesn't have valid pickup locations.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Template/Plugin/Branches.t
=> FAIL: Awful error
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2022-01-19 12:13:49 -10:00
acqui Bug 29283: (QA follow-up) Remove code duplication 2021-11-02 14:57:09 +01:00
admin Bug 29391: Improve output of reservoir search 2022-01-09 21:04:17 -10:00
api Bug 29772: (follow-up) Document error codes 2022-01-05 13:33:46 -10:00
authorities Bug 29334: Do not apply defaultvalue to existing auth record 2021-11-15 12:38:39 +01:00
basket Bug 27266: (QA follow-up) Remove GetBiblioData from basket scripts 2021-12-15 12:15:14 -10:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
C4 Bug 29474: Remove one layer of indendation by adding if check in the begginning 2022-01-18 21:15:04 -10:00
catalogue Bug 28959: (QA follow-up) One more lost 'category' to 'public' change 2021-11-02 14:27:12 +01:00
cataloguing Bug 29788: Make Koha::Item->safe_to_delete use Koha::Result::Boolean 2022-01-11 12:38:35 -10:00
circ Bug 29786: Select only specific items for item level holds 2022-01-17 14:55:56 -10:00
clubs Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
course_reserves Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
debian Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
docs Revert "Bug 20076: Add Thibaud Guillot to contributors" 2022-01-13 22:12:53 -10:00
errors Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
etc Bug 18540: Update MARC21 biblio XSL file 2022-01-18 21:15:04 -10:00
ill Bug 22614: Migrate original request 2021-09-21 20:22:57 +02:00
installer Bug 29336: DBRev 21.12.00.009 2022-01-18 21:15:05 -10:00
Koha Bug 29807: Make Branches plugin handle empty pickup locations list 2022-01-19 12:13:49 -10:00
koha-tmpl Bug 18320: Remove calls to CGI->param from the templates in patron cards 2022-01-19 12:13:49 -10:00
labels Bug 17600: Fix POSIX imports 2021-07-29 14:37:26 +02:00
lib/CGI/Session/Serialize Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
members Bug 29758: Get rid of warning in members/boraccount.pl 2022-01-18 21:15:04 -10:00
misc Bug 29704: (RM follow-up) Fix typo sned send 2022-01-18 21:15:04 -10:00
offline_circ Bug 29255: Built-in offline circulation broken with SQL error 2021-11-15 12:38:39 +01:00
opac Bug 29685: Reduce item processing by calculating 'items any available' outside of loop 2022-01-12 21:26:26 -10:00
patron_lists Bug 16446: Add ability to add patrons to list by borrowernumber 2021-10-21 12:24:04 +02:00
patroncards Bug 18320: Remove calls to CGI->param from the templates in patron cards 2022-01-19 12:13:49 -10:00
plugins Bug 28785: Adjust check_cookie_auth calls 2021-10-18 11:28:41 +02:00
pos Bug 28481: (RM follow-up) formatting 2021-12-16 12:13:51 -10:00
reports Bug 28216: Fix vendor list group by in serials statistics wizard 2021-12-14 09:38:10 -10:00
reserve Bug 29736: Restore searching 2022-01-13 16:37:33 -10:00
reviews Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials Bug 29790: Restore warning if deletion of serial item fails 2022-01-11 12:38:35 -10:00
services Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
skel
suggestion Bug 24370: Allow resetting library to ANY 2021-11-02 14:57:04 +01:00
svc Bug 28377: (follow-up) Remove svc/hold/{resume|suspend} 2021-12-16 12:13:51 -10:00
t Bug 29807: Regression tests 2022-01-19 12:13:49 -10:00
tags Bug 29469: (bug 17600 follow-up) Fix tag approval/rejection from staff 2021-11-16 15:49:22 +01:00
tmp/modified_authorities
tools Bug 29717: Remove unecessary DT manipulations from tools/additional-contents.pl 2022-01-13 22:12:53 -10:00
virtualshelves Bug 29669: fix uninitialized value warnings when XSLTParse4Display is called 2021-12-16 12:13:51 -10:00
xt Bug 28617: (QA follow-up) Restore FindBin in two places 2021-12-07 12:16:28 -10:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
.mailmap 21.11.00 - Update .mailmap 2021-11-26 12:26:22 +01:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 28870: Move email address validation to a specific class method 2021-09-28 10:22:36 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 2021-11-02 16:06:51 +01:00
fix-perl-path.PL Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
gulpfile.js Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
help.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 29336: DBRev 21.12.00.009 2022-01-18 21:15:05 -10:00
koha_perl_deps.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
LICENSE
mainpage.pl Bug 29020: Add link on the mainpage for users without admin access 2021-10-19 09:29:09 +02:00
Makefile.PL Bug 28617: Remove kohalib.pl and rely on PERL5LIB 2021-12-07 12:16:28 -10:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
README
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo