Main Koha release repository https://koha-community.org
Find a file
Tomas Cohen Arazi 34acb76a21 Bug 27069: Update existing rules
This patch adds an atomic update file that takes care of translating
existing rules. It constrains the rules to translate to those currently
expected by Koha and leaves any other value out.

To test:
1. Have some manually added rules:
   $ koha-mysql kohadev
   > INSERT INTO circulation_rules (rule_name,rule_value) VALUES
   ('holdallowed', -1);
   > INSERT INTO circulation_rules (rule_name,rule_value) VALUES
   ('holdallowed', 1);
   > INSERT INTO circulation_rules (rule_name,rule_value) VALUES
   ('holdallowed', 2);
   > INSERT INTO circulation_rules (rule_name,rule_value) VALUES
   ('holdallowed', 3);
   > INSERT INTO circulation_rules (rule_name,rule_value) VALUES
   ('holdallowed', 0);
   > INSERT INTO circulation_rules (rule_name,rule_value) VALUES
   ('holdallowed', 4);
2. Apply this patch
3. Run:
   $ updatedatabase
=> SUCCESS: It doesn't explode
4. Verify the created rules were updated correctly:
   > SELECT * FROM circulation_rules WHERE rule_name='holdallowed';
5: Verify all the tests that dealt with this rule still pass!
   $ kshell
  k$ git diff origin/master --name-only | grep -e '\.t$' | \
         xargs prove
=> SUCCESS: Tests pass!
6. Verify the UI handles setting things correctly
7. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-04-07 16:08:04 +02:00
acqui Bug 27828: (bug 24469 follow-up) Add missing import 2021-03-03 11:57:51 +01:00
admin Bug 28092: Add reserve notes column to holds to pull 2021-04-07 16:08:04 +02:00
api Bug 27894: Adapt /holds/:hold_id/pickup_locations 2021-04-07 16:08:04 +02:00
authorities Bug 8976: Sort subfields for authority records 2021-03-01 15:14:22 +01:00
basket Bug 27268: (QA follow-up) Add Koha::Biblios to basket scripts 2021-03-09 17:20:47 +01:00
bin
C4 Bug 27069: Adapt uses of holdallowed 2021-04-07 16:08:04 +02:00
catalogue Bug 27980: Remove itemdata_publisheddate from controller 2021-04-06 15:56:30 +02:00
cataloguing Bug 27738: Set fallback for unset DefaultCountryField008 to |||, "no attempt to code" 2021-04-06 15:56:30 +02:00
circ Bug 22569: Add a 'Transfers to send' report 2021-03-11 11:51:40 +01:00
clubs Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
course_reserves Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
debian Bug 25674: Remove default vhost 2021-03-05 12:27:23 +01:00
docs
errors
etc Bug 8426: Diacritics not being mapped for searching 2021-03-11 11:05:12 +01:00
ill
installer Bug 27069: Update existing rules 2021-04-07 16:08:04 +02:00
Koha Bug 27069: Adapt uses of holdallowed 2021-04-07 16:08:04 +02:00
koha-tmpl Bug 27069: Adapt uses of holdallowed 2021-04-07 16:08:04 +02:00
labels
members Bug 25946: borrowerRelationship can be empty 2021-04-01 17:06:38 +02:00
misc Bug 26459: (follow-up) Clarify language and remove duplicated code 2021-04-07 16:08:04 +02:00
offline_circ Bug 24083: Add support for unseen_renewals 2020-11-11 16:09:58 +01:00
opac Bug 27860: Fix self-registration if messages with incorrect email are inqueued 2021-03-16 12:04:05 +01:00
patron_lists
patroncards Bug 27716: Update permissions for patroncards creator 2021-03-16 16:08:30 +01:00
plugins
pos Bug 24786: Update point of sale to use session register 2020-11-06 15:39:59 +01:00
reports Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-01 11:16:42 +01:00
reserve Bug 26999: (follow-up) Simplify code 2021-04-01 18:51:37 +02:00
reviews Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
rotating_collections Bug 26618: (QA follow-up) Fix unit test for TranferCollection change 2021-03-03 15:36:13 +01:00
serials Bug 28036: Improve breadcrumbs of serial claims page 2021-04-06 15:56:31 +02:00
services
skel
suggestion Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-01 11:16:42 +01:00
svc Bug 26457: Throw exception if update of issues table fails 2021-03-01 10:51:15 +01:00
t Bug 27069: Adjust tests 2021-04-07 16:08:04 +02:00
tags
tmp/modified_authorities
tools Bug 12224: (follow-up) Access old_issues table when editing notice 2021-03-05 13:49:03 +01:00
virtualshelves
xt Bug 27673: Replace YAML with YAML::XS 2021-02-16 14:54:50 +01:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap
.perlcriticrc
.scss-lint.yml
about.pl Bug 22824: Add warning to the about page 2021-03-04 16:18:42 +01:00
app.psgi
changelanguage.pl
cpanfile Bug 27673: remove libyaml-syck-perl, and lower libyaml-libyaml-perl to 0.41 (for u16) 2021-03-01 13:50:03 +01:00
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 27835: DBRev 20.12.00.025 2021-03-18 15:04:47 +01:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 26363: Provide a systemd unit file for koha-worker for source installs 2021-03-01 10:51:15 +01:00
MANIFEST.SKIP
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
README
README.md
README.robots
rewrite-config.PL
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo